From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B1EAC4363A for ; Mon, 5 Oct 2020 13:36:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ED6A420774 for ; Mon, 5 Oct 2020 13:36:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601905013; bh=ZIFB3rgf26rt5j5jyMIodGOuMafdvBhjlRX/3PIzwfs=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=mJZK020GZHyPJ64D9aqnkCtvs0TzyVgnc69l4JCjhBkai7G6q6op24emw+OWOLkKx pFoDCApcs43vX8/taNWHLYWWyxN5jIYLAOCW+9KL5uJ359pim2ECIJKD48nh3BW0UL ASYpVPMB+Qh7G6M1IJppy4HECXZ3f8o0XWFaWsBA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725939AbgJENgw (ORCPT ); Mon, 5 Oct 2020 09:36:52 -0400 Received: from mail.kernel.org ([198.145.29.99]:43134 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725914AbgJENgw (ORCPT ); Mon, 5 Oct 2020 09:36:52 -0400 Received: from mail-oi1-f182.google.com (mail-oi1-f182.google.com [209.85.167.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5ADA720774; Mon, 5 Oct 2020 13:36:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601905011; bh=ZIFB3rgf26rt5j5jyMIodGOuMafdvBhjlRX/3PIzwfs=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=y/aOCBZPeKbzI6w2BUZ53/alYwBumqxwqs9wxTEyFpDNSe7+Iqeu3PBeqs13z2h/U LLziP3TdpkgaDBOgepVjvTyhxQqmYA108Oqo9avokmWyd8d24JD7hrLjIUJLhyxhXU 9SKToKrwm/l3AAw/bUfH4XNk3HooI8RTrykqWRTk= Received: by mail-oi1-f182.google.com with SMTP id t77so5217265oie.4; Mon, 05 Oct 2020 06:36:51 -0700 (PDT) X-Gm-Message-State: AOAM53068eSIuuFbikfCmeP/6EPee1OPcWK/6YWLSLw8Bd3AYveW4blf xtdE3+xkLwdAEQgLRdO85cn05uddb0NwxLiWpQ== X-Google-Smtp-Source: ABdhPJyGs5QRZXi2qUMhyXkN0ZTEB+WjvBFpuxhQAOv16pvutHt7q3CX0sNVLLFIy9B+jn4ovbMkwFpiJqg2gYBlnEQ= X-Received: by 2002:a05:6808:10e:: with SMTP id b14mr9024261oie.152.1601905010756; Mon, 05 Oct 2020 06:36:50 -0700 (PDT) MIME-Version: 1.0 References: <20200922190807.6830-1-qiangqing.zhang@nxp.com> <20200922190807.6830-2-qiangqing.zhang@nxp.com> <20200929155201.GA665464@bogus> <20201003084656.GA29917@gofer.mess.org> In-Reply-To: <20201003084656.GA29917@gofer.mess.org> From: Rob Herring Date: Mon, 5 Oct 2020 08:36:39 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH V3 1/2] bindings: media: gpio-ir-receiver: add linux,autosuspend-period property To: Sean Young Cc: Joakim Zhang , Mauro Carvalho Chehab , Linux Media Mailing List , devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" , NXP Linux Team Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Sat, Oct 3, 2020 at 3:46 AM Sean Young wrote: > > On Tue, Sep 29, 2020 at 10:52:01AM -0500, Rob Herring wrote: > > On Wed, Sep 23, 2020 at 03:08:06AM +0800, Joakim Zhang wrote: > > > Add linux,autosuspend-period property for gpio ir receiver. Some cpuidle > > > systems wake from idle may take a bit long time, for such case, need > > > disable cpuidle temporarily. > > > > > > Signed-off-by: Joakim Zhang > > > --- > > > ChangeLogs: > > > V1->V2: > > > * New add. > > > V2->V3: > > > * linux,autosuspend-period = 125; -> linux,autosuspend-period = <125>; > > > --- > > > Documentation/devicetree/bindings/media/gpio-ir-receiver.txt | 3 +++ > > > 1 file changed, 3 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/media/gpio-ir-receiver.txt b/Documentation/devicetree/bindings/media/gpio-ir-receiver.txt > > > index 58261fb7b408..e1447c9b0e26 100644 > > > --- a/Documentation/devicetree/bindings/media/gpio-ir-receiver.txt > > > +++ b/Documentation/devicetree/bindings/media/gpio-ir-receiver.txt > > > @@ -7,6 +7,8 @@ Required properties: > > > Optional properties: > > > - linux,rc-map-name: see rc.txt file in the same > > > directory. > > > + - linux,autosuspend-period: autosuspend delay time, > > > + the unit is milisecond. > > > > What makes this linux specific? > > Good point. "linux,autosuspend-period" does not say what is being > suspended either. How about "cpuidle-suspend-period" instead? 'cpuidle' is a Linuxism. And you also need a unit suffix. I'm not clear on how autosuspend which is generally how long a peripheral is idle before runtime suspending it relates to this which seems to be concerned with cpu wakeup latency. I'm assuming you need to wake up within a certain time period to capture GPIO edges. Don't you know what this time would be based on IR data rates and can provide that constraint to cpuidle? Also, we can set autosuspend times from sysfs. Why do you need to do this from DT? Rob