From: Rob Herring <robh+dt@kernel.org>
To: Beniamin Bia <beniamin.bia@analog.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Peter Meerwald <pmeerw@pmeerw.net>,
"open list:IIO SUBSYSTEM AND DRIVERS" <linux-iio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
biabeniamin@outlook.com, Hartmut Knaack <knaack.h@gmx.de>,
Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org
Subject: Re: [PATCH 2/3] dt-bindings: iio: amplifiers: Add docs for HMC425A Step Attenuator
Date: Mon, 13 Jan 2020 14:41:19 -0600 [thread overview]
Message-ID: <CAL_JsqKX5X6X72Rq7wY7=RRLnUST+eKTPyEbuXKbFJB0_n5QXQ@mail.gmail.com> (raw)
In-Reply-To: <20200113141555.16117-2-beniamin.bia@analog.com>
On Mon, Jan 13, 2020 at 8:14 AM Beniamin Bia <beniamin.bia@analog.com> wrote:
>
> From: Michael Hennerich <michael.hennerich@analog.com>
>
> Document support for Analog Devices MC425A Step Attenuator.
>
> Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
> Signed-off-by: Beniamin Bia <beniamin.bia@analog.com>
> ---
> .../bindings/iio/amplifiers/adi,hmc425a.yaml | 55 +++++++++++++++++++
> 1 file changed, 55 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/amplifiers/adi,hmc425a.yaml
Check your bindings with 'make dt_binding_check'. It fails:
Documentation/devicetree/bindings/iio/amplifiers/adi,hmc425a.yaml:
while scanning a simple key
in "<unicode string>", line 24, column 5
could not find expected ':'
in "<unicode string>", line 25, column 5
>
> diff --git a/Documentation/devicetree/bindings/iio/amplifiers/adi,hmc425a.yaml b/Documentation/devicetree/bindings/iio/amplifiers/adi,hmc425a.yaml
> new file mode 100644
> index 000000000000..6f4a292395e4
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/amplifiers/adi,hmc425a.yaml
> @@ -0,0 +1,55 @@
> +# SPDX-License-Identifier: GPL-2.0
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/amplifiers/adi,hmc425a.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: HMC425A 6-bit Digital Step Attenuator
> +
> +maintainers:
> +- Michael Hennerich <michael.hennerich@analog.com>
> +
> +description: |
> + Digital Step Attenuator IIO device with gpio interface.
> + HMC425A 0.5 dB LSB GaAs MMIC 6-BIT DIGITAL POSITIVE CONTROL ATTENUATOR, 2.2 - 8.0 GHz
> + https://www.analog.com/media/en/technical-documentation/data-sheets/hmc425A.pdf
> +
> +properties:
> +compatible:
> + enum:
> + - adi,hmc425a
nit: this should be indented 2 more spaces.
Or use 'const' instead if there's not more similar parts.
> +
> +vcc-supply:
> + description:
> + digital voltage regulator (see regulator/regulator.txt)
Text must be indented under the key.
> + maxItems: 1
> +
> +ctrl-gpios:
> + description:
> + Must contain an array of 6 GPIO specifiers, referring to the GPIO pins
> + connected to the control pins V1-V6.
> + maxItems: 6
> +
> +required:
> +- compatible
> +- ctrl-gpios
> +
> +examples:
> +- |
> + #include <dt-bindings/gpio/gpio.h>
> +
> + &gpio {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + gpio_hmc425a: hmc425a {
> + compatible = "adi,hmc425a";
> + ctrl-gpios = <&gpio 40 GPIO_ACTIVE_HIGH>,
> + <&gpio 39 GPIO_ACTIVE_HIGH>,
> + <&gpio 38 GPIO_ACTIVE_HIGH>,
> + <&gpio 37 GPIO_ACTIVE_HIGH>,
> + <&gpio 36 GPIO_ACTIVE_HIGH>,
> + <&gpio 35 GPIO_ACTIVE_HIGH>;
> +
> + vcc-supply = <&foo>;
> + };
> + }
> --
> 2.17.1
>
next prev parent reply other threads:[~2020-01-13 20:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-13 14:15 [PATCH 1/3] iio: amplifiers: hmc425a: Add support for HMC425A step attenuator with gpio interface Beniamin Bia
2020-01-13 14:15 ` [PATCH 2/3] dt-bindings: iio: amplifiers: Add docs for HMC425A Step Attenuator Beniamin Bia
2020-01-13 20:41 ` Rob Herring [this message]
2020-01-13 14:15 ` [PATCH 3/3] MAINTAINERS: add entry for hmc425a driver Beniamin Bia
2020-01-13 20:57 ` [PATCH 1/3] iio: amplifiers: hmc425a: Add support for HMC425A step attenuator with gpio interface Lars-Peter Clausen
2020-01-14 7:27 ` Ardelean, Alexandru
2020-01-16 18:29 ` Jonathan Cameron
2020-01-14 7:16 ` Ardelean, Alexandru
2020-01-18 13:54 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL_JsqKX5X6X72Rq7wY7=RRLnUST+eKTPyEbuXKbFJB0_n5QXQ@mail.gmail.com' \
--to=robh+dt@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=beniamin.bia@analog.com \
--cc=biabeniamin@outlook.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).