devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-serial <linux-serial@vger.kernel.org>,
	devicetree <devicetree@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] dt-bindings: serial: Add label property for pl011
Date: Wed, 21 Apr 2021 08:53:32 -0500	[thread overview]
Message-ID: <CAL_JsqKggh0XDCHg8E694Zjuz2yiJ6tkxHDBDsMM3Y_XiZxypA@mail.gmail.com> (raw)
In-Reply-To: <fa6c6079-8061-5774-8252-31956ac84ae2@huawei.com>

On Wed, Apr 21, 2021 at 4:38 AM Leizhen (ThunderTown)
<thunder.leizhen@huawei.com> wrote:
>
>
>
> On 2021/4/21 4:02, Rob Herring wrote:
> > On Thu, Apr 15, 2021 at 03:31:05PM +0800, Zhen Lei wrote:
> >> When there is more than one pl011 serial port present, the label property
> >> allows a custom name to be used for briefly describe the usage or position
> >> of each serial port.
> >>
> >> Without this "label" property, many dtbs_check warnings similar to the
> >> following are reported:
> >> arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dt.yaml: \
> >> serial@ffd74000: Additional properties are not allowed ('label' was unexpected)
> >>         From schema: Documentation/devicetree/bindings/serial/pl011.yaml
> >
> > I think this should go into serial.yaml instead.
>
> Yes，But if I add "label: true" into serial.yaml, it doesn't work. I haven't figured out why.

Change the 'additionalProperties: false' to 'unevaluatedProperties: false'.

> By the way, should "$ref: /schemas/serial.yaml#" be replaced with "$ref: /schemas/serial/serial.yaml#"?

Oh, yes! Looks like it should be fixed for the other serial schemas
too. There is a /schemas/serial.yaml schema from dt-schema which
predates the kernel one, but it just has the $nodename. The kernel one
is much more complete.

Rob

  reply	other threads:[~2021-04-21 13:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-15  7:31 [PATCH 1/1] dt-bindings: serial: Add label property for pl011 Zhen Lei
2021-04-20 20:02 ` Rob Herring
2021-04-21  9:38   ` Leizhen (ThunderTown)
2021-04-21 13:53     ` Rob Herring [this message]
2021-04-22  3:10       ` Leizhen (ThunderTown)
2021-04-22  8:57         ` Leizhen (ThunderTown)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAL_JsqKggh0XDCHg8E694Zjuz2yiJ6tkxHDBDsMM3Y_XiZxypA@mail.gmail.com \
    --to=robh@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=thunder.leizhen@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).