From: Rob Herring <robh@kernel.org>
To: Tamizh Chelvam <tamizhr@codeaurora.org>
Cc: ath10k@lists.infradead.org, devicetree@vger.kernel.org,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 1/2] dt-bindings: ath10k: Add new dt entries to identify coex support
Date: Mon, 30 Dec 2019 11:02:02 -0700 [thread overview]
Message-ID: <CAL_JsqKspnQ50Muw-jeq+uE1+vj5nuzpxmYcOSFwY+n2Gj3tXA@mail.gmail.com> (raw)
In-Reply-To: <62b9e7b140a96401469f7075811d0d67@codeaurora.org>
On Sun, Dec 29, 2019 at 10:07 PM <tamizhr@codeaurora.org> wrote:
>
> Hi Rob,
>
> Thanks for your review comments.
>
> >> This adds new dt entries qcom,coexist-support and
> >> qcom,coexist-gpio-pin
> >> which will be used by ath10k driver to identify coex support
> >> of a hardware and notify wifi firmware the gpio pin number.
> >> This pin number information is needed for the hardware QCA4019.
> >>
> >> Signed-off-by: Tamizh Chelvam <tamizhr@codeaurora.org>
> >> ---
> >> Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt | 6
> >> ++++++
> >> 1 file changed, 6 insertions(+)
> >>
> >> diff --git
> >> a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
> >> b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
> >> index 0171283..a41e936 100644
> >> --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
> >> +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
> >> @@ -87,6 +87,10 @@ Optional properties:
> >> Definition: Quirk specifying that the firmware expects the 8bit
> >> version
> >> of the host capability QMI request
> >> - qcom,xo-cal-data: xo cal offset to be configured in xo trim
> >> register.
> >> +- qcom,coexist-support : should contain eithr "0" or "1" to indicate
typo
> >> coex
> >> + support by the hardware.
> >> +- qcom,coexist-gpio-pin : gpio pin number information to support
> >> coex
> >> + which will be used by wifi firmware.
> >
> > What combinations of these 2 properties are valid?
> >
> > Is qcom,coexist-gpio-pin required for coexist support? If so then it
> > alone should be enough to enable/disable coexist.
> >
> qcom,coexist-gpio-pin is required for QCA4019 devices. And other ath10k
> devices doesn't required that value.
> So only added two fields to enable/disable coexist and another for
> notifying the gpio pin info.
Okay.
'qcom,coexist-support' can be boolean instead. Unless you need it to
override a default setting.
Rob
prev parent reply other threads:[~2019-12-30 18:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-16 11:40 [PATCH 1/2] dt-bindings: ath10k: Add new dt entries to identify coex support Tamizh Chelvam
2019-12-16 11:40 ` [PATCH 2/2] ath10k: Add support to read btcoex related data from DT Tamizh Chelvam
2019-12-26 18:51 ` [PATCH 1/2] dt-bindings: ath10k: Add new dt entries to identify coex support Rob Herring
2019-12-30 5:07 ` tamizhr
2019-12-30 18:02 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_JsqKspnQ50Muw-jeq+uE1+vj5nuzpxmYcOSFwY+n2Gj3tXA@mail.gmail.com \
--to=robh@kernel.org \
--cc=ath10k@lists.infradead.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=tamizhr@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).