Linux-Devicetree Archive on lore.kernel.org
 help / color / Atom feed
From: Rob Herring <robh@kernel.org>
To: Michal Simek <michal.simek@xilinx.com>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"u-boot@lists.denx.de" <u-boot@lists.denx.de>,
	Tom Rini <trini@konsulko.com>,
	Loic Poulain <loic.poulain@linaro.org>
Subject: Re: u-boot DT configuration node
Date: Wed, 29 Apr 2020 09:55:00 -0500
Message-ID: <CAL_JsqLMDqpkyg-Q7mUfw-XH67-v068Q6e9wTq2UOoN=0-_coQ@mail.gmail.com> (raw)
In-Reply-To: <845e6a12-ca33-957f-debb-4a1fcec70742@xilinx.com>

On Tue, Apr 28, 2020 at 8:51 AM Michal Simek <michal.simek@xilinx.com> wrote:
>
> On 28. 04. 20 15:23, Rob Herring wrote:
> > On Wed, Apr 1, 2020 at 4:23 AM Michal Simek <michal.simek@xilinx.com> wrote:
> >>
> >> Hi Rob and others,
> >>
> >> for couple of years already u-boot is using config node in root DT for
> >> u-boot configuration.
> >>
> >> Here is one example in u-boot source code.
> >> https://gitlab.denx.de/u-boot/u-boot/-/blob/master/arch/arm/dts/exynos5250-spring.dts#L47
> >>
> >> And here is dt binding description
> >> https://gitlab.denx.de/u-boot/u-boot/-/blob/master/doc/device-tree-bindings/config.txt
> >>
> >> I was checking dt binding specification and there no such a thing
> >> described there. It means I expect this is more adhoc u-boot solution.
> >> We have reached the point where could be beneficial to put some u-boot
> >> specific configurations to DT.
> >>
> >> Actually I have done similar thing some time ago too by using chosen
> >> node and add xilinx specific property there to point to eeprom.
> >> https://gitlab.denx.de/u-boot/u-boot/-/blob/master/arch/arm/dts/zynqmp-zcu102-revA.dts#L39
> >
> > In this case, I think an alias should be used as it's more of just a
> > shortcut to finding a specific node.
>
> What alias name do you suggest to use?
> We have systems where one i2c eeprom described based board and another
> i2c eeprom describe bootable module. And I need to have shotcuts to both
> of them.
>
> dt specification doesn't list any keywords for aliases but there is
> generic name recommendation.

I do want make aliases a registered list of names.

> Based on keywords it should look like this.
> eeprom0 = ...;
> eeprom1 = ...;

That was my initial thought, but maybe "nvmemX" to be a bit more generic.


> >> I think it is a time to discuss it and do it properly.
> >>
> >> First of all my question is where we could list SW prefixes to make sure
> >> that they are listed and everybody is aware about it. We have
> >> vendor-prefixes and we should have a way to record also prefixes for sw
> >> projects. U-Boot is using u-boot. Xen has file in the kernel with using
> >> xen prefix. At least these two should be listed.
> >
> > Documentation/devicetree/bindings/vendor-prefixes.yaml.
>
> thx
>
> >
> >> Next my question is what is the recommended way to pass sw specific
> >> parameters via DT? I think using chosen node is more appropriate then
> >> adhoc config node. Or is there a better way how this should be done?
> >
> > /chosen
> >
> > For vendor specific things though I would be cautious. If they are
> > settings for a specific device, then they probably belong in the
> > device's node. Second, are they really vendor specific? What we don't
> > want is each vendor doing the same thing in slightly different ways.
>
> For u-boot specific setting like - offsets it should be generic for
> everybody. I was already talking to Loic that for saving u-boot
> variables to QSPI we should be using MTD partition map and put there
> maybe a flag to say that this is the location for storing them.

I'd standardize on the partition name.

Rob

  reply index

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-01  9:23 Michal Simek
2020-04-01 18:09 ` Mark Kettenis
2020-04-02  6:05   ` Michal Simek
2020-04-02 11:34     ` Mark Kettenis
2020-04-08  6:57       ` Michal Simek
2020-04-27 12:06         ` Michal Simek
2020-04-28 13:23 ` Rob Herring
2020-04-28 13:50   ` Michal Simek
2020-04-29 14:55     ` Rob Herring [this message]
2020-04-30 11:13       ` Michal Simek
2020-05-14 18:07         ` Rob Herring
2020-05-14 18:46           ` Michal Simek
2020-05-18 15:55             ` Rob Herring
2020-05-18 16:05               ` Michal Simek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAL_JsqLMDqpkyg-Q7mUfw-XH67-v068Q6e9wTq2UOoN=0-_coQ@mail.gmail.com' \
    --to=robh@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=loic.poulain@linaro.org \
    --cc=michal.simek@xilinx.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Devicetree Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-devicetree/0 linux-devicetree/git/0.git
	git clone --mirror https://lore.kernel.org/linux-devicetree/1 linux-devicetree/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-devicetree linux-devicetree/ https://lore.kernel.org/linux-devicetree \
		devicetree@vger.kernel.org
	public-inbox-index linux-devicetree

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-devicetree


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git