From: Rob Herring <robh+dt@kernel.org>
To: Christophe ROULLIER <christophe.roullier@st.com>
Cc: Maxime Ripard <mripard@kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"martin.blumenstingl@googlemail.com"
<martin.blumenstingl@googlemail.com>,
"alexandru.ardelean@analog.com" <alexandru.ardelean@analog.com>,
"narmstrong@baylibre.com" <narmstrong@baylibre.com>,
"mcoquelin.stm32@gmail.com" <mcoquelin.stm32@gmail.com>,
Alexandre TORGUE <alexandre.torgue@st.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-stm32@st-md-mailman.stormreply.com"
<linux-stm32@st-md-mailman.stormreply.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/2] dt-bindings: net: dwmac: increase 'maxItems' for 'clocks', 'clock-names' properties
Date: Thu, 9 Jan 2020 15:34:20 -0600 [thread overview]
Message-ID: <CAL_JsqLQoo0RMtdKgYbWP=wUiO6z2QM7tVzGJv_iMekFKQUDiQ@mail.gmail.com> (raw)
In-Reply-To: <009e8c0e-6a72-7e14-699e-8a897199ae16@st.com>
On Thu, Jan 9, 2020 at 3:07 AM Christophe ROULLIER
<christophe.roullier@st.com> wrote:
>
> On 15/11/2019 08:50, Maxime Ripard wrote:
> > On Fri, Nov 08, 2019 at 01:02:14PM +0000, Christophe ROULLIER wrote:
> >> On 11/8/19 11:42 AM, Maxime Ripard wrote:
> >>> Hi,
> >>>
> >>> On Fri, Nov 08, 2019 at 11:35:25AM +0100, Christophe Roullier wrote:
> >>>> This change is needed for some soc based on snps,dwmac, which have
> >>>> more than 3 clocks.
> >>>>
> >>>> Signed-off-by: Christophe Roullier <christophe.roullier@st.com>
> >>>> ---
> >>>> Documentation/devicetree/bindings/net/snps,dwmac.yaml | 8 +++++++-
> >>>> 1 file changed, 7 insertions(+), 1 deletion(-)
> >>>>
> >>>> diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> >>>> index 4845e29411e4..376a531062c2 100644
> >>>> --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> >>>> +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> >>>> @@ -27,6 +27,7 @@ select:
> >>>> - snps,dwmac-3.710
> >>>> - snps,dwmac-4.00
> >>>> - snps,dwmac-4.10a
> >>>> + - snps,dwmac-4.20a
> >>>> - snps,dwxgmac
> >>>> - snps,dwxgmac-2.10
> >>>>
> >>>> @@ -62,6 +63,7 @@ properties:
> >>>> - snps,dwmac-3.710
> >>>> - snps,dwmac-4.00
> >>>> - snps,dwmac-4.10a
> >>>> + - snps,dwmac-4.20a
> >>>> - snps,dwxgmac
> >>>> - snps,dwxgmac-2.10
> >>>>
> >>>> @@ -87,7 +89,8 @@ properties:
> >>>>
> >>>> clocks:
> >>>> minItems: 1
> >>>> - maxItems: 3
> >>>> + maxItems: 5
> >>>> + additionalItems: true
> >>> Those additional clocks should be documented
> >>>
> >>> Maxime
> >> Hi Maxime,
> >>
> >> The problem it is specific to our soc, so is it possible to
> >>
> >> propose "optional clock" for 2 extras clocks in snps,dwmac.yaml
> >>
> >> and "official" description in soc yaml file (stm32-dwmac.yaml) ?
> >>
> >> clocks:
> >> minItems: 1
> >> maxItems: 5
> >> additionalItems: true
> >> items:
> >> - description: GMAC main clock
> >> - description: Peripheral registers interface clock
> >> - description:
> >> PTP reference clock. This clock is used for programming the
> >> Timestamp Addend Register. If not passed then the system
> >> clock will be used and this is fine on some platforms.
> >>
> >> + - description: optional clock
> >>
> >> + - description: optional clock
> > I guess we'd really need to figure out what those clocks are doing,
> > they are probably helpful (and used, under a different name) by
> > others.
> >
> > Hopefully the questions Rob asked will clear that out
>
> Rob, do you have any ideas, suggestions ?
Answer my questions from patch 2:
> What does 'power mode' mean? IIRC, some DW MACs have a clock for WoL
> called LPI or something. Are you sure this is ST specific and not DW
> config or version specific?
next prev parent reply other threads:[~2020-01-09 21:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-08 10:35 [PATCH 0/2] Convert stm32 dwmac to DT schema Christophe Roullier
2019-11-08 10:35 ` [PATCH 1/2] dt-bindings: net: dwmac: increase 'maxItems' for 'clocks', 'clock-names' properties Christophe Roullier
2019-11-08 10:42 ` Maxime Ripard
2019-11-08 13:02 ` Christophe ROULLIER
2019-11-15 7:50 ` Maxime Ripard
2020-01-09 9:07 ` Christophe ROULLIER
2020-01-09 21:34 ` Rob Herring [this message]
2019-11-08 10:35 ` [PATCH 2/2] dt-bindings: net: dwmac: Convert stm32 dwmac to DT schema Christophe Roullier
2019-11-14 18:22 ` Rob Herring
2020-01-14 11:09 ` Christophe ROULLIER
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL_JsqLQoo0RMtdKgYbWP=wUiO6z2QM7tVzGJv_iMekFKQUDiQ@mail.gmail.com' \
--to=robh+dt@kernel.org \
--cc=alexandre.torgue@st.com \
--cc=alexandru.ardelean@analog.com \
--cc=christophe.roullier@st.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mark.rutland@arm.com \
--cc=martin.blumenstingl@googlemail.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=mripard@kernel.org \
--cc=narmstrong@baylibre.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).