From: Rob Herring <robh@kernel.org>
To: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
Cc: devicetree@vger.kernel.org, Nick Dyer <nick@shmanahar.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Mark Rutland <mark.rutland@arm.com>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Ludovic Desroches <ludovic.desroches@microchip.com>,
Linux Input <linux-input@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Helen Koike <helen.koike@collabora.com>,
Ezequiel Garcia <ezequiel@collabora.com>,
Collabora Kernel ML <kernel@collabora.com>,
dafna3@gmail.com
Subject: Re: [PATCH] dt-bindings: input: atmel_mxt_ts: convert atmel,maxtouch.txt to yaml
Date: Wed, 11 Mar 2020 10:48:39 -0500 [thread overview]
Message-ID: <CAL_JsqLTMdG-=_pTPsazspEO3LtDth=xm9s8sqzW+AswWttKJA@mail.gmail.com> (raw)
In-Reply-To: <f612396e-e5e2-db76-6297-a108b53e4000@collabora.com>
On Wed, Mar 11, 2020 at 10:23 AM Dafna Hirschfeld
<dafna.hirschfeld@collabora.com> wrote:
>
> Hi,
> Thanks for the review
>
> On 10.03.20 22:14, Rob Herring wrote:
> > On Tue, Mar 03, 2020 at 07:25:33PM +0200, Dafna Hirschfeld wrote:
> >> Convert the binding file atmel,maxtouch.txt to yaml format.
> >> Also change the file name in the MAINTAINERS file.
> >>
> >> This was tested and verified on ARM and ARM64 with:
> >>
> >> make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/input/atmel,maxtouch.yaml
> >> make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/input/atmel,maxtouch.yaml
> >>
> >> Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
> >> ---
> >> .../bindings/input/atmel,maxtouch.txt | 41 ------------
> >> .../bindings/input/atmel,maxtouch.yaml | 64 +++++++++++++++++++
> >> MAINTAINERS | 2 +-
> >> 3 files changed, 65 insertions(+), 42 deletions(-)
> >> delete mode 100644 Documentation/devicetree/bindings/input/atmel,maxtouch.txt
> >> create mode 100644 Documentation/devicetree/bindings/input/atmel,maxtouch.yaml
> >>
> >> diff --git a/Documentation/devicetree/bindings/input/atmel,maxtouch.txt b/Documentation/devicetree/bindings/input/atmel,maxtouch.txt
> >> deleted file mode 100644
> >> index c88919480d37..000000000000
> >> --- a/Documentation/devicetree/bindings/input/atmel,maxtouch.txt
> >> +++ /dev/null
> >> @@ -1,41 +0,0 @@
> >> -Atmel maXTouch touchscreen/touchpad
> >> -
> >> -Required properties:
> >> -- compatible:
> >> - atmel,maxtouch
> >> -
> >> - The following compatibles have been used in various products but are
> >> - deprecated:
> >> - atmel,qt602240_ts
> >> - atmel,atmel_mxt_ts
> >> - atmel,atmel_mxt_tp
> >> - atmel,mXT224
> >> -
> >> -- reg: The I2C address of the device
> >> -
> >> -- interrupts: The sink for the touchpad's IRQ output
> >> - See ../interrupt-controller/interrupts.txt
> >> -
> >> -Optional properties for main touchpad device:
> >> -
> >> -- linux,gpio-keymap: When enabled, the SPT_GPIOPWN_T19 object sends messages
> >> - on GPIO bit changes. An array of up to 8 entries can be provided
> >> - indicating the Linux keycode mapped to each bit of the status byte,
> >> - starting at the LSB. Linux keycodes are defined in
> >> - <dt-bindings/input/input.h>.
> >> -
> >> - Note: the numbering of the GPIOs and the bit they start at varies between
> >> - maXTouch devices. You must either refer to the documentation, or
> >> - experiment to determine which bit corresponds to which input. Use
> >> - KEY_RESERVED for unused padding values.
> >> -
> >> -- reset-gpios: GPIO specifier for the touchscreen's reset pin (active low)
> >> -
> >> -Example:
> >> -
> >> - touch@4b {
> >> - compatible = "atmel,maxtouch";
> >> - reg = <0x4b>;
> >> - interrupt-parent = <&gpio>;
> >> - interrupts = <TEGRA_GPIO(W, 3) IRQ_TYPE_LEVEL_LOW>;
> >> - };
> >> diff --git a/Documentation/devicetree/bindings/input/atmel,maxtouch.yaml b/Documentation/devicetree/bindings/input/atmel,maxtouch.yaml
> >> new file mode 100644
> >> index 000000000000..024dc4ded4f3
> >> --- /dev/null
> >> +++ b/Documentation/devicetree/bindings/input/atmel,maxtouch.yaml
> >> @@ -0,0 +1,64 @@
> >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> >> +%YAML 1.2
> >> +---
> >> +$id: http://devicetree.org/schemas/input/atmel,maxtouch.yaml#
> >> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> >> +
> >> +title: Atmel maXTouch touchscreen/touchpad
> >> +
> >> +maintainers:
> >> + - Nick Dyer <nick@shmanahar.org>
> >> +
> >> +description: |
> >> + Atmel maXTouch touchscreen/touchpad
> >> +
> >> +properties:
> >> + compatible:
> >> + const: atmel,maxtouch
> >> +
> >> + reg:
> >> + description: The I2C address of the device
> >> + maxItems: 1
> >> +
> >> + interrupts:
> >> + description: The sink for the touchpad's IRQ output
> >
> > How many? Needs 'maxItems: 1'>
> > You can drop the description.
> >
> >> +
> >> + linux,gpio-keymap:
> >> + description:
> >> + When enabled, the SPT_GPIOPWN_T19 object sends messages
> >> + on GPIO bit changes. An array of up to 8 entries can be provided
> >> + indicating the Linux keycode mapped to each bit of the status byte,
> >> + starting at the LSB. Linux keycodes are defined in
> >> + <dt-bindings/input/input.h>.
> >> + Note, the numbering of the GPIOs and the bit they start at varies between
> >> + maXTouch devices. You must either refer to the documentation, or
> >> + experiment to determine which bit corresponds to which input. Use
> >> + KEY_RESERVED for unused padding values.
> >> + $ref: /schemas/types.yaml#/definitions/uint32-array
> >> + maxItems: 8
> >> +
> >> + reset-gpios:
> >> + description: GPIO specifier for the touchscreen's reset pin (active low)
> >> + maxItems: 1
> >> +
> >> +required:
> >> + - compatible
> >> + - reg
> >> + - interrupts
> >> +
> >> +additionalProperties: true
> >
> > That's the default and we generally want this to be 'false'.
> but many nodes has more properties not described here so I could not
> set it to false.
Like touchscreen-* properties? Then you should reference
touchscreen.yaml. And add 'unevaluatedProperties: false' here. That
doesn't yet do anything, but will when the tools support the lastest
json-schema release.
Rob
next prev parent reply other threads:[~2020-03-11 15:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-03 17:25 [PATCH] dt-bindings: input: atmel_mxt_ts: convert atmel,maxtouch.txt to yaml Dafna Hirschfeld
2020-03-10 21:14 ` Rob Herring
2020-03-11 15:23 ` Dafna Hirschfeld
2020-03-11 15:48 ` Rob Herring [this message]
2020-03-20 15:21 ` Dafna Hirschfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL_JsqLTMdG-=_pTPsazspEO3LtDth=xm9s8sqzW+AswWttKJA@mail.gmail.com' \
--to=robh@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=dafna.hirschfeld@collabora.com \
--cc=dafna3@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=enric.balletbo@collabora.com \
--cc=ezequiel@collabora.com \
--cc=helen.koike@collabora.com \
--cc=kernel@collabora.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=mark.rutland@arm.com \
--cc=nick@shmanahar.org \
--cc=nicolas.ferre@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).