From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAACEC4338F for ; Tue, 3 Aug 2021 22:11:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9246760184 for ; Tue, 3 Aug 2021 22:11:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230526AbhHCWMI (ORCPT ); Tue, 3 Aug 2021 18:12:08 -0400 Received: from mail.kernel.org ([198.145.29.99]:40478 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229663AbhHCWMH (ORCPT ); Tue, 3 Aug 2021 18:12:07 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 2ECC060EE8; Tue, 3 Aug 2021 22:11:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1628028716; bh=vSQLD2Dx1iWptSqQt/0j5xCISU3XPMV2GPsXMPEtfV0=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=s5haClTxAMXXK+SMtVRQLn48uZKTcUAX14akEg9/wY3BQwYq7AVRcJt5h8zntzWFp /UIT4jYCDh4j67dB934kbf0xKBY0ExfvhUpJLULbpvC9CRLDIfYnc8qFl1r0lBviUg oZFikuRWBM1+EjbbORbQrpPJKFGgOwkP2YiUNOEafg5yicWOMdVeCmIA/ol3lWG4N0 0zBHnEOLov3Y9JnsSytJSucCkhh9DNixVMsecqjjjMcdBykCUp72WEzqHqi5CruOHu j43AHg8y0n5589bpPH9Uk1xP1ZoR1kINMMjfcpYG3F3OQtuHRimmywvEoeL4L6M6KX MDsWmeSO3lv9w== Received: by mail-ed1-f47.google.com with SMTP id p21so980211edi.9; Tue, 03 Aug 2021 15:11:56 -0700 (PDT) X-Gm-Message-State: AOAM533bDacAEsEox1AgNDbp9nbedMzfs3TVsGyUlXie3pVglXRdu4Lg mhIsFrli/3j/ZRa8CW9uZS073lRgvst9tW5vbQ== X-Google-Smtp-Source: ABdhPJy8lulYOjbYH1fj7VhNDQlwD+s1ZfdaUnK40lRIQAEPWK8BCRG86JqAGI6XEr1nfCf6u6Fiu0avOmOqKVXK26M= X-Received: by 2002:a05:6402:291d:: with SMTP id ee29mr28816734edb.289.1628028714789; Tue, 03 Aug 2021 15:11:54 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Rob Herring Date: Tue, 3 Aug 2021 16:11:42 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 0/4] DT schema changes for HiKey970 PCIe hardware to work To: Mauro Carvalho Chehab Cc: Linuxarm , mauro.chehab@huawei.com, Binghui Wang , Gustavo Pimentel , Jingoo Han , Xiaowei Song , devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" , PCI , linux-phy@lists.infradead.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, Aug 2, 2021 at 10:39 PM Mauro Carvalho Chehab wrote: > > Hi Rob, > > That's the third version of the DT bindings for Kirin 970 PCIE and its > corresponding PHY. > > It is identical to v2, except by: > - pcie@7,0 { // Lane 7: Ethernet > + pcie@7,0 { // Lane 6: Ethernet Can you check whether you have DT node links in sysfs for the PCI devices? If you don't, then something is wrong still in the topology or the PCI core is failing to set the DT node pointer in struct device. Though you don't rely on that currently, we want the topology to match. It's possible this never worked on arm/arm64 as mainly powerpc relied on this. I'd like some way to validate the DT matches the PCI topology. We could have a tool that generates the DT structure based on the PCI topology. > at Documentation/devicetree/bindings/pci/hisilicon,kirin-pcie.yaml > > IMO, the best would be to merge this series via your tree, as it > depends on the patch converting the DT bindings for the PCIe DWC > driver. Yes, agreed. Rob