From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A4A5C388F2 for ; Fri, 6 Nov 2020 03:48:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 32091208B8 for ; Fri, 6 Nov 2020 03:48:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Y0OvGdC7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726074AbgKFDsw (ORCPT ); Thu, 5 Nov 2020 22:48:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56620 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726072AbgKFDsv (ORCPT ); Thu, 5 Nov 2020 22:48:51 -0500 Received: from mail-lf1-x143.google.com (mail-lf1-x143.google.com [IPv6:2a00:1450:4864:20::143]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ECDE4C0613D2 for ; Thu, 5 Nov 2020 19:48:49 -0800 (PST) Received: by mail-lf1-x143.google.com with SMTP id s30so5454304lfc.4 for ; Thu, 05 Nov 2020 19:48:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ppVeo0b190qF2Ptj5wRZlt8bVEFE8U+FRbqIrPfzfO0=; b=Y0OvGdC7Ay1jBPx9c95rwCWL5YO1NKIyLtH3RBjJqksuu5AmwVeqJA3yAVePeFJpD+ FNnIveyBAgJypsaK51ANwnqRY7vR4BDOlrKMA1BLxssBAe6rezmriag1QbajUoT/ZYrN ia/BNKgIUF2Dh8y1MMAUsf9DpJByCV5DJS2VJkfHelErXdtSUlMof+LOnHR2w5t7Lgp8 qXDVuCE4fh3v7LRCzvKaV2W42Pcpn+WomjbzeSw0L8WQ5PBPJfLgYXwY7wEsOObmFR7E MQuyqNeRdqW4WggiOLj3w/oToWlhsUSpLUpGXRyZ/xcdo2KG7q7xYzh1w+ag4jRU6Hmu 2PVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ppVeo0b190qF2Ptj5wRZlt8bVEFE8U+FRbqIrPfzfO0=; b=PzRM44KRAJfLh/o3iK+xnq8ibtPn+SoAYKHA0WnJrKl8VWH6fyhz9/3ULS5ZilkCQ5 ZYJ40xtAwls1jb62kLdheqgS4wl7n9jpvFd1MX6tqvAHnpGTG6gD0euK70z92cwDLgz/ rCSg5ZuAhCHRyyWVl0oRRtdEpnqxgZ+9hO5j6hN0gkmcahdZ78UJTZGYnz0nnHZi4yKr bYosqMWreuT1XE2si4naGzcVAmlBlkTNgaoJbvETYtbUh08s2tlf7fp4QCDqtm5Uuwcr q7xjdfeX1Mzj6W6KKaQz3RV/6Uaij6nIcoXI5rXSSadC7Nljso6ErJeCErWGxlbv0VJV 41/g== X-Gm-Message-State: AOAM531yAoTfZbHGHDBS94+MviZc1+YLAkSzgD0jGesMxfoSLJpLDMtS ygqVaUbDQ5wmDqEJIjG+3IgKG4rQuBA7ggHF6oMGDw== X-Google-Smtp-Source: ABdhPJxbdRyNk08Ob4JHGuI4T01MyHskgm3c1DqN+BTCMCllgLD793w6HxN7Xw1dUaB0tfhybEYmpnLfDVXd/P4HXms= X-Received: by 2002:a19:4204:: with SMTP id p4mr39766lfa.536.1604634528395; Thu, 05 Nov 2020 19:48:48 -0800 (PST) MIME-Version: 1.0 References: <20201103103051.34553-1-ajye_huang@compal.corp-partner.google.com> <20201103103051.34553-2-ajye_huang@compal.corp-partner.google.com> <20201105184350.GA1611477@bogus> In-Reply-To: <20201105184350.GA1611477@bogus> From: Ajye Huang Date: Fri, 6 Nov 2020 11:48:37 +0800 Message-ID: Subject: Re: [PATCH v5 1/2] ASoC: google: dt-bindings: modify machine bindings for two MICs case To: Rob Herring Cc: Ajye Huang , Linux Kernel Mailing List , Mark Brown , Rohit kumar , Banajit Goswami , Patrick Lai , Srinivasa Rao Mandadapu , Srini Kandagatla , Andy Gross , Bjorn Andersson , Liam Girdwood , Jaroslav Kysela , Cheng-yi Chiang , Tzung-Bi Shih , Douglas Anderson , "moderated list:ARM/Mediatek SoC support" , linux-arm-msm , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , ALSA development Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org HI, Rob, Thank you for the comments. On Fri, Nov 6, 2020 at 2:43 AM Rob Herring wrote: > > On Tue, Nov 03, 2020 at 06:30:50PM +0800, Ajye Huang wrote: > > Add a property "dmic-gpios" for switching between two MICs. > > > > Signed-off-by: Ajye Huang > > --- > > .../bindings/sound/google,sc7180-trogdor.yaml | 58 +++++++++++++++++++ > > 1 file changed, 58 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/sound/google,sc7180-trogdor.yaml b/Documentation/devicetree/bindings/sound/google,sc7180-trogdor.yaml > > index efc34689d6b5..9e0505467e57 100644 > > --- a/Documentation/devicetree/bindings/sound/google,sc7180-trogdor.yaml > > +++ b/Documentation/devicetree/bindings/sound/google,sc7180-trogdor.yaml > > @@ -34,6 +34,9 @@ properties: > > "#size-cells": > > const: 0 > > > > + dmic-gpios: > > + description: GPIO for switching between DMICs > > Need to define how many (maxItems: 1). Yes, I will add in the v6 version. > > > + > > patternProperties: > > "^dai-link(@[0-9])?$": > > description: > > @@ -81,6 +84,7 @@ additionalProperties: false > > examples: > > > > - | > > + //Example 1 > > sound { > > compatible = "google,sc7180-trogdor"; > > model = "sc7180-rt5682-max98357a-1mic"; > > @@ -128,3 +132,57 @@ examples: > > }; > > }; > > }; > > + > > + - | > > + //Example 2 (2mic case) > > + sound { > > + compatible = "google,sc7180-trogdor"; > > + model = "sc7180-rt5682-max98357a-2mic"; > > + > > + audio-routing = > > + "Headphone Jack", "HPOL", > > + "Headphone Jack", "HPOR"; > > + > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + dmic-gpios = <&tlmm 86 0>; > > Do we really need another example for this? Can't you just add it to the > existing example? I think just keep One example. I will remove the example2 and put dmic-gpios = <&tlmm 86 0>; in the first example and modify the model from "sc7180-rt5682-max98357a-1mic" to "sc7180-rt5682-max98357a-2mic". It looks clear. > > > + > > + dai-link@0 { > > + link-name = "MultiMedia0"; > > + reg = <0>; > > + cpu { > > + sound-dai = <&lpass_cpu 0>; > > + }; > > + > > + codec { > > + sound-dai = <&alc5682 0>; > > + }; > > + }; > > + > > + dai-link@1 { > > + link-name = "MultiMedia1"; > > + reg = <1>; > > + cpu { > > + sound-dai = <&lpass_cpu 1>; > > + }; > > + > > + codec { > > + sound-dai = <&max98357a>; > > + }; > > + }; > > + > > + dai-link@2 { > > + link-name = "MultiMedia2"; > > + reg = <2>; > > + cpu { > > + sound-dai = <&lpass_hdmi 0>; > > + }; > > + > > + codec { > > + sound-dai = <&msm_dp>; > > + }; > > + }; > > + }; > > + > > +... > > -- > > 2.25.1 > >