From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5C69C4741F for ; Tue, 10 Nov 2020 09:40:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4F60320797 for ; Tue, 10 Nov 2020 09:40:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="qO5mwF1J" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726721AbgKJJk4 (ORCPT ); Tue, 10 Nov 2020 04:40:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43780 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726462AbgKJJky (ORCPT ); Tue, 10 Nov 2020 04:40:54 -0500 Received: from mail-lj1-x243.google.com (mail-lj1-x243.google.com [IPv6:2a00:1450:4864:20::243]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CCC84C0613D1 for ; Tue, 10 Nov 2020 01:40:52 -0800 (PST) Received: by mail-lj1-x243.google.com with SMTP id 11so13917280ljf.2 for ; Tue, 10 Nov 2020 01:40:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=AXdt4/GVN4Y6ww6W0kBy4YLHXliyiP6kmKj8D1Wdz+s=; b=qO5mwF1JeGYhP/NW4uBHRxJwCTdGjTfHfchqISCSp2glgneKh+N0XQ6qPPIvY5RAc2 oI0Qjx3dssYp2HnKfVuRxH+R9cmy5asjDX34qDK+PIVEG3npGguBzRWX3gNhCYdV3P3D nDAqGXR9CUQInuueX63CMmJNIk9QZLbY35+STE1FVcwdMXgb1AqMkm5GYy8MHz9atmyI N+AKEA1BC9N2eNYipwv3fQpRCHtdURnd5qnqF2oE60RosuX8WdvlPRJgTAKaQ0l2iZ7Q xR+ku5X7GnBhUJL+E4QYAQJrbPRQIyCVN5xMZ/XBoI2fLk75iI7GRVyk1g1vHeJOLFrH ddhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=AXdt4/GVN4Y6ww6W0kBy4YLHXliyiP6kmKj8D1Wdz+s=; b=izxBkpb//ZjFc9dZQ05GP4OqGnyTwXS8KHFl392qo8HmTngV15+TeOJO1ubF7MPukd d0scGro4UuloxcxebhoMyn4E5rrB/y1IeLXAeR2rAXMUmhLuJp6gBAK4D0WhN58J6Wgw HMqEaQkgyylzG06vue87GNi9dgoeW5FX4J+pS6DKwcuMpREouheoeS9XzVEfuCRcKevY fDG9v1GihJ1LJkMDDk+2I9NcGZ8ftelaWSnesjkKGFtGyWcK6Eeftqa+d5Zv9rMmFjjo 9OjDE6w3JfYjX+xXO1FgYcXdSxUyj+PQCsNBf30ly+diPULrh7lJdRiVcNRKnJRc79D/ RvVA== X-Gm-Message-State: AOAM5318TYgxgcV6lCvzRUME6OBgOjE04PMHAa4aMW8jKM+X/CvB5qz9 Bv+qSkwNn7tNGM/KRgEVuH5UgBu9hdNR6Rmwb0fDIA== X-Google-Smtp-Source: ABdhPJyxnYp8OqaXR3MO5Oeb6TIQXCDHSw6iz4a1K8EfahuJjytShDCZTNTXKb/a7OkIAAffzLbSLY5LhBt3p4R/yAc= X-Received: by 2002:a2e:b54a:: with SMTP id a10mr7500764ljn.139.1605001251219; Tue, 10 Nov 2020 01:40:51 -0800 (PST) MIME-Version: 1.0 References: <20201106061433.1483129-1-ajye_huang@compal.corp-partner.google.com> In-Reply-To: <20201106061433.1483129-1-ajye_huang@compal.corp-partner.google.com> From: Ajye Huang Date: Tue, 10 Nov 2020 17:40:40 +0800 Message-ID: Subject: Re: [PATCH v6 0/2] Modify documentation and machine driver for SC7180 sound card To: Ajye Huang Cc: Linux Kernel Mailing List , Mark Brown , Rohit kumar , Banajit Goswami , Patrick Lai , Srinivasa Rao Mandadapu , Srini Kandagatla , Andy Gross , Bjorn Andersson , Liam Girdwood , Rob Herring , Rob Herring , Jaroslav Kysela , Cheng-yi Chiang , Tzung-Bi Shih , Douglas Anderson , "moderated list:ARM/Mediatek SoC support" , linux-arm-msm , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , ALSA development Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi, Mark Could you please kindly review the series patch v6? And may I get your approval if the review is done. thanks Ajye On Fri, Nov 6, 2020 at 2:14 PM Ajye Huang wrote: > > Note: > - The patch is made by the collaboration of > Ajye Huang > Cheng-Yi Chiang > > v6: > - Documentation: Addressed suggestions from Rob Herring. > - Define "maxItems: 1" in dmic-gpios property. > - Only keep one example and add dmic-gpios property in. > v5: > - Machine driver: > - Fix a format string warning (Reported-by: kernel test robot ). > detailed info at https://lore.kernel.org/patchwork/patch/1331087/ > > v4: > - Machine driver: Addressed suggestions from Tzung-Bi. > - Remove redundant judgments in dmic_set() and dmic_get(). > - Remove 1 level indent of judgment of IS_ERR(data->dmic_sel). > > v3: > - Machine driver: Addressed suggestions from Tzung-Bi. > - Move variables "dmic_switch" and "dmic_sel" into struct sc7180_snd_data. > - Remove redundant judgments in dmic_set(). > > v2: > - Documentation: Modify the dimc-gpios property description and examples. > - Machine driver: > - Remove "qcom,sc7180-sndcard-rt5682-m98357-2mic" compatible > - See gpio property and use anadditional control. > > Thanks for the review! > > Ajye Huang (2): > ASoC: google: dt-bindings: modify machine bindings for two MICs case > ASoC: qcom: sc7180: Modify machine driver for 2mic > > .../bindings/sound/google,sc7180-trogdor.yaml | 8 ++- > sound/soc/qcom/sc7180.c | 61 +++++++++++++++++++ > 2 files changed, 68 insertions(+), 1 deletion(-) > > -- > 2.25.1 >