From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E306C433E1 for ; Wed, 22 Jul 2020 08:10:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 49D0920717 for ; Wed, 22 Jul 2020 08:10:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Ii92gK2l" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726892AbgGVIKC (ORCPT ); Wed, 22 Jul 2020 04:10:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49312 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728753AbgGVIKC (ORCPT ); Wed, 22 Jul 2020 04:10:02 -0400 Received: from mail-ej1-x643.google.com (mail-ej1-x643.google.com [IPv6:2a00:1450:4864:20::643]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CBCEFC0619DF for ; Wed, 22 Jul 2020 01:10:01 -0700 (PDT) Received: by mail-ej1-x643.google.com with SMTP id w6so1240032ejq.6 for ; Wed, 22 Jul 2020 01:10:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8/oqCUNmFc1OqEXIlUblc8Jp0aa/CFYxFmL2eg8Khmw=; b=Ii92gK2l3xsjB7pc4zpJzWubUCqWxaXjaGz1827ZLCYraTZxLI4GEXebasVLB3raxd wZJky5lLRe1rG9dscfydrF0dm1kNwnqgAYnY/3d+QFiJ5FLNDduQYcSlNbi8A6c+hx8y CMQ7YTioQyWvZ58SIDmp13HKuqAcIahEawSKmLIUkXZFAGP7AlJ9epnj8TyhUz4jPBGc fnaV9dGFbwM5PHac4f+dsTHjzhdh5Osyv1qU+uHGVZTHuAtIhf62pzyqyuIzc5EZNAjg yLFKrzGWu3gTBfTq/CQpP+sJRVgukDv6YCw8FAWlsZGXAfOc7ZuQZAS7rrLaazG5V1Ks YsIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8/oqCUNmFc1OqEXIlUblc8Jp0aa/CFYxFmL2eg8Khmw=; b=ox7MLb2Vf/wPWIMyucjmUXGgrC0ttyV3kvfU/UM1YFXzqmPzdmZIiTPxEhTcvwfygl 5ZjEM/jDV9/P1+ZtgckcIcpDTCjx64OScPwVVoDCkGGTXKPcfs4RbT4Mlr2tP/frF7E7 BRFJGwEwJkrYggUjRiCL9mUP+pLDhEf8AlW+eZgisPYCoZJcdMBcpleqQeTnLTZcno0J 8x8E4qanvpf5eKfS3VUGDC4cwltNh4SSl6J2X9ju6Imf6NtcA5tsnjZcUUOROz5YqpUo nmWx4J2RdmAVzBviAFPo1qeEVdybebKyWRmc5vmV2jmDrz1vfQrBvW275KEi70Vh1jd+ ckCA== X-Gm-Message-State: AOAM530nUOuyVfej0lfcer/hrBtafLDRb2ZaGH8QsvvvVk12BmhLj1zd PP0u6mI0He1OhndfL8nA05sD95FUwBTAXoOQz2I7GA== X-Google-Smtp-Source: ABdhPJy0jQhddfBD9VXXPKyqiTXDORIrWINJapjugf6TEhdbEYQZQa7Fm4tW9glCGrENg3DnQz945cD77jRoWWq1Rdw= X-Received: by 2002:a17:906:2296:: with SMTP id p22mr28296124eja.510.1595405399348; Wed, 22 Jul 2020 01:09:59 -0700 (PDT) MIME-Version: 1.0 References: <20200717132859.237120-1-jacopo+renesas@jmondi.org> <20200717132859.237120-3-jacopo+renesas@jmondi.org> <20200717193509.GD5961@pendragon.ideasonboard.com> In-Reply-To: <20200717193509.GD5961@pendragon.ideasonboard.com> From: Loic Poulain Date: Wed, 22 Jul 2020 10:14:52 +0200 Message-ID: Subject: Re: [PATCH 02/13] arm64: dts: qcom: apq8016-sbc: Fix CSI-2 lanes routing To: Laurent Pinchart Cc: Jacopo Mondi , Rob Herring , devicetree , Steve Longerbeam , linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Andy Gross , Bjorn Andersson Content-Type: text/plain; charset="UTF-8" Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, 17 Jul 2020 at 21:35, Laurent Pinchart wrote: > > Hi Jacopo, > > On Fri, Jul 17, 2020 at 03:28:48PM +0200, Jacopo Mondi wrote: > > The ov5640 sensor does not support lanes reconfiguration according > > to version of the datasheet I have (version 2.03) and the driver > > does not parse the properties to try to reconfigure them. > > > > Fix the properties values in the camera and cci node. > > > > Signed-off-by: Jacopo Mondi > > --- > > Loic, I see you added the camera nodes in > > 39e0ce6cd1bf ("arm64: dts: qcom: apq8016-sbc: Add CCI/Sensor nodes") > > > > Do you have any idea how lanes could be swapped if, from my understanding, > > nor the sensor nor the driver supports that ? > > It's not supported on the OV5640 side, so I think the second hunk of > this patch is correct, but I believe that the CAMSS supports lane > reordering, so the first hunk is likely incorrect and should be dropped. Indeed, camss supports lane configuration (cf camss_of_parse_endpoint_node). The sensor doesn't, so that can be removed on its side. Regards, Loic > > > --- > > arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi > > index 8a4b790aa7ff..fe6613676e45 100644 > > --- a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi > > +++ b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi > > @@ -591,8 +591,8 @@ ports { > > port@0 { > > reg = <0>; > > csiphy0_ep: endpoint { > > - clock-lanes = <1>; > > - data-lanes = <0 2>; > > + clock-lanes = <0>; > > + data-lanes = <1 2>; > > remote-endpoint = <&ov5640_ep>; > > status = "okay"; > > }; > > @@ -627,8 +627,8 @@ camera_rear@3b { > > > > port { > > ov5640_ep: endpoint { > > - clock-lanes = <1>; > > - data-lanes = <0 2>; > > + clock-lanes = <0>; > > + data-lanes = <1 2>; > > remote-endpoint = <&csiphy0_ep>; > > }; > > }; > > -- > Regards, > > Laurent Pinchart