From: Sergio Paracuellos <sergio.paracuellos@gmail.com>
To: "Arınç ÜNAL" <arinc.unal@arinc9.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Rob Herring <robh@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-mediatek@lists.infradead.org, linux-mips@vger.kernel.org,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Matthias Brugger <matthias.bgg@gmail.com>,
Sean Wang <sean.wang@kernel.org>,
William Dean <williamsukatube@gmail.com>,
Daniel Golle <daniel@makrotopia.org>,
Daniel Santos <daniel.santos@pobox.com>,
Luiz Angelo Daros de Luca <luizluca@gmail.com>,
Frank Wunderlich <frank-w@public-files.de>,
Landen Chao <Landen.Chao@mediatek.com>,
DENG Qingfang <dqfext@gmail.com>,
Sean Wang <sean.wang@mediatek.com>,
erkin.bozoglu@xeront.com
Subject: Re: [PATCH 09/20] dt-bindings: pinctrl: ralink: {mt7620,mt7621}: rename to mediatek
Date: Fri, 10 Mar 2023 08:05:31 +0100 [thread overview]
Message-ID: <CAMhs-H_YkdacZXE2xqn=_JQtitLvqRFB20s7rjS63dFabAL4qw@mail.gmail.com> (raw)
In-Reply-To: <81cf9e50-d626-cbb3-ebb1-56d080eca66d@arinc9.com>
On Thu, Mar 9, 2023 at 10:09 PM Arınç ÜNAL <arinc.unal@arinc9.com> wrote:
>
> On 9.03.2023 14:33, Sergio Paracuellos wrote:
> > On Thu, Mar 9, 2023 at 11:34 AM Arınç ÜNAL <arinc.unal@arinc9.com> wrote:
> >>
> >> On 9.03.2023 12:52, Krzysztof Kozlowski wrote:
> >>> On 09/03/2023 08:53, Arınç ÜNAL wrote:
> >>>> On 9.03.2023 00:19, Arınç ÜNAL wrote:
> >>>>> On 9.03.2023 00:05, Rob Herring wrote:
> >>>>>> On Fri, Mar 03, 2023 at 03:28:38AM +0300, arinc9.unal@gmail.com wrote:
> >>>>>>> From: Arınç ÜNAL <arinc.unal@arinc9.com>
> >>>>>>>
> >>>>>>> This platform from Ralink was acquired by MediaTek in 2011. Then,
> >>>>>>> MediaTek
> >>>>>>> introduced these SoCs which utilise this platform. Rename the schemas to
> >>>>>>> mediatek to address the incorrect naming.
> >>>>>>
> >>>>>> I said we don't do renames due to acquistions, you said that wasn't the
> >>>>>> reason, but then that's your reasoning here.
> >>>>>
> >>>>> It's not a marketing/acquistion rename as the name of these SoCs were
> >>>>> wrong from the get go. The information on the first sentence is to give
> >>>>> the idea of why these SoCs were wrongfully named as the base platform
> >>>>> that these new MediaTek SoCs share code with was called Ralink.
> >>>>>
> >>>>>>
> >>>>>> To give you another example, *new* i.MX things are still called
> >>>>>> 'fsl,imx...' and it has been how many years since merging with NXP?
> >>>>>
> >>>>> Ok this is a point I see now. Though, I fail to see how this is called
> >>>>> renaming when there's only new SoCs (from NXP in this case) to be added.
> >>>>
> >>>> If I understand correctly, i.MX is a family from Freescale so the name
> >>>
> >>> It's the same "family" as your platform, because as you said:
> >>> "introduced these SoCs which utilise this platform"
> >>>
> >>>> was kept the same on new SoC releases from NXP. I believe it's different
> >>>> in this case here. There's no family name. The closest thing on the name
> >>>> of the SoC model is, it's RT for Ralink, MT for MediaTek.
> >>>
> >>> It's not about the name. NXP took Freescale platform and since many
> >>> years makes entirely new products, currently far, far away from original
> >>> platform.
> >>>
> >>> That's the same case you have here - Mediatek took existing platform and
> >>> started making new products with it.
> >>>
> >>>>
> >>>> On top of that, mediatek strings already exist for MT SoCs already, at
> >>>> least for MT7621.
> >>>>
> >>>> https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/tree/Documentation/devicetree/bindings/mips/ralink.yaml?id=dd3cb467ebb5659d6552999d6f16a616653f9933#n83
> >>>
> >>> NXP also has compatibles with nxp, thus still not that good reason.
> >>
> >> Ok, makes sense. Am I free to call the SoCs MediaTek, change the schema
> >> name from ralink,mtXXXX-pinctrl.yaml to mediatek,mtXXXX-pinctrl.yaml
> >> whilst keeping the compatible string ralink?
> >>
> >> I plan to do some cleanup on ralink.yaml as well. From what I
> >> understand, I should change the mediatek,mt7621-soc compatible string to
> >> ralink,mt7621-soc?
> >
> > You have to take care of these SoC strings since they are used in the
> > very beginning of the ralink startup platforms for any single ralink
> > SoC. See for example [0] and [1] (but they are in all soc init code).
> > I think it is better to maintain the ralink.yaml file as it is.
>
> I'd really rather address this inconsistency everywhere possible. The
> code you pointed out looks different than what I did on the pinctrl
> driver but, surely it's possible on the code to introduce ralink and
> keep the mediatek string for the sake of old DTs, no?
In any case, the changes you might have in mind for this should be a
different patch series.
Best regards,
Sergio Paracuellos
>
> Arınç
next prev parent reply other threads:[~2023-03-10 7:05 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-03 0:28 [PATCH 00/20] pinctrl: ralink: fix ABI, improve driver, move to mediatek, improve dt-bindings arinc9.unal
2023-03-03 0:28 ` [PATCH 01/20] pinctrl: ralink: reintroduce ralink,rt2880-pinmux compatible string arinc9.unal
2023-03-03 6:01 ` Sergio Paracuellos
2023-03-03 0:28 ` [PATCH 02/20] pinctrl: ralink: {mt7620,mt7621}: add new mediatek compatible strings arinc9.unal
2023-03-03 6:02 ` Sergio Paracuellos
2023-03-03 0:28 ` [PATCH 03/20] pinctrl: ralink: rt305x: add new compatible string for every SoC arinc9.unal
2023-03-03 6:02 ` Sergio Paracuellos
2023-03-03 0:28 ` [PATCH 04/20] pinctrl: ralink: mt7620: split out to mt76x8 arinc9.unal
2023-03-03 6:03 ` Sergio Paracuellos
2023-03-03 6:04 ` Sergio Paracuellos
2023-03-03 7:53 ` Arınç ÜNAL
2023-03-03 8:06 ` Sergio Paracuellos
2023-03-03 0:28 ` [PATCH 05/20] pinctrl: ralink: move to mediatek as mtmips arinc9.unal
2023-03-03 6:17 ` Sergio Paracuellos
2023-03-03 6:34 ` Sergio Paracuellos
2023-03-03 8:15 ` Arınç ÜNAL
2023-03-03 10:57 ` Sergio Paracuellos
2023-03-03 14:17 ` Arınç ÜNAL
2023-03-06 14:07 ` Sergio Paracuellos
2023-03-06 15:05 ` Arınç ÜNAL
2023-03-06 16:15 ` Sergio Paracuellos
2023-03-06 16:43 ` Arınç ÜNAL
2023-03-03 0:28 ` [PATCH 06/20] pinctrl: mediatek: remove OF_GPIO as reverse dependency arinc9.unal
2023-03-03 6:18 ` Sergio Paracuellos
2023-03-03 0:28 ` [PATCH 07/20] dt-bindings: pinctrl: ralink: improve bindings arinc9.unal
2023-03-08 20:42 ` Rob Herring
2023-03-03 0:28 ` [PATCH 08/20] dt-bindings: pinctrl: ralink: add new compatible strings arinc9.unal
2023-03-08 21:00 ` Rob Herring
2023-03-08 21:19 ` Arınç ÜNAL
2023-03-09 9:48 ` Krzysztof Kozlowski
2023-03-03 0:28 ` [PATCH 09/20] dt-bindings: pinctrl: ralink: {mt7620,mt7621}: rename to mediatek arinc9.unal
2023-03-08 21:05 ` Rob Herring
2023-03-08 21:19 ` Arınç ÜNAL
2023-03-09 7:53 ` Arınç ÜNAL
2023-03-09 9:52 ` Krzysztof Kozlowski
2023-03-09 10:34 ` Arınç ÜNAL
2023-03-09 11:33 ` Sergio Paracuellos
2023-03-09 21:08 ` Arınç ÜNAL
2023-03-10 7:05 ` Sergio Paracuellos [this message]
2023-03-10 7:45 ` Arınç ÜNAL
2023-03-03 0:28 ` [PATCH 10/20] dt-bindings: pinctrl: mediatek: mt6795: rename to mediatek,mt6795-pinctrl arinc9.unal
2023-03-03 0:28 ` [PATCH 11/20] dt-bindings: pinctrl: mediatek: mt8186: rename to mediatek,mt8186-pinctrl arinc9.unal
2023-03-03 0:28 ` [PATCH 12/20] dt-bindings: pinctrl: mediatek: mt8192: rename to mediatek,mt8192-pinctrl arinc9.unal
2023-03-03 0:28 ` [PATCH 13/20] dt-bindings: pinctrl: mediatek: mt8195: rename to mediatek,mt8195-pinctrl arinc9.unal
2023-03-03 0:28 ` [PATCH 14/20] dt-bindings: pinctrl: mediatek: fix naming inconsistency arinc9.unal
2023-03-08 21:05 ` Rob Herring
2023-03-03 0:28 ` [PATCH 15/20] dt-bindings: pinctrl: {mediatek,ralink}: fix formatting arinc9.unal
2023-03-08 21:11 ` Rob Herring
2023-03-08 21:30 ` Arınç ÜNAL
2023-03-03 0:28 ` [PATCH 16/20] dt-bindings: pinctrl: mediatek: drop quotes from referred schemas arinc9.unal
2023-03-03 0:28 ` [PATCH 17/20] dt-bindings: pinctrl: mediatek: mt7986: fix patternProperties regex arinc9.unal
2023-03-08 21:15 ` Rob Herring
2023-03-08 21:22 ` Arınç ÜNAL
2023-03-03 0:28 ` [PATCH 18/20] dt-bindings: pinctrl: ralink: rt305x: split binding arinc9.unal
2023-03-08 21:17 ` Rob Herring
2023-03-03 0:28 ` [PATCH 19/20] dt-bindings: pinctrl: mediatek: mt7620: " arinc9.unal
2023-03-08 21:22 ` Rob Herring
2023-03-09 9:54 ` Krzysztof Kozlowski
2023-03-09 21:03 ` Arınç ÜNAL
2023-03-03 0:28 ` [PATCH 20/20] MAINTAINERS: move ralink pinctrl to mediatek mips pinctrl arinc9.unal
2023-03-03 6:21 ` Sergio Paracuellos
2023-03-06 13:50 ` [PATCH 00/20] pinctrl: ralink: fix ABI, improve driver, move to mediatek, improve dt-bindings Linus Walleij
2023-03-06 14:17 ` Sergio Paracuellos
2023-03-06 14:55 ` Arınç ÜNAL
2023-03-06 22:09 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMhs-H_YkdacZXE2xqn=_JQtitLvqRFB20s7rjS63dFabAL4qw@mail.gmail.com' \
--to=sergio.paracuellos@gmail.com \
--cc=Landen.Chao@mediatek.com \
--cc=arinc.unal@arinc9.com \
--cc=daniel.santos@pobox.com \
--cc=daniel@makrotopia.org \
--cc=devicetree@vger.kernel.org \
--cc=dqfext@gmail.com \
--cc=erkin.bozoglu@xeront.com \
--cc=frank-w@public-files.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mips@vger.kernel.org \
--cc=luizluca@gmail.com \
--cc=matthias.bgg@gmail.com \
--cc=robh@kernel.org \
--cc=sean.wang@kernel.org \
--cc=sean.wang@mediatek.com \
--cc=williamsukatube@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).