From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8C5AC433DF for ; Fri, 9 Oct 2020 07:37:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A3D8522274 for ; Fri, 9 Oct 2020 07:37:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602229073; bh=uwHGsExUwomnGZGAB9Ig2cy91/4zjXFRWuSoOtt/2uc=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=LsZ3j8y7eq88UTh6rgHTKJa59ELVFtp5cQGBofnLvshTodJKQxaJ3EQHJ0CqUD/97 EnG/lMXBYdAbtwX7nLfkm6if6d8qRp4OBBS8YIan9frFLfWvnDwBFXRAGvhtQT8cAa JWR4jfqMmOgPv1qg6SgE/m4jH00iKvlrU19CaKSM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732075AbgJIHhx (ORCPT ); Fri, 9 Oct 2020 03:37:53 -0400 Received: from mail.kernel.org ([198.145.29.99]:49650 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730797AbgJIHhw (ORCPT ); Fri, 9 Oct 2020 03:37:52 -0400 Received: from mail-ot1-f43.google.com (mail-ot1-f43.google.com [209.85.210.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C480C2227F; Fri, 9 Oct 2020 07:37:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602229071; bh=uwHGsExUwomnGZGAB9Ig2cy91/4zjXFRWuSoOtt/2uc=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=hr/EfPQdRr7YOMI/Ml+6/nicYKOq2pzsRkwJDK4QOWHasA7h3oiXAIpK8Icq9k0cv B+Pr4QjjAsu4RyNsMNzqa5+CA1tTcrgTjx2kn0DhJTQgTTn8izNoFlcMq6d6kgu0vn 6IJ/b+FrCQ4BlPeeC2xEElSxY1bwAgxst0UX0QZs= Received: by mail-ot1-f43.google.com with SMTP id t15so8221341otk.0; Fri, 09 Oct 2020 00:37:51 -0700 (PDT) X-Gm-Message-State: AOAM530+uVUm1XCA+uDCpdVKBCrQXmLUvJIzyI1k4EW6mbiT1WfLZlx4 m/RGNLdnCGnALb3h5jUVO08WY+cXqZG17+mpcVQ= X-Google-Smtp-Source: ABdhPJwm7Itaee4mU5h+ix4hYGBefWmG86wT+rm9HR2eTuMvzP6PBTs811cyWxyuLFCA+ubq6YIJxYBgULsTYR7jHG8= X-Received: by 2002:a9d:6a85:: with SMTP id l5mr8311994otq.77.1602229071004; Fri, 09 Oct 2020 00:37:51 -0700 (PDT) MIME-Version: 1.0 References: <20201001161740.29064-1-nsaenzjulienne@suse.de> <20201001161740.29064-2-nsaenzjulienne@suse.de> <20201001171500.GN21544@gaia> <20201001172320.GQ21544@gaia> <20201002115541.GC7034@gaia> <12f33d487eabd626db4c07ded5a1447795eed355.camel@suse.de> <20201009071013.GA12208@lst.de> In-Reply-To: <20201009071013.GA12208@lst.de> From: Ard Biesheuvel Date: Fri, 9 Oct 2020 09:37:39 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/4] of/fdt: Update zone_dma_bits when running in bcm2711 To: Christoph Hellwig Cc: Nicolas Saenz Julienne , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Frank Rowand , Catalin Marinas , Linux Kernel Mailing List , Linux Memory Management List , iommu@lists.linux-foundation.org, Rob Herring , linux-rpi-kernel@lists.infradead.org, Will Deacon , Linux ARM , Robin Murphy Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, 9 Oct 2020 at 09:11, Christoph Hellwig wrote: > > On Thu, Oct 08, 2020 at 12:05:25PM +0200, Nicolas Saenz Julienne wrote: > > Sadly I just realised that the series is incomplete, we have RPi4 users that > > want to boot unsing ACPI, and this series would break things for them. I'll > > have a word with them to see what we can do for their use-case. > > Stupid question: why do these users insist on a totally unsuitable > interface? And why would we as Linux developers care to support such > a aims? > The point is really whether we want to revert changes in Linux that made both DT and ACPI boot work without quirks on RPi4. Having to check the RPi4 compatible string or OEM id in core init code is awful, regardless of whether you boot via ACPI or via DT. The problem with this hardware is that it uses a DMA mask which is narrower than 32, and the arm64 kernel is simply not set up to deal with that at all. On DT, we have DMA ranges properties and the likes to describe such limitations, on ACPI we have _DMA methods as well as DMA range attributes in the IORT, both of which are now handled correctly. So all the information is there, we just have to figure out how to consume it early on. Interestingly, this limitation always existed in the SoC, but it wasn't until they started shipping it with more than 1 GB of DRAM that it became a problem. This means issues like this could resurface in the future with existing SoCs when they get shipped with more memory, and so I would prefer fixing this in a generic way. Also, I assume papering over the issue like this does not fix the kdump issue fundamentally, it just works around it, and so we might run into this again in the future.