From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 706D8C433DB for ; Fri, 26 Mar 2021 14:45:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3603F619C9 for ; Fri, 26 Mar 2021 14:45:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230165AbhCZOo4 (ORCPT ); Fri, 26 Mar 2021 10:44:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54794 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229839AbhCZOou (ORCPT ); Fri, 26 Mar 2021 10:44:50 -0400 Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DC74AC0613AA for ; Fri, 26 Mar 2021 07:44:49 -0700 (PDT) Received: by mail-ed1-x52f.google.com with SMTP id bx7so6566324edb.12 for ; Fri, 26 Mar 2021 07:44:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=rIvv+tA1LMtQGGiDuq1c1q8EFA36Pgjy5WH53f7HNx4=; b=iYunu1vYc+nYwytgwT0664RyXaLgIIwSfKZuAagqasIYu9jy9foMpyWg8GYSfAPoSl 7gXmommvATo5YilSMCWKppg6LleO/43CCNHA5B/ru6Jk9NMhwzLrSDFzr+PaGarm07W7 mBEkYdqmxjgNwwSk3y9oMCN94y3a4cOYuEb01nuzMH/0mqtLNYzzrVRIT/+ZbQBty8W9 DoeDDyGU2UhxKa2OOCRbp8rXwfrOEd5I+reszDYXU/CDUOhm55Da+3J7D9UXrfsMjDCR LtmDAYZ2TfiSrOTrb9+jife+nA0bQs7GxtgJWytM/0bTimRuWkn57mcH3yp8a70YHvQP WdBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rIvv+tA1LMtQGGiDuq1c1q8EFA36Pgjy5WH53f7HNx4=; b=owsfTirS/D75xqIlLXMbK7CF/Bk5AsTmM1j//PazHlpmhzAt2eMER89IftbO1LRPlF r/7XugtiuCdMzq9urMn/P+VwmA00r99yy9orPiHTfslhQX/wFKFEbImDmOvAYrpnCFCO fcr1neqVY2HWPfeefDfodZdwO66O4xq6bGN/T74zCkklNgiDegm0bFg6x6Yxhiqog0mw KE5HbGxjry7Uf4y9yTgnzfgeAwdWfrQioJwljRBZkZ+d+Z0Lc1DAsJ9wl4+sC57YtcqX eI3tK9+gWnNmtJY9v0moak3xgacmf6EvpcmUzoJh5DKY+T8i1lsbK+kHZJtHpSg+221O /lzA== X-Gm-Message-State: AOAM532nbXqLIn1MI3FLwOONQJPPeijBQt97k18maJFIgE/ihCPOoz6f fw936g8kYx2wNODymZnMEKuutZEmWIMTXR1ASe/5Sw== X-Google-Smtp-Source: ABdhPJyu4ZYMKthWiIfIsLH5cJYN/YmYPXtv3Hl6Hl6YxrLqty3+4cM/fQnPI6E5xbB/otdrwsE35jlQjEFjqhXSpzo= X-Received: by 2002:a05:6402:17d6:: with SMTP id s22mr15385463edy.232.1616769888652; Fri, 26 Mar 2021 07:44:48 -0700 (PDT) MIME-Version: 1.0 References: <50f72f1f7f28e969a1e0353712fcc530bce9dd06.1611037866.git.matti.vaittinen@fi.rohmeurope.com> In-Reply-To: From: Bartosz Golaszewski Date: Fri, 26 Mar 2021 15:44:38 +0100 Message-ID: Subject: Re: [PATCH v2 10/17] gpio: support ROHM BD71815 GPOs To: "Vaittinen, Matti" Cc: "linux-gpio@vger.kernel.org" , "linux-rtc@vger.kernel.org" , "linux-clk@vger.kernel.org" , "a.zummo@towertech.it" , "broonie@kernel.org" , "lee.jones@linaro.org" , "linus.walleij@linaro.org" , "linux-kernel@vger.kernel.org" , "sboyd@kernel.org" , linux-power , "alexandre.belloni@bootlin.com" , "lgirdwood@gmail.com" , "mturquette@baylibre.com" , "robh+dt@kernel.org" , "devicetree@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, Mar 23, 2021 at 10:57 AM Vaittinen, Matti wrote: > > > On Tue, 2021-01-19 at 12:07 +0100, Bartosz Golaszewski wrote: > > On Tue, Jan 19, 2021 at 8:23 AM Matti Vaittinen > > wrote: > > > Support GPO(s) found from ROHM BD71815 power management IC. The IC > > > has two > > > GPO pins but only one is properly documented in data-sheet. The > > > driver > > > exposes by default only the documented GPO. The second GPO is > > > connected to > > > E5 pin and is marked as GND in data-sheet. Control for this > > > undocumented > > > pin can be enabled using a special DT property. > > > > > > This driver is derived from work by Peter Yang < > > > yanglsh@embest-tech.com> > > > although not so much of original is left. > > > > > > Signed-off-by: Matti Vaittinen > > > > Hi Matti, > > > > looks great, just a couple nits. > > Hello Bartosz, > > I think fixed all the nits to v3. Can I translate this to an ack? (I > will respin the series as I guess the regulator part may have fallen > through the cracks so I'd like to add the relevant acks :] ) > > Best Regards > Matti Vaittinen Yes: Acked-by: Bartosz Golaszewski