From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0CE7C48BDF for ; Thu, 24 Jun 2021 12:32:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C6CB6613F3 for ; Thu, 24 Jun 2021 12:32:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231294AbhFXMfI (ORCPT ); Thu, 24 Jun 2021 08:35:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45826 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230110AbhFXMfI (ORCPT ); Thu, 24 Jun 2021 08:35:08 -0400 Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 28922C061574 for ; Thu, 24 Jun 2021 05:32:49 -0700 (PDT) Received: by mail-ej1-x62d.google.com with SMTP id bu12so9359690ejb.0 for ; Thu, 24 Jun 2021 05:32:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1pdNyGnwu73Y/M+lRxwYbfC63xdRtvOG341evPVloL4=; b=VT4Xbs/6+8YEG5ok69Cp66JqzZQH90fw7I76MXbLk3uomJANwnomPoo574oC5hjoQ4 EKQdDKf9yDx4L7r2cF62JOT40zbd68qIkBdugdNROO5ALrOarxqS15JpQUzu+iBlP/bO FZoTBAM7u3HhTjWJ9SuTe5GD1eTpfsr8wdQVE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1pdNyGnwu73Y/M+lRxwYbfC63xdRtvOG341evPVloL4=; b=aYJDYTUo3Dqa9O5SJqdir81ZOrpt11EBfT6UIagZT67OJUq1GsQSJeqAfQT1LRcMu+ DDRLkZLLAXhCG5f4nFq02ir2GKDk7z3Gdm9/IR5LegAuqOIm7WXq7+wSOrc9M/0bIs7U KzBKE4qX5JDU6ueS4pFULysKWMQZQTWjPK11IbFMZNOpa15UtV84ZI6Ru/zayO6p9nrb qU5pUjBhClClu2TKahIkVyvQRVS7Mzki63PqBTQ50BD7WQU6j3D7kHe5uvJS0OQYNfFY d7CTr5EgZEdISnN0idNq7+894Q3+2nSEPMXqXiZ4JFTeHtHHKLYAP2EgKNMgro8vw5fA neqw== X-Gm-Message-State: AOAM532U5Z9+9srNqsF+ziElHIEeYn4rF3L0ON+ZKXC1kjGuQ0UWw3I0 2p73MnGOzc/w3yT0m1R/4uIH6xcr4fr+F5ZvRu2Mlw== X-Google-Smtp-Source: ABdhPJy9346wJ7pgPh41de3TKx9jGsDYkXgGD+VTQowScqmus3DWBHWMTQtjBZGWKBfvb/2N8Rflzvh3mC8Utrm9SqA= X-Received: by 2002:a17:906:718b:: with SMTP id h11mr5091976ejk.418.1624537967775; Thu, 24 Jun 2021 05:32:47 -0700 (PDT) MIME-Version: 1.0 References: <20210621072424.111733-1-jagan@amarulasolutions.com> <20210621072424.111733-3-jagan@amarulasolutions.com> In-Reply-To: From: Jagan Teki Date: Thu, 24 Jun 2021 18:02:36 +0530 Message-ID: Subject: Re: [RFC PATCH 2/9] drm: bridge: Add Samsung SEC MIPI DSIM bridge driver To: Laurent Pinchart Cc: Fabio Estevam , Michael Tretter , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Peng Fan , Francis Laniel , Matteo Lisi , Neil Armstrong , linux-amarula , linux-kernel , Robert Foss , Andrzej Hajda , DRI mailing list , Milco Pratesi , Anthony Brandon , linux-phy@lists.infradead.org, Fancy Fang , Shawn Guo , Sascha Hauer , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , NXP Linux Team Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Laurent, On Thu, Jun 24, 2021 at 5:48 PM Laurent Pinchart wrote: > > Hi Jagan, > > On Thu, Jun 24, 2021 at 05:42:43PM +0530, Jagan Teki wrote: > > On Thu, Jun 24, 2021 at 8:18 AM Fabio Estevam wrote: > > > On Wed, Jun 23, 2021 at 7:23 PM Laurent Pinchart wrote: > > > > > > > Looking at the register set, it seems to match the Exynos 5433, > > > > supported by drivers/gpu/drm/exynos/exynos_drm_dsi.c. Can we leverage > > > > that driver instead of adding a new one for the same IP core ? > > > > > > Yes. there was an attempt from Michael in this direction: > > > https://patchwork.kernel.org/project/dri-devel/cover/20200911135413.3654800-1-m.tretter@pengutronix.de/ > > > > Thanks for the reference, I will check it out and see I can send any > > updated versions wrt my i.MX8MM platform. > > Thanks. > > I had a brief look at the exynos driver, and I think it should be turned > into a DRM bridge as part of this rework to be used with the i.MX8MM. > > Is there someone from Samsung who could assist, at least to test the > changes ? I have hardware to verify it on i.MX8MM but from exynos I don't have any contact from Samsung to suggest or test. Maybe I can add Tomasz Figa while sending the changes? I understand that there are 2 key implementations. 1. Adjust the exynos_drm_dsi.c by dropping component_ops as i.MX8MM flow with LCDIF doesn't have component_ops (make sure it works with exynos platform first) 2. Sec DSIM Bridge driver common cross Exynos and i.MX8MM platform drivers or only one Sec DSIM bridge driver to handle both the platforms by differentiating compatible and driver data Any more suggestions would be appreciated? Jagan.