From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Chris Brandt <chris.brandt@renesas.com>
Cc: Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
linux-spi <linux-spi@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
linux-clk <linux-clk@vger.kernel.org>,
Mason Yang <masonccyang@mxic.com.tw>,
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Subject: Re: [PATCH 1/6] clk: renesas: mstp: Add critical clock from device tree support
Date: Tue, 3 Dec 2019 19:32:37 +0100 [thread overview]
Message-ID: <CAMuHMdU6NrAk-oeH_tR8Re7bz6HXednfaP=CGsyBt+M4_n95ow@mail.gmail.com> (raw)
In-Reply-To: <20191203034519.5640-2-chris.brandt@renesas.com>
Hi Chris,
On Tue, Dec 3, 2019 at 4:46 AM Chris Brandt <chris.brandt@renesas.com> wrote:
> Allow critical clocks to be specified in the Device Tree.
>
> Signed-off-by: Chris Brandt <chris.brandt@renesas.com>
Thanks for your patch!
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Notes:
1. Assumed we really need this,
2. Minor nit below.
> --- a/drivers/clk/renesas/clk-mstp.c
> +++ b/drivers/clk/renesas/clk-mstp.c
> @@ -187,6 +187,7 @@ static void __init cpg_mstp_clocks_init(struct device_node *np)
> const char *idxname;
> struct clk **clks;
> unsigned int i;
> + unsigned long flags;
= 0 here...
>
> group = kzalloc(struct_size(group, clks, MSTP_MAX_CLOCKS), GFP_KERNEL);
> if (!group)
> @@ -239,8 +240,11 @@ static void __init cpg_mstp_clocks_init(struct device_node *np)
> continue;
> }
>
> + flags = 0;
... instead of here?
> + of_clk_detect_critical(np, i, &flags);
> +
> clks[clkidx] = cpg_mstp_clock_register(name, parent_name,
> - clkidx, group);
> + clkidx, group, flags);
> if (!IS_ERR(clks[clkidx])) {
> group->data.clk_num = max(group->data.clk_num,
> clkidx + 1);
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2019-12-03 18:32 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-03 3:45 [PATCH 0/6] spi: Add Renesas SPIBSC controller Chris Brandt
2019-12-03 3:45 ` [PATCH 1/6] clk: renesas: mstp: Add critical clock from device tree support Chris Brandt
2019-12-03 18:32 ` Geert Uytterhoeven [this message]
2019-12-03 18:46 ` Chris Brandt
2019-12-03 18:51 ` Geert Uytterhoeven
2019-12-03 3:45 ` [PATCH 2/6] ARM: dts: r7s72100: Add SPIBSC clocks Chris Brandt
2019-12-03 18:42 ` Geert Uytterhoeven
2019-12-03 18:57 ` Chris Brandt
2019-12-03 19:12 ` Geert Uytterhoeven
2019-12-04 8:38 ` Lee Jones
2019-12-04 9:03 ` Geert Uytterhoeven
2019-12-04 9:47 ` Lee Jones
2019-12-04 11:00 ` Chris Brandt
2019-12-03 3:45 ` [PATCH 3/6] clk: renesas: r7s9210: Add SPIBSC clock Chris Brandt
2019-12-03 18:49 ` Geert Uytterhoeven
2019-12-03 19:09 ` Chris Brandt
2019-12-03 20:40 ` Geert Uytterhoeven
2019-12-04 3:09 ` Chris Brandt
2019-12-03 3:45 ` [PATCH 4/6] spi: Add SPIBSC driver Chris Brandt
2019-12-03 14:19 ` Mark Brown
2019-12-03 15:00 ` Chris Brandt
2019-12-03 18:29 ` Geert Uytterhoeven
2019-12-04 11:25 ` Mark Brown
2019-12-04 12:14 ` Geert Uytterhoeven
2019-12-04 15:51 ` Chris Brandt
2019-12-04 16:49 ` Mark Brown
2019-12-03 18:28 ` Geert Uytterhoeven
2019-12-04 11:18 ` Mark Brown
2019-12-04 22:12 ` Chris Brandt
2019-12-03 3:45 ` [PATCH 5/6] ARM: dts: r7s9210: Add SPIBSC Device support Chris Brandt
2019-12-03 18:59 ` Geert Uytterhoeven
2019-12-03 22:38 ` Chris Brandt
2019-12-04 7:57 ` Geert Uytterhoeven
2019-12-04 11:04 ` Chris Brandt
2019-12-03 3:45 ` [PATCH 6/6] dt-bindings: spi: Document Renesas SPIBSC bindings Chris Brandt
2019-12-03 9:14 ` Sergei Shtylyov
2019-12-03 13:27 ` Chris Brandt
2019-12-03 16:04 ` Sergei Shtylyov
2019-12-03 16:35 ` Chris Brandt
2019-12-03 18:57 ` Geert Uytterhoeven
2019-12-03 20:39 ` Geert Uytterhoeven
2019-12-04 2:54 ` Chris Brandt
2019-12-04 8:56 ` Geert Uytterhoeven
2019-12-04 13:31 ` Chris Brandt
2019-12-05 15:48 ` Geert Uytterhoeven
2019-12-05 16:00 ` Chris Brandt
2019-12-04 8:40 ` Geert Uytterhoeven
2019-12-03 22:33 ` Chris Brandt
2019-12-04 8:43 ` Geert Uytterhoeven
2019-12-04 11:19 ` Chris Brandt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMuHMdU6NrAk-oeH_tR8Re7bz6HXednfaP=CGsyBt+M4_n95ow@mail.gmail.com' \
--to=geert@linux-m68k.org \
--cc=broonie@kernel.org \
--cc=chris.brandt@renesas.com \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=linux-clk@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=masonccyang@mxic.com.tw \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).