Re: [PATCH v2 2/2] arm64: dts: renesas: rzv2m evk: Enable ethernet

[Geert Uytterhoeven <geert@linux-m68k.org>]

Hi Phil,

On Tue, May 17, 2022 at 10:17 AM Phil Edworthy
<phil.edworthy@renesas.com> wrote:
> Enable Ethernet interface on RZ/V2M EVK.
>
> Signed-off-by: Phil Edworthy <phil.edworthy@renesas.com>
> Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com>
> ---
> v2:
>  - No change

Thanks for your patch!

> --- a/arch/arm64/boot/dts/renesas/r9a09g011-v2mevk2.dts
> +++ b/arch/arm64/boot/dts/renesas/r9a09g011-v2mevk2.dts
> @@ -42,3 +43,16 @@ &extal_clk {
>  &uart0 {
>         status = "okay";
>  };
> +
> +&avb {
> +       renesas,no-ether-link;
> +       phy-handle = <&phy0>;
> +       phy-mode = "gmii";
> +       status = "okay";
> +
> +       phy0: ethernet-phy@0 {
> +               compatible = "ethernet-phy-id0022.1622",

My schematics says RTL8211FG-CG, not Micrel KSZ9031?
I.e. "ethernet-phy-id001c.c916"?

As there is no PHY reset to deassert, you can remove the compatible
property, and check what's read back from the PHY ID registers.

I'd say you can just drop the compatible value completely, but you
would have to readd it anyway when the PHY reset is documented.

> +                            "ethernet-phy-ieee802.3-c22";
> +               reg = <0>;

Once you have GPIO/IRQ support, you can add the interrupts and
resets properties, pointing to P16_12 resp. P17_00.

> +       };
> +};

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds