Re: [PATCH 06/12] dt-binding: can: mcp251xfd: rename autodetect compatible to "microchip,mcp251xfd"

Re: [PATCH 06/12] dt-binding: can: mcp251xfd: rename autodetect compatible to "microchip,mcp251xfd"

[Geert Uytterhoeven]

CC dt

On Wed, Sep 30, 2020 at 11:14 AM Marc Kleine-Budde <mkl@pengutronix.de> wrote:
>
> In [1] Geert noted that the autodetect compatible for the mcp25xxfd driver,
> which is "microchip,mcp25xxfd" might be too generic and overlap with upcoming,
> but incompatible chips.
>
> As the driver is in net-next but not mainline yet, the risk of breaking DT
> compatibility is quite low, so this patch changes the compatible to
> "microchip,mcp251xfd" and renames the binding documentation accordingly.
>
> [1] http://lore.kernel.org/r/CAMuHMdVkwGjr6dJuMyhQNqFoJqbh6Ec5V2b5LenCshwpM2SDsQ@mail.gmail.com
>
> Fixes: 1b5a78e69c1f ("dt-binding: can: mcp25xxfd: document device tree bindings")
> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
> ---
>  ...{microchip,mcp25xxfd.yaml => microchip,mcp251xfd.yaml} | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>  rename Documentation/devicetree/bindings/net/can/{microchip,mcp25xxfd.yaml => microchip,mcp251xfd.yaml} (91%)
>
> diff --git a/Documentation/devicetree/bindings/net/can/microchip,mcp25xxfd.yaml b/Documentation/devicetree/bindings/net/can/microchip,mcp251xfd.yaml
> similarity index 91%
> rename from Documentation/devicetree/bindings/net/can/microchip,mcp25xxfd.yaml
> rename to Documentation/devicetree/bindings/net/can/microchip,mcp251xfd.yaml
> index 5beb00a614bf..2a884c1fe0e0 100644
> --- a/Documentation/devicetree/bindings/net/can/microchip,mcp25xxfd.yaml
> +++ b/Documentation/devicetree/bindings/net/can/microchip,mcp251xfd.yaml
> @@ -1,7 +1,7 @@
>  # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>  %YAML 1.2
>  ---
> -$id: http://devicetree.org/schemas/net/can/microchip,mcp25xxfd.yaml#
> +$id: http://devicetree.org/schemas/net/can/microchip,mcp251xfd.yaml#
>  $schema: http://devicetree.org/meta-schemas/core.yaml#
>
>  title:
> @@ -18,7 +18,7 @@ properties:
>          description: for MCP2517FD
>        - const: microchip,mcp2518fd
>          description: for MCP2518FD
> -      - const: microchip,mcp25xxfd
> +      - const: microchip,mcp251xfd
>          description: to autodetect chip variant
>
>    reg:
> @@ -38,7 +38,7 @@ properties:
>
>    microchip,rx-int-gpios:
>      description:
> -      GPIO phandle of GPIO connected to to INT1 pin of the MCP25XXFD, which
> +      GPIO phandle of GPIO connected to to INT1 pin of the MCP251XFD, which
>        signals a pending RX interrupt.
>      maxItems: 1
>
> @@ -65,7 +65,7 @@ examples:
>          #size-cells = <0>;
>
>          can@0 {
> -            compatible = "microchip,mcp25xxfd";
> +            compatible = "microchip,mcp251xfd";
>              reg = <0>;
>              clocks = <&can0_osc>;
>              pinctrl-names = "default";
> --
> 2.28.0