From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8778C433E0 for ; Fri, 8 Jan 2021 14:25:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8121A22AAF for ; Fri, 8 Jan 2021 14:25:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726503AbhAHOYz (ORCPT ); Fri, 8 Jan 2021 09:24:55 -0500 Received: from mail-ot1-f54.google.com ([209.85.210.54]:44232 "EHLO mail-ot1-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726476AbhAHOYz (ORCPT ); Fri, 8 Jan 2021 09:24:55 -0500 Received: by mail-ot1-f54.google.com with SMTP id r9so9725988otk.11; Fri, 08 Jan 2021 06:24:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KFwxo3qan4g6V4pQIK/kieZfz/hWqfOwQh2ghP5HzG4=; b=RXHNwUlePxFPFEMSloIqi/vSTB3yKqZkNwYj09ZUDPKhiCdErCOmUVxMVY3YXgAKXX oTCWkZ/V1xHndaELfrI+DYgJ4DKCp39nBV6lCeh/3UXtz1os6YGiqy1LxVI2/kj43Eik 4ZB2R0ZhCtz2KqchFa2qSaOcIS0tQrt/Sxo3LmexMEA9wUmUjIKPAP7AmaT0QSeyWdm3 Y+t3GdLOBZ+tH5JNJem/2NKhmg9zSvXz7hGaU9D1s3ymYnmW6dDWwbqjejMybII02s8e AXEKWUh4F7fVwKbGyWVyjTtQEpVtso7qcoM1QCTO/6XMcXMzDwxJZVWHoZgTVO+UrnfL 9J0Q== X-Gm-Message-State: AOAM530Be+MYj2YmSWnztjG8fWERhVd+WFFTp6MsVfWSb4jQ7JUaSd+k hbtCh7qFQX/2eHiw/do/gYmfeBczhRzPIc46IDc= X-Google-Smtp-Source: ABdhPJwADa70JQAXCy4lsWLORoYMqTTRclDjqMkPdMkC6riwZYTLFGBF9gF2TN2RjJx3Auu+cM59swiYqANmjFH1W20= X-Received: by 2002:a05:6830:210a:: with SMTP id i10mr2750225otc.145.1610115854549; Fri, 08 Jan 2021 06:24:14 -0800 (PST) MIME-Version: 1.0 References: <20201228213121.2331449-1-aford173@gmail.com> In-Reply-To: From: Geert Uytterhoeven Date: Fri, 8 Jan 2021 15:24:03 +0100 Message-ID: Subject: Re: [PATCH 1/4] dt-bindings: net: renesas,etheravb: Add additional clocks To: Adam Ford Cc: Linux-Renesas , Adam Ford-BE , Sergei Shtylyov , "David S. Miller" , Jakub Kicinski , Rob Herring , Magnus Damm , netdev , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Adam, On Fri, Jan 8, 2021 at 3:11 PM Geert Uytterhoeven wrote: > On Mon, Dec 28, 2020 at 10:32 PM Adam Ford wrote: > > The AVB driver assumes there is an external clock, but it could > > be driven by an external clock. In order to enable a programmable > > clock, it needs to be added to the clocks list and enabled in the > > driver. Since there currently only one clock, there is no > > clock-names list either. > > > > Update bindings to add the additional optional clock, and explicitly > > name both of them. > > > > Signed-off-by: Adam Ford > > Reviewed-by: Geert Uytterhoeven Upon second look... >> --- a/Documentation/devicetree/bindings/net/renesas,etheravb.yaml >> +++ b/Documentation/devicetree/bindings/net/renesas,etheravb.yaml >> @@ -49,7 +49,16 @@ properties: >> interrupt-names: true >> >> clocks: >> - maxItems: 1 >> + minItems: 1 >> + maxItems: 2 >> + items: >> + - description: AVB functional clock >> + - description: Optional TXC reference clock >> + >> + clock-names: >> + items: >> + - const: fck >> + - const: txc_refclk On R-Car Gen3 and RZ/G2, RGMII is used, and this clock is called "txcrefclk", i.e. without underscore. On R-Car Gen2, GMII is used, and this clock is called "gtxrefclk". Perhaps it should just be called "refclk"? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds