From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA1A7C3F2D2 for ; Mon, 2 Mar 2020 12:28:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C5B342173E for ; Mon, 2 Mar 2020 12:28:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727762AbgCBM20 (ORCPT ); Mon, 2 Mar 2020 07:28:26 -0500 Received: from mail-ot1-f65.google.com ([209.85.210.65]:39418 "EHLO mail-ot1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727361AbgCBM20 (ORCPT ); Mon, 2 Mar 2020 07:28:26 -0500 Received: by mail-ot1-f65.google.com with SMTP id x97so9474162ota.6; Mon, 02 Mar 2020 04:28:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=wZYZAbcqMvd207t9hfFOk6y3G0CkgQqD0dKaK71lZb4=; b=b8tJf91m5c3kzr113GHXr/pAavv5rJ5P40NxWsZnX/o0QmxGZqOzl9I7tbZj+7oJw4 wGdoAOORM3cRDswZw1+u5JGK3B6PgZLHWw3MAXqYVfrt5N+ge47B6wbTAj26yREcB1aA ZY9ol0cmH29JWpvKk95ZAnEg1PRj8s+a8VTDSLhL1hRGiyzyOLaUV/KzhR3dHj6lNNM7 S4Vs6cg7E4evriSyUgVQSIcZG3uuBAl7wg6xN2jICGKF/iPF1+mGABJSfctaAI36XMLe Exhfb4qImwgNaUNV9ukXo3vYma02JhDULxsRjjRMqsb/G4YxEfjO2EsWb+RdzkhxGdcf nrbw== X-Gm-Message-State: APjAAAXrj65GOHJWbTRZgBabLF3EcLHz+i7EBi+f0Dy/E5bIwLePf0Kt JN368l897hYx56lmCZjD7XiFa6DFVOLPXr3X3Ec= X-Google-Smtp-Source: APXvYqzN+m0jue0ZTokoqurX7tBCYT/bfoG/F9HvM0fLl2C7tpJvdjqoMETuKvoCS8cUYtBFAfQ6dPbGSXXYJ4em2mQ= X-Received: by 2002:a05:6830:1d4:: with SMTP id r20mr12476739ota.107.1583152104944; Mon, 02 Mar 2020 04:28:24 -0800 (PST) MIME-Version: 1.0 References: <20200113141556.GI3606@pflmari> In-Reply-To: <20200113141556.GI3606@pflmari> From: Geert Uytterhoeven Date: Mon, 2 Mar 2020 13:28:13 +0100 Message-ID: Subject: Re: [PATCH 8/8] arm64: dts: renesas: salvator: add a connection from adv748x codec (HDMI input) to the R-Car SoC To: Alex Riesen , Kieran Bingham , Mauro Carvalho Chehab , Hans Verkuil , Laurent Pinchart , Rob Herring , Mark Rutland , driverdevel , Linux Media Mailing List , Linux Kernel Mailing List , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux-Renesas Content-Type: text/plain; charset="UTF-8" Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Alex, Thanks for your patch! On Mon, Jan 13, 2020 at 3:24 PM Alex Riesen wrote: > Not sure if all variants of the Salvator board have the HDMI decoder > chip (the ADV7482) connected to the SSI4 on R-Car SoC, as it is on > Salvator-X ES1, so the the ADV7482 endpoint and connection definitions > are placed in the board file. Both Salvator-X and Salvator-XS have SSI4 wired to the ADV7482. > I do assume though that all Salvator variants have the CLK_C clock line > hard-wired to the ADV7482 HDMI decoder, and remove it from the list of > clocks provided by the R-Car sound system. Yes, both Salvator-X and Salvator-XS have it wired that way. But please see below. > The I2C wiring is also likely to persist across the variants (similar > to ak4613, connected to the same interface), so that is in the common > file. > > Signed-off-by: Alexander Riesen Below are my comments w.r.t. the board-specific wiring. I'll defer to the multimedia people for commenting on the audio parts. BTW, what is the status of the other patches in this series? > --- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi > +++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi > @@ -322,6 +322,10 @@ > clock-frequency = <22579200>; > }; > > +&audio_clk_c { > + clock-frequency = <12288000>; > +}; Does the ADV7482 always generate a 12.288 MHz clock signal? Or is this programmable? > + > &avb { > pinctrl-0 = <&avb_pins>; > pinctrl-names = "default"; > @@ -471,12 +475,14 @@ > > #address-cells = <1>; > #size-cells = <0>; > + #sound-dai-cells = <0>; > > interrupt-parent = <&gpio6>; > interrupt-names = "intrq1", "intrq2"; > interrupts = <30 IRQ_TYPE_LEVEL_LOW>, > <31 IRQ_TYPE_LEVEL_LOW>; > - > + clocks = <&rcar_sound 3>, <&audio_clk_c>; > + clock-names = "clk-hdmi-video", "clk-hdmi-i2s-mclk"; The above declares the Audio CLK C to be a clock input of the ADV7482, while it is an output. Furthermore, the DT bindings do not document that clocks can be specified. > port@7 { > reg = <7>; > > @@ -512,6 +518,14 @@ > remote-endpoint = <&csi20_in>; > }; > }; > + > + port@c { > + reg = <12>; > + > + adv7482_i2s: endpoint { > + /* remote-endpoint defined in the board file */ > + }; > + }; > }; > > csa_vdd: adc@7c { > @@ -686,7 +700,8 @@ > }; > > sound_pins: sound { > - groups = "ssi01239_ctrl", "ssi0_data", "ssi1_data_a"; > + groups = "ssi01239_ctrl", "ssi0_data", "ssi1_data_a", > + "ssi4_data"; Missing "ss4_ctrl", for the SCK4 and WS4 pins. > function = "ssi"; > }; > > @@ -735,8 +750,8 @@ > pinctrl-0 = <&sound_pins &sound_clk_pins>; > pinctrl-names = "default"; > > - /* Single DAI */ > - #sound-dai-cells = <0>; > + /* multi DAI */ > + #sound-dai-cells = <1>; > > /* audio_clkout0/1/2/3 */ > #clock-cells = <1>; > @@ -760,8 +775,18 @@ > <&cpg CPG_MOD 1020>, <&cpg CPG_MOD 1021>, > <&cpg CPG_MOD 1019>, <&cpg CPG_MOD 1018>, > <&audio_clk_a>, <&cs2000>, > - <&audio_clk_c>, Why remove it? This is the list of clock inputs, not outputs. > <&cpg CPG_CORE CPG_AUDIO_CLK_I>; > + clock-names = "ssi-all", > + "ssi.9", "ssi.8", "ssi.7", "ssi.6", > + "ssi.5", "ssi.4", "ssi.3", "ssi.2", > + "ssi.1", "ssi.0", > + "src.9", "src.8", "src.7", "src.6", > + "src.5", "src.4", "src.3", "src.2", > + "src.1", "src.0", > + "mix.1", "mix.0", > + "ctu.1", "ctu.0", > + "dvc.0", "dvc.1", > + "clk_a", "clk_b", "clk_i"; > > ports { > #address-cells = <1>; > -- > 2.24.1.508.g91d2dafee0 Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds