From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Biju Das <biju.das@bp.renesas.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Simon Horman <horms@verge.net.au>,
Magnus Damm <magnus.damm@gmail.com>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Chris Paterson <Chris.Paterson2@renesas.com>,
Fabrizio Castro <fabrizio.castro@bp.renesas.com>,
Wolfram Sang <wsa+renesas@sang-engineering.com>
Subject: Re: [PATCH 02/22] ARM: dts: r8a7744: Add I2C and IIC support
Date: Fri, 30 Nov 2018 09:55:50 +0100 [thread overview]
Message-ID: <CAMuHMdVt2DDQJ9Ud6i=GWAeWW0TdpF5xiCxtRiv0dZTGCPEt8A@mail.gmail.com> (raw)
In-Reply-To: <1543319795-48325-3-git-send-email-biju.das@bp.renesas.com>
Hi Biju,
On Tue, Nov 27, 2018 at 1:05 PM Biju Das <biju.das@bp.renesas.com> wrote:
> Add the I2C[0-5] and IIC[0,1,3] devices nodes to the R8A7744 device tree.
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
Thanks for your patch!
> --- a/arch/arm/boot/dts/r8a7744.dtsi
> +++ b/arch/arm/boot/dts/r8a7744.dtsi
> @@ -15,6 +15,18 @@
> #address-cells = <2>;
> #size-cells = <2>;
>
> + aliases {
> + i2c0 = &i2c0;
> + i2c1 = &i2c1;
> + i2c2 = &i2c2;
> + i2c3 = &i2c3;
> + i2c4 = &i2c4;
> + i2c5 = &i2c5;
> + i2c6 = &iic0;
> + i2c7 = &iic1;
> + i2c8 = &iic3;
> + };
Please drop the i2c aliases. If needed at all, device aliases are board-specific
(for ports labeled e.g. "i2c0").
> + iic3: i2c@e60b0000 {
> + /* doesn't need pinmux */
> + #address-cells = <1>;
> + #size-cells = <0>;
> + compatible = "renesas,iic-r8a7744",
> + "renesas,rcar-gen2-iic",
> + "renesas,rmobile-iic";
It seems iic3 on RZ/G1N is different, in that it does not support
automatic transmission.
This is a bit similar like on R-Car E3, where we dropped compatibility
with the generic version to indicate this. But on RZ/G1N we cannot use
the same solution, as the limitation does not apply to all instances.
RZ/G1H and RZ/G1M have the same issue.
> + reg = <0 0xe60b0000 0 0x425>;
> + interrupts = <GIC_SPI 173 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cpg CPG_MOD 926>;
> + dmas = <&dmac0 0x77>, <&dmac0 0x78>,
> + <&dmac1 0x77>, <&dmac1 0x78>;
> + dma-names = "tx", "rx", "tx", "rx";
> + power-domains = <&sysc R8A7744_PD_ALWAYS_ON>;
> + resets = <&cpg 926>;
> + status = "disabled";
> };
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2018-11-30 8:55 UTC|newest]
Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-27 11:56 [PATCH 00/22] Add more support to RZ/G1N Biju Das
2018-11-27 11:56 ` [PATCH 01/22] ARM: dts: r8a7744: Add [H]SCIF{A|B} support Biju Das
2018-11-29 13:31 ` Simon Horman
2018-11-30 8:54 ` Geert Uytterhoeven
2018-11-27 11:56 ` [PATCH 02/22] ARM: dts: r8a7744: Add I2C and IIC support Biju Das
2018-11-29 13:41 ` Simon Horman
2018-11-29 13:52 ` Biju Das
2018-11-30 8:55 ` Geert Uytterhoeven [this message]
2018-11-27 11:56 ` [PATCH 03/22] ARM: dts: r8a7744: Add SDHI nodes Biju Das
2018-11-29 13:49 ` Simon Horman
2018-11-30 8:56 ` Geert Uytterhoeven
2018-11-27 11:56 ` [PATCH 04/22] ARM: dts: r8a7744: Add MMC node Biju Das
2018-11-29 13:53 ` Simon Horman
2018-11-30 8:56 ` Geert Uytterhoeven
2018-11-27 11:56 ` [PATCH 05/22] ARM: dts: r8a7744-iwg20m: Add eMMC support Biju Das
2018-11-29 13:54 ` Simon Horman
2018-11-30 9:50 ` Geert Uytterhoeven
2018-11-30 10:43 ` Biju Das
2018-11-30 11:05 ` Geert Uytterhoeven
2018-11-27 11:56 ` [PATCH 06/22] ARM: dts: r8a7744-iwg20m: Enable SDHI10 controller Biju Das
2018-11-27 14:16 ` Sergei Shtylyov
2018-11-27 14:22 ` Biju Das
2018-11-28 13:24 ` Simon Horman
2018-11-28 14:15 ` Biju Das
2018-11-29 13:56 ` Simon Horman
2018-11-30 9:50 ` Geert Uytterhoeven
2018-11-27 11:56 ` [PATCH 07/22] ARM: dts: r8a7744: USB 2.0 host support Biju Das
2018-11-29 14:00 ` Simon Horman
2018-11-30 8:59 ` Geert Uytterhoeven
2018-11-27 11:56 ` [PATCH 08/22] ARM: dts: r8a7744: Add USB-DMAC and HSUSB device nodes Biju Das
2018-11-29 14:07 ` Simon Horman
2018-11-30 8:57 ` Geert Uytterhoeven
2018-11-27 11:56 ` [PATCH 09/22] ARM: dts: r8a7744: Add RWDT node Biju Das
2018-11-29 14:33 ` Simon Horman
2018-11-30 8:58 ` Geert Uytterhoeven
2018-11-27 11:56 ` [PATCH 10/22] ARM: dts: r8a7744: Add audio support Biju Das
2018-11-29 14:51 ` Simon Horman
2018-11-30 8:59 ` Geert Uytterhoeven
2018-11-27 11:56 ` [PATCH 11/22] ARM: dts: r8a7744: Add DU support Biju Das
2018-11-29 14:56 ` Simon Horman
2018-11-30 9:00 ` Geert Uytterhoeven
2018-11-30 9:34 ` Biju Das
2018-11-27 11:56 ` [PATCH 12/22] ARM: dts: r8a7744-iwg20d-q7-dbcm-ca: Add device tree for camera DB Biju Das
2018-11-29 14:58 ` Simon Horman
2018-11-30 10:04 ` Geert Uytterhoeven
2018-12-04 14:26 ` Simon Horman
2018-11-27 11:56 ` [PATCH 13/22] ARM: dts: r8a7744: Add CAN support Biju Das
2018-11-30 9:00 ` Geert Uytterhoeven
2018-11-27 11:56 ` [PATCH 14/22] ARM: dts: r8a7744: Add IRQC support Biju Das
2018-11-30 9:01 ` Geert Uytterhoeven
2018-11-27 11:56 ` [PATCH 15/22] ARM: dts: r8a7744: Add thermal device to DT Biju Das
2018-11-30 9:01 ` Geert Uytterhoeven
2018-11-27 11:56 ` [PATCH 16/22] ARM: dts: r8a7744: Add CMT SoC specific support Biju Das
2018-11-30 9:01 ` Geert Uytterhoeven
2018-11-27 11:56 ` [PATCH 17/22] ARM: dts: iwg20d-q7-common: Move cmt/rwdt node out of RZ/G1M SOM Biju Das
2018-12-04 14:27 ` Simon Horman
2018-12-04 14:55 ` Geert Uytterhoeven
2018-12-05 19:19 ` Simon Horman
2018-11-27 11:56 ` [PATCH 18/22] ARM: dts: r8a7744: Add QSPI support Biju Das
2018-11-30 9:02 ` Geert Uytterhoeven
2018-12-04 14:28 ` Simon Horman
2018-11-27 11:56 ` [PATCH 19/22] ARM: dts: r8a7744-iwg20m: Add SPI NOR support Biju Das
2018-11-30 10:02 ` Geert Uytterhoeven
2018-11-30 10:33 ` Biju Das
2018-11-30 10:46 ` Geert Uytterhoeven
2018-11-30 11:02 ` Biju Das
2018-12-04 14:32 ` Simon Horman
2018-11-27 11:56 ` [PATCH 20/22] ARM: dts: r8a7744: Add MSIOF[012] support Biju Das
2018-11-30 9:02 ` Geert Uytterhoeven
2018-12-04 14:34 ` Simon Horman
2018-11-27 11:56 ` [PATCH 21/22] ARM: dts: r8a7744: Add xhci support Biju Das
2018-11-30 9:03 ` Geert Uytterhoeven
2018-12-04 14:34 ` Simon Horman
2018-11-27 11:56 ` [PATCH 22/22] ARM: dts: r8a7744: Add PCIe Controller device node Biju Das
2018-11-30 9:03 ` Geert Uytterhoeven
2018-12-04 14:36 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMuHMdVt2DDQJ9Ud6i=GWAeWW0TdpF5xiCxtRiv0dZTGCPEt8A@mail.gmail.com' \
--to=geert@linux-m68k.org \
--cc=Chris.Paterson2@renesas.com \
--cc=biju.das@bp.renesas.com \
--cc=devicetree@vger.kernel.org \
--cc=fabrizio.castro@bp.renesas.com \
--cc=geert+renesas@glider.be \
--cc=horms@verge.net.au \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).