From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: Simon Horman <horms@verge.net.au>,
linux-renesas-soc@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Magnus Damm <magnus.damm@gmail.com>,
Russell King <linux@arm.linux.org.uk>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 07/13] ARM: dts: r8a7792: initial SoC device tree
Date: Wed, 1 Jun 2016 11:23:48 +0200 [thread overview]
Message-ID: <CAMuHMdW2T=UzciTPkU7AwWTBr_iHO3NXfe1BfpPDQbVwjEmbwg@mail.gmail.com> (raw)
In-Reply-To: <2539026.OyU5nvpxa6@wasted.cogentembedded.com>
On Wed, Jun 1, 2016 at 12:24 AM, Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> The initial R8A7792 SoC device tree including 2 CPU cores, GIC, timer, SYSC,
> and the required clock descriptions.
>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
> ---
> arch/arm/boot/dts/r8a7792.dtsi | 423 +++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 423 insertions(+)
>
> Index: renesas/arch/arm/boot/dts/r8a7792.dtsi
> ===================================================================
> --- /dev/null
> +++ renesas/arch/arm/boot/dts/r8a7792.dtsi
> @@ -0,0 +1,423 @@
> +/*
> + * Device Tree Source for the r8a7792 SoC
> + *
> + * Copyright (C) 2016 Cogent Embedded Inc.
> + *
> + * This file is licensed under the terms of the GNU General Public License
> + * version 2. This program is licensed "as is" without any warranty of any
> + * kind, whether express or implied.
> + */
> +
> +#include <dt-bindings/clock/r8a7792-clock.h>
> +#include <dt-bindings/interrupt-controller/arm-gic.h>
#include <dt-bindings/interrupt-controller/irq.h> is included
implicitly by the above.
> +#include <dt-bindings/power/r8a7792-sysc.h>
> +
> +/ {
> + compatible = "renesas,r8a7792";
> + interrupt-parent = <&gic>;
> + #address-cells = <2>;
> + #size-cells = <2>;
> +
> + cpus {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + cpu0: cpu@0 {
> + device_type = "cpu";
> + compatible = "arm,cortex-a15";
> + reg = <0>;
> + clock-frequency = <1000000000>;
> + clocks = <&cpg_clocks R8A7792_CLK_Z>;
> + power-domains = <&sysc R8A7792_PD_CA15_CPU0>;
> + next-level-cache = <&L2_CA15>;
> + };
> +
> + cpu1: cpu@1 {
> + device_type = "cpu";
> + compatible = "arm,cortex-a15";
> + reg = <1>;
> + clock-frequency = <1000000000>;
> + power-domains = <&sysc R8A7792_PD_CA15_CPU1>;
> + next-level-cache = <&L2_CA15>;
> + };
> +
> + L2_CA15: cache-controller@0 {
> + compatible = "cache";
> + reg = <0>;
> + cache-unified;
> + cache-level = <2>;
> + power-domains = <&sysc R8A7792_PD_CA15_SCU>;
> + };
> + };
> +
> + gic: interrupt-controller@f1001000 {
It would be good to group all on-SoC devices under an "soc" node, like we
started doing for r8a7795.
> + clocks {
> + #address-cells = <2>;
> + #size-cells = <2>;
> + ranges;
> +
> + /* External root clock */
> + extal_clk: extal {
> + compatible = "fixed-clock";
> + #clock-cells = <0>;
> + /* This value must be overridden by the board. */
> + clock-frequency = <0>;
> + };
The fixed clocks should be at the root level these days.
> + /* Special CPG clocks */
> + cpg_clocks: cpg_clocks@e6150000 {
> + compatible = "renesas,r8a7792-cpg-clocks",
> + "renesas,rcar-gen2-cpg-clocks";
> + reg = <0 0xe6150000 0 0x1000>;
> + clocks = <&extal_clk>;
> + #clock-cells = <1>;
> + clock-output-names = "main", "pll0", "pll1", "pll3",
> + "lb", "qspi", "sdh", "sd0", "sd1",
> + "z";
"sdh", "sd0", and "sd1" do not exist. Please remove them.
> + z2_clk: z2 {
> + compatible = "fixed-factor-clock";
> + clocks = <&cpg_clocks R8A7792_CLK_PLL1>;
> + #clock-cells = <0>;
> + clock-div = <2>;
> + clock-mult = <1>;
> + };
V2H doesn't have Z2.
> + i_clk: i {
> + compatible = "fixed-factor-clock";
> + clocks = <&cpg_clocks R8A7792_CLK_PLL1>;
> + #clock-cells = <0>;
> + clock-div = <2>;
> + clock-mult = <1>;
> + };
clock-div = <3>;
> + cp_clk: cp {
> + compatible = "fixed-factor-clock";
> + clocks = <&extal_clk>;
> + #clock-cells = <0>;
> + clock-div = <2>;
> + clock-mult = <1>;
> + };
On V2H, CP is derived from PLL1, cfr. CL.
The clock derived from EXTAL is called CPEX.
> + mstp1_clks: mstp1_clks@e6150134 {
> + compatible = "renesas,r8a7792-mstp-clocks",
> + "renesas,cpg-mstp-clocks";
> + reg = <0 0xe6150134 0 4>, <0 0xe6150038 0 4>;
> + clocks = <&p_clk>, <&p_clk>, <&p_clk>, <&rclk_clk>,
> + <&cp_clk>, <&zs_clk>, <&zs_clk>, <&zs_clk>;
> + #clock-cells = <1>;
> + clock-indices = <
> + R8A7792_CLK_TMU1 R8A7792_CLK_TMU3
> + R8A7792_CLK_TMU2 R8A7792_CLK_CMT0
> + R8A7792_CLK_TMU0 R8A7792_CLK_VSP1DU1
> + R8A7792_CLK_VSP1DU0 R8A7792_CLK_VSP1_SY
> + >;
> + clock-output-names = "tmu1", "tmu3", "tmu2", "cmt0",
> + "tmu0", "vsp1du1", "vsp1du0",
These are called "vsp1-du1", "vsp1-du0" in all other R-Car Gen2 dtsis.
> + "vsp1-sy";
> + };
> + mstp2_clks: mstp2_clks@e6150138 {
> + compatible = "renesas,r8a7792-mstp-clocks",
> + "renesas,cpg-mstp-clocks";
> + reg = <0 0xe6150138 0 4>, <0 0xe6150040 0 4>;
> + clocks = <&mp_clk>, <&zs_clk>, <&zs_clk>;
> + #clock-cells = <1>;
> + clock-indices = <
> + R8A7792_CLK_MSIOF1
> + R8A7792_CLK_SYS_DMAC0 R8A7792_CLK_SYS_DMAC1
Wrong order of the DMACs.
> + >;
> + clock-output-names = "msiof1", "sys-dmac0", "sys-dmac1";
Wrong order of the DMACs.
> + };
> + mstp3_clks: mstp3_clks@e615013c {
> + compatible = "renesas,r8a7792-mstp-clocks",
> + "renesas,cpg-mstp-clocks";
> + reg = <0 0xe615013c 0 4>, <0 0xe6150048 0 4>;
> + clocks = <&cp_clk>, <&cpg_clocks R8A7792_CLK_SD0>,
As there's no SD0, this can't be correct.
> + <&rclk_clk>;
> + #clock-cells = <1>;
> + clock-indices = <
> + R8A7792_CLK_TPU0 R8A7792_CLK_SDHI0
> + R8A7792_CLK_CMT1
> + >;
> + clock-output-names = "tpu0", "sdhi0", "cmt1";
> + };
> + mstp5_clks: mstp5_clks@e6150144 {
> + compatible = "renesas,r8a7792-mstp-clocks",
> + "renesas,cpg-mstp-clocks";
> + reg = <0 0xe6150144 0 4>, <0 0xe615003c 0 4>;
> + clocks = <&hp_clk>, <&extal_clk>, <&p_clk>;
> + #clock-cells = <1>;
> + clock-indices = <
> + R8A7792_CLK_AUDIO_DMAC0
> + R8A7792_CLK_THERMAL R8A7792_CLK_PWM
> + >;
> + clock-output-names = "thermal", "pwm", "audmac0";
clock-output-names = "audmac0", "thermal", "pwm";
> + };
> + mstp9_clks: mstp9_clks@e6150994 {
> + compatible = "renesas,r8a7792-mstp-clocks",
> + "renesas,cpg-mstp-clocks";
> + reg = <0 0xe6150994 0 4>, <0 0xe61509a4 0 4>;
> + clocks = <&cp_clk>, <&cp_clk>, <&cp_clk>, <&cp_clk>,
> + <&cp_clk>, <&cp_clk>, <&cp_clk>, <&cp_clk>,
> + <&cp_clk>, <&cp_clk>, <&p_clk>, <&p_clk>,
> + <&cpg_clocks R8A7792_CLK_QSPI>, <&cp_clk>,
> + <&cp_clk>, <&hp_clk>, <&cp_clk>, <&hp_clk>,
> + <&hp_clk>, <&hp_clk>, <&hp_clk>, <&hp_clk>;
> + #clock-cells = <1>;
> + clock-indices = <
> + R8A7792_CLK_GPIO7 R8A7792_CLK_GPIO6
> + R8A7792_CLK_GPIO5 R8A7792_CLK_GPIO4
> + R8A7792_CLK_GPIO3 R8A7792_CLK_GPIO2
> + R8A7792_CLK_GPIO1 R8A7792_CLK_GPIO0
> + R8A7792_CLK_GPIO11 R8A7792_CLK_GPIO10
> + R8A7792_CLK_CAN1 R8A7792_CLK_CAN0
> + R8A7792_CLK_QSPI_MOD R8A7792_CLK_GPIO9
> + R8A7792_CLK_GPIO8 R8A7792_CLK_I2C5
> + R8A7792_CLK_IICDVFS R8A7792_CLK_I2C4
> + R8A7792_CLK_I2C3 R8A7792_CLK_I2C2
> + R8A7792_CLK_I2C1 R8A7792_CLK_I2C0
> + >;
> + clock-output-names = "gpio7", "gpio6", "gpio5", "gpio4",
> + "gpio3", "gpio2", "gpio1", "gpio0",
> + "gpio11", "gpio10", "can1", "can0",
These are called "rcan1", "rcan0" in other dtsis.
> + "qspi_mod", "gpio9", "gpio8",
> + "i2c5", "iic3", "i2c4", "i2c3",
> + "i2c2", "i2c1", "i2c0";
> + };
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2016-06-01 9:23 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-31 22:06 [PATCH 00/13] Add R8A7794/SILK board eMMC DT support Sergei Shtylyov
2016-05-31 22:09 ` [PATCH 01/13] ARM: shmobile: r8a7792: add clock index macros Sergei Shtylyov
2016-06-01 0:52 ` Simon Horman
2016-06-01 13:57 ` Sergei Shtylyov
2016-06-22 19:52 ` Sergei Shtylyov
2016-06-22 22:33 ` Simon Horman
[not found] ` <20160622223330.GA15843-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
2016-06-23 7:46 ` Geert Uytterhoeven
2016-06-23 10:49 ` Sergei Shtylyov
[not found] ` <2280165.siMXMbFrFe-gHKXc3Y1Z8zGSmamagVegGFoWSdPRAKMAL8bYrjMMd8@public.gmane.org>
2016-06-01 7:22 ` Geert Uytterhoeven
2016-06-01 14:09 ` Sergei Shtylyov
2016-05-31 22:11 ` [PATCH 02/13] ARM: shmobile: r8a7792: add power domain " Sergei Shtylyov
2016-06-01 7:32 ` Geert Uytterhoeven
2016-05-31 22:20 ` [PATCH 05/13] DT: clock: rcar-gen2-cpg-clocks: document R8A7792 support Sergei Shtylyov
2016-06-01 0:25 ` Simon Horman
2016-06-01 0:30 ` Simon Horman
2016-06-01 7:50 ` Geert Uytterhoeven
2016-06-01 7:48 ` Geert Uytterhoeven
2016-06-03 1:49 ` Rob Herring
2016-05-31 22:21 ` [PATCH 06/13] DT: clock: cpg-mstp-clocks: document-R8A7792-support Sergei Shtylyov
2016-06-01 0:28 ` Simon Horman
2016-06-01 7:51 ` Geert Uytterhoeven
2016-06-03 1:50 ` Rob Herring
2016-05-31 22:24 ` [PATCH 07/13] ARM: dts: r8a7792: initial SoC device tree Sergei Shtylyov
2016-06-01 0:57 ` Simon Horman
2016-06-01 14:00 ` Sergei Shtylyov
2016-06-06 22:26 ` Sergei Shtylyov
2016-06-07 7:13 ` Geert Uytterhoeven
2016-06-07 20:58 ` Sergei Shtylyov
2016-06-10 1:02 ` Simon Horman
2016-06-10 19:29 ` Sergei Shtylyov
2016-06-10 20:42 ` Geert Uytterhoeven
2016-06-10 20:50 ` Sergei Shtylyov
2016-06-13 7:12 ` Geert Uytterhoeven
2016-06-13 11:24 ` Sergei Shtylyov
[not found] ` <7d93d81d-cca9-e434-6488-0ea839f81663-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2016-06-13 11:48 ` Geert Uytterhoeven
2016-06-14 1:08 ` Kuninori Morimoto
2016-06-17 2:14 ` Kuninori Morimoto
2016-06-17 6:27 ` Geert Uytterhoeven
[not found] ` <8efb1c7e-5463-2556-744c-d327886d92d4-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2016-06-14 0:43 ` Simon Horman
2016-06-14 21:08 ` Sergei Shtylyov
2016-06-16 0:06 ` Simon Horman
2016-06-01 9:23 ` Geert Uytterhoeven [this message]
2016-05-31 22:25 ` [PATCH 08/13] ARM: dts: r8a7792: add SYS-DMAC support Sergei Shtylyov
2016-06-01 1:03 ` Simon Horman
[not found] ` <5621267.GpvUaW18zI-gHKXc3Y1Z8zGSmamagVegGFoWSdPRAKMAL8bYrjMMd8@public.gmane.org>
2016-06-01 8:15 ` Geert Uytterhoeven
2016-05-31 22:26 ` [PATCH 09/13] ARM: dts: r8a7792: add [H]SCIF support Sergei Shtylyov
2016-06-01 1:13 ` Simon Horman
2016-06-03 14:33 ` Sergei Shtylyov
2016-06-01 8:17 ` Geert Uytterhoeven
2016-05-31 22:29 ` [PATCH 10/13] ARM: dts: r8a7792: add IRQC support Sergei Shtylyov
2016-06-01 1:18 ` Simon Horman
2016-06-01 14:02 ` Sergei Shtylyov
[not found] ` <3573091.BUvyGW3hVt-gHKXc3Y1Z8zGSmamagVegGFoWSdPRAKMAL8bYrjMMd8@public.gmane.org>
2016-06-01 8:17 ` Geert Uytterhoeven
2016-05-31 22:30 ` [PATCH 11/13] DT: arm: shmobile: document Blanche board Sergei Shtylyov
2016-05-31 23:51 ` Simon Horman
[not found] ` <20160531235119.GA20527-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
2016-06-01 13:34 ` Sergei Shtylyov
2016-06-01 8:19 ` Geert Uytterhoeven
2016-06-03 1:50 ` Rob Herring
2016-05-31 22:32 ` [PATCH 12/13] ARM: dts: blanche: initial device tree Sergei Shtylyov
2016-06-01 1:21 ` Simon Horman
2016-06-02 21:34 ` Sergei Shtylyov
2016-06-01 8:36 ` Geert Uytterhoeven
2016-05-31 22:33 ` [PATCH 13/13] ARM: dts: blanche: add Ethernet support Sergei Shtylyov
2016-06-01 1:24 ` Simon Horman
[not found] ` <1669958.qjJ7i3NBPv-gHKXc3Y1Z8zGSmamagVegGFoWSdPRAKMAL8bYrjMMd8@public.gmane.org>
2016-06-01 8:22 ` Geert Uytterhoeven
2016-06-01 12:16 ` Sergei Shtylyov
[not found] ` <a60346f2-2abb-342b-dd20-38d401c4ceb3-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2016-06-01 12:27 ` Geert Uytterhoeven
2016-06-02 21:33 ` Sergei Shtylyov
[not found] ` <13205049.n7pM8utpHF-gHKXc3Y1Z8zGSmamagVegGFoWSdPRAKMAL8bYrjMMd8@public.gmane.org>
2016-06-01 7:04 ` [PATCH 00/13] Add R8A7794/SILK board eMMC DT support Geert Uytterhoeven
2016-06-01 10:30 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMuHMdW2T=UzciTPkU7AwWTBr_iHO3NXfe1BfpPDQbVwjEmbwg@mail.gmail.com' \
--to=geert@linux-m68k.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=horms@verge.net.au \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=magnus.damm@gmail.com \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).