From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Rob Herring <robh@kernel.org>
Cc: Kieran Bingham <kieran@ksquared.org.uk>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
"open list:MEDIA DRIVERS FOR RENESAS - FCP"
<linux-media@vger.kernel.org>,
"open list:MEDIA DRIVERS FOR RENESAS - FCP"
<linux-renesas-soc@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] dt-bindings: Document Renesas R-Car FCP power-domains usage
Date: Fri, 10 Jun 2016 21:11:25 +0200 [thread overview]
Message-ID: <CAMuHMdWQZjE+AnPry6PiVc69PVdZ_2zstOKR==B6nywun2Om9Q@mail.gmail.com> (raw)
In-Reply-To: <20160610173914.GA20505@rob-hp-laptop>
Hi Rob,
On Fri, Jun 10, 2016 at 7:39 PM, Rob Herring <robh@kernel.org> wrote:
> On Thu, Jun 09, 2016 at 02:41:33PM +0100, Kieran Bingham wrote:
>> The power domain must be specified to bring the device out of module
>> standby. Document this in the example provided, so that new additions
>> are not missed.
>>
>> Signed-off-by: Kieran Bingham <kieran@bingham.xyz>
>> ---
>> Documentation/devicetree/bindings/media/renesas,fcp.txt | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.txt b/Documentation/devicetree/bindings/media/renesas,fcp.txt
>> index 271dcfdb5a76..6a55f5215221 100644
>> --- a/Documentation/devicetree/bindings/media/renesas,fcp.txt
>> +++ b/Documentation/devicetree/bindings/media/renesas,fcp.txt
>> @@ -31,4 +31,5 @@ Device node example
>> compatible = "renesas,r8a7795-fcpv", "renesas,fcpv";
>> reg = <0 0xfea2f000 0 0x200>;
>> clocks = <&cpg CPG_MOD 602>;
>> + power-domains = <&sysc R8A7795_PD_A3VP>;
>
> This needs to be documented above too, not just the example.
Why? Power domains are an optional feature, whose presence depends
on the platform, not on the device.
Hence "power-domains" properties may appear in any device node.
Having to document them in every single binding document is overkill.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2016-06-10 19:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1465479695-18644-1-git-send-email-kieran@bingham.xyz>
2016-06-09 13:41 ` [PATCH 1/3] dt-bindings: Update Renesas R-Car FCP DT binding Kieran Bingham
2016-06-10 17:37 ` Rob Herring
2016-06-13 11:28 ` Kieran Bingham
[not found] ` <1465479695-18644-2-git-send-email-kieran-SI8QzZ7I9JUn3X9lZQuFcg@public.gmane.org>
2016-06-13 12:17 ` Laurent Pinchart
2016-06-09 13:41 ` [PATCH 2/3] dt-bindings: Document Renesas R-Car FCP power-domains usage Kieran Bingham
[not found] ` <1465479695-18644-3-git-send-email-kieran-SI8QzZ7I9JUn3X9lZQuFcg@public.gmane.org>
2016-06-10 17:39 ` Rob Herring
2016-06-10 19:11 ` Geert Uytterhoeven [this message]
2016-06-10 21:33 ` Rob Herring
2016-06-12 8:46 ` Geert Uytterhoeven
2016-06-09 13:41 ` [PATCH 3/3] dt-bindings: Add Renesas R-Car FDP1 bindings Kieran Bingham
2016-06-10 17:40 ` Rob Herring
2016-06-13 11:31 ` Kieran Bingham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMuHMdWQZjE+AnPry6PiVc69PVdZ_2zstOKR==B6nywun2Om9Q@mail.gmail.com' \
--to=geert@linux-m68k.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kieran@ksquared.org.uk \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).