From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05B27C433F5 for ; Tue, 9 Nov 2021 08:39:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E5DFC611C4 for ; Tue, 9 Nov 2021 08:39:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244320AbhKIImd (ORCPT ); Tue, 9 Nov 2021 03:42:33 -0500 Received: from mail-vk1-f179.google.com ([209.85.221.179]:36498 "EHLO mail-vk1-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244324AbhKIImc (ORCPT ); Tue, 9 Nov 2021 03:42:32 -0500 Received: by mail-vk1-f179.google.com with SMTP id b192so3968532vkf.3; Tue, 09 Nov 2021 00:39:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=RhEU7/cMn0jM+Rvv1TDlHzOAxsTE31x17vOVQ8kJt3g=; b=VZ9g06ZAwQPDkNRttHsK/eL3Y1pHtCeO2Fi2EGhbG7SPzgK7FaVewRgeiu0tAAy215 WaCfwzsYUlvbw20LCLfs8fcXsBu77+qPWM2P2bHKELJBsZDdErCXP3wD6xdkMn5soI33 5z8ZlBj/h47FFbGuoy9Jc4TJnySsNGZcbiwjyN1l5+pWRAOnbmkuEoGi4xROhiREwWuj gGwoxYlMi3YoKd0KKq7HUe/rk+cP0BdJHGjgS5J+N/NFtDTOcE0fzpULJYhgCabB+Sr3 nlv3RyYfI/fDguBE00hHKDeC8Socqcj0Y1HFXZ78vTLpvIXwsCIp654xvJNq85WtbTO0 /tZQ== X-Gm-Message-State: AOAM530gg5gyF1vWB+qCj2ulOR0jKjPqvXR3QJW7S3fujQpwOorFunAQ k1z8X5qyOZKEYCqGkd5AUzgwhKpNbt3/O49A X-Google-Smtp-Source: ABdhPJx0i0radw7kJgP5pqxSrLSZGsN5Cel+MReidhcy9UCfp1QLl3Lbg8JubezsdAGemilOyJAXXA== X-Received: by 2002:a05:6122:2090:: with SMTP id i16mr8629246vkd.18.1636447185930; Tue, 09 Nov 2021 00:39:45 -0800 (PST) Received: from mail-ua1-f49.google.com (mail-ua1-f49.google.com. [209.85.222.49]) by smtp.gmail.com with ESMTPSA id k185sm3593725vsc.21.2021.11.09.00.39.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Nov 2021 00:39:45 -0800 (PST) Received: by mail-ua1-f49.google.com with SMTP id p37so35895611uae.8; Tue, 09 Nov 2021 00:39:45 -0800 (PST) X-Received: by 2002:a05:6102:1354:: with SMTP id j20mr38560622vsl.41.1636447185011; Tue, 09 Nov 2021 00:39:45 -0800 (PST) MIME-Version: 1.0 References: <20211108150554.4457-1-conor.dooley@microchip.com> <20211108150554.4457-8-conor.dooley@microchip.com> In-Reply-To: <20211108150554.4457-8-conor.dooley@microchip.com> From: Geert Uytterhoeven Date: Tue, 9 Nov 2021 09:39:33 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 07/13] dt-bindings: rtc: add bindings for microchip mpfs rtc To: Conor Dooley Cc: Linus Walleij , Bartosz Golaszewski , Rob Herring , Jassi Brar , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alessandro Zummo , Alexandre Belloni , Mark Brown , Greg KH , Lewis Hanly , daire.mcnamara@microchip.com, Atish Patra , ivan.griffin@microchip.com, "open list:GPIO SUBSYSTEM" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Kernel Mailing List , Linux I2C , linux-riscv , Linux Crypto Mailing List , linux-rtc@vger.kernel.org, linux-spi , USB list , Krzysztof Kozlowski , Bin Meng Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Conor, On Mon, Nov 8, 2021 at 4:07 PM wrote: > From: Conor Dooley > > Add device tree bindings for the real time clock on > the Microchip PolarFire SoC. > > Signed-off-by: Conor Dooley > Signed-off-by: Daire McNamara Thanks for your patch! > --- /dev/null > +++ b/Documentation/devicetree/bindings/rtc/microchip,mfps-rtc.yaml > @@ -0,0 +1,61 @@ > +examples: > + - | > + #include > + soc { > + #address-cells = <2>; > + #size-cells = <2>; Examples are indeed built with #{address,size}-cells = <1>. However, there is no need to override this. Just drop the zeros in the reg property below. > + rtc@20124000 { > + compatible = "microchip,mpfs-rtc"; > + reg = <0 0x20124000 0 0x1000>; > + clocks = <&clkcfg CLK_RTC>; > + clock-names = "rtc"; > + interrupts = <80>; > + }; > + }; > +... Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds