devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Fabrizio Castro <fabrizio.castro.jz@renesas.com>,
	Rob Herring <robh+dt@kernel.org>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
	Ramesh Shanmugasundaram <rashanmu@gmail.com>,
	Linux Media Mailing List <linux-media@vger.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
	Chris Paterson <Chris.Paterson2@renesas.com>,
	Biju Das <biju.das.jz@bp.renesas.com>,
	Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Rob Herring <robh@kernel.org>,
	Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
	Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Subject: Re: [PATCH v5 2/5] media: dt-bindings: media: renesas,drif: Convert to json-schema
Date: Thu, 14 Jan 2021 14:02:42 +0100	[thread overview]
Message-ID: <CAMuHMdWj_Gm6vwOF9Akz84WakA3KTcNTRHte6ukEF_U5=Q8xFA@mail.gmail.com> (raw)
In-Reply-To: <20201021135332.4928-3-fabrizio.castro.jz@renesas.com>

Hi Fabrizio, Rob,

On Wed, Oct 21, 2020 at 3:53 PM Fabrizio Castro
<fabrizio.castro.jz@renesas.com> wrote:
> Convert the Renesas DRIF bindings to DT schema and update
> MAINTAINERS accordingly.
>
> Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
> Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Reviewed-by: Rob Herring <robh@kernel.org>

Thanks for your patch!

> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/renesas,drif.yaml

> +  clock-names:
> +    maxItems: 1
> +    items:
> +      - const: fck

With latest dt-schema, "make dt_binding_check" complains:

    Documentation/devicetree/bindings/media/renesas,drif.yaml:
properties:clock-names:maxItems: False schema does not allow 1
    Documentation/devicetree/bindings/media/renesas,drif.yaml:
ignoring, error in schema: properties: clock-names: maxItems

Using

       clock-names:
         const: fck

Fixes that.

However, I'm wondering why I do not get a complaint about the similar
clock/clock-names in
Documentation/devicetree/bindings/display/bridge/renesas,lvds.yaml.
Because they're part of an else branch?

Thanks!

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

  reply	other threads:[~2021-01-14 13:03 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-21 13:53 [PATCH v5 0/5] Add r8a77965 DRIF support Fabrizio Castro
2020-10-21 13:53 ` [PATCH v5 1/5] MAINTAINERS: Update MAINTAINERS for Renesas DRIF driver Fabrizio Castro
2020-10-21 13:53 ` [PATCH v5 2/5] media: dt-bindings: media: renesas,drif: Convert to json-schema Fabrizio Castro
2021-01-14 13:02   ` Geert Uytterhoeven [this message]
2021-01-20 18:19     ` Fabrizio Castro
2021-01-20 18:44       ` Fabrizio Castro
2021-04-07 18:27     ` Rob Herring
2021-04-08 20:23       ` Fabrizio Castro
2020-10-21 13:53 ` [PATCH v5 3/5] media: dt-bindings: media: renesas,drif: Add r8a77990 support Fabrizio Castro
2020-10-21 13:53 ` [PATCH v5 4/5] media: dt-bindings: media: renesas,drif: Add r8a77965 support Fabrizio Castro
2020-10-21 13:53 ` [PATCH v5 5/5] arm64: dts: r8a77965: Add DRIF support Fabrizio Castro
2020-10-22 13:03   ` Geert Uytterhoeven
2020-10-21 21:43 ` [PATCH v5 0/5] Add r8a77965 " Laurent Pinchart
2020-10-22  8:25   ` Fabrizio Castro
2021-03-27 10:05   ` Hans Verkuil
2021-03-28  1:20     ` Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMuHMdWj_Gm6vwOF9Akz84WakA3KTcNTRHte6ukEF_U5=Q8xFA@mail.gmail.com' \
    --to=geert@linux-m68k.org \
    --cc=Chris.Paterson2@renesas.com \
    --cc=biju.das.jz@bp.renesas.com \
    --cc=devicetree@vger.kernel.org \
    --cc=fabrizio.castro.jz@renesas.com \
    --cc=kieran.bingham+renesas@ideasonboard.com \
    --cc=laurent.pinchart+renesas@ideasonboard.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
    --cc=rashanmu@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).