From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 816D3C2BBE2 for ; Wed, 4 Dec 2019 08:41:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5F11A206DF for ; Wed, 4 Dec 2019 08:41:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727149AbfLDIlJ (ORCPT ); Wed, 4 Dec 2019 03:41:09 -0500 Received: from mail-oi1-f196.google.com ([209.85.167.196]:46190 "EHLO mail-oi1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726217AbfLDIlJ (ORCPT ); Wed, 4 Dec 2019 03:41:09 -0500 Received: by mail-oi1-f196.google.com with SMTP id a124so6074146oii.13; Wed, 04 Dec 2019 00:41:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sdH7qTtZf1EWXzHyucbdWpqxN++s9yx5fEkVuEPj9rY=; b=GqjDYSpk7/8zKD8lYJbu83XrZXclde0jhdYI8ZR5FlXt/zvK66QB0mrMGmv4BiVwRr AZxYVMWLZxfTLtHsxdNSf8nXIdMwZB6ptEE/lx9GLbVX4Z9JccluIk0bCK1GzneTTYzY xB+WVHSz8NhZ3K6tRiCqraBwdUlaA0t751wJlb/+1F4xnMUbdegmWdc+2nKE1Ij2QTnf AGXwZ0HdxdKGeN7ncDwgK7Gc0KD9ddBE5QAUI7NjCf5ZW7b4lRquvg37OFrXavR1Zct6 qb75uA5or38pRCHfkK8zcpZT0l6atmgttBId7BVvchIIYGiJd2xg7acQaf8iBrv4Kawm S4Ig== X-Gm-Message-State: APjAAAXN7w4mWgDC6Tf5sVrLVs8cIwaSvT9brTTZITLqg9Rxqb+8gtnn bQNHBSt4pbhhcSoeJVvPY7TGOXTEiJ04Vbp59HQ= X-Google-Smtp-Source: APXvYqzVU71ZSwcCNz6Z7HOJglmUdD+vS5+BMYSIN0rSyT1OeO2Im8TBsts5Xyi79Z2W7dlY7dDYlBUw1n6tYQbznM8= X-Received: by 2002:aca:3a86:: with SMTP id h128mr1549842oia.131.1575448868441; Wed, 04 Dec 2019 00:41:08 -0800 (PST) MIME-Version: 1.0 References: <20191203034519.5640-1-chris.brandt@renesas.com> <20191203034519.5640-7-chris.brandt@renesas.com> In-Reply-To: From: Geert Uytterhoeven Date: Wed, 4 Dec 2019 09:40:56 +0100 Message-ID: Subject: Re: [PATCH 6/6] dt-bindings: spi: Document Renesas SPIBSC bindings To: Chris Brandt Cc: Mark Brown , Rob Herring , Mark Rutland , Geert Uytterhoeven , Michael Turquette , Stephen Boyd , linux-spi , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux-Renesas , linux-clk , Mason Yang , Sergei Shtylyov Content-Type: text/plain; charset="UTF-8" Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, Dec 3, 2019 at 9:39 PM Geert Uytterhoeven wrote: > On Tue, Dec 3, 2019 at 7:57 PM Geert Uytterhoeven wrote: > Once you have added basic Runtime PM support to > drivers/mtd/maps/physmap-core.c:physmap_flash_probe(), the module clock > should be kept enabled through the clock domain when using direct mapped > mode (hmm, as the driver currently lacks this, it means the FLASH on > ape6evm must rely on the bsc module clock being kept enabled through the > Ethernet controller connected to the same bsc module?). JFTR, this is indeed broken: after removing the Ethernet node from r8a73a4-ape6evm.dts, accessing the FLASH crashes the system with an imprecise external abort. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds