From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D64CBC433E0 for ; Mon, 22 Mar 2021 15:38:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A709E61984 for ; Mon, 22 Mar 2021 15:38:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230180AbhCVPiU (ORCPT ); Mon, 22 Mar 2021 11:38:20 -0400 Received: from mail-vs1-f46.google.com ([209.85.217.46]:39817 "EHLO mail-vs1-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230091AbhCVPiQ (ORCPT ); Mon, 22 Mar 2021 11:38:16 -0400 Received: by mail-vs1-f46.google.com with SMTP id e72so2232004vsc.6; Mon, 22 Mar 2021 08:38:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HeaWu7NQhqTg67+28QJCmBXaQRsdudr3ZwUMLAQvMow=; b=pxJp6kwcs2WRp/H7USwaqjME4s4abgdyDbFEL0aZTRRWtWMwwWPca8sq8JjFDUouMF mP3PhHoUu6jpj2G6rja5KTcJNXGashBWBJQo2mvNmtGFp8ZXa9vnjruHzzwa0YeIlEFo w8br3x8E47ceHueurHwui310Ro2R51xUIe7L/dz8mY21EmWS3wqjQRi6D70HZhZETW8j EaJlHPRRMXE62uPp4MKGeG67SxAXDyv3c7eXosARVXk2LRRL8sQxhaaJc+jhLwm+i2op lxXVkzTYPE9aIsk2ad9tCArTkYPgyIq4KULkE86xxBkvZb2/V4tr21kPC0SIpB9ugRI0 P3YQ== X-Gm-Message-State: AOAM533I+WX2zMqHD/JKmigePgZYo4r+RtLm1rgWg4Y6zf2cEihb/1LB U63vdtubpwR6IfJ7XNXgnuzv6L43rUtqPTnj1DE= X-Google-Smtp-Source: ABdhPJxNe+DMTZdB2lWgUCE5StB9yp5TTZKT2HloywUXMNLbDmvZ6gW30OxDfaCQ8FunvzXfxRMyQk6bPYmPn8SKULg= X-Received: by 2002:a67:8883:: with SMTP id k125mr515895vsd.18.1616427495528; Mon, 22 Mar 2021 08:38:15 -0700 (PDT) MIME-Version: 1.0 References: <1599734644-4791-1-git-send-email-sagar.kadam@sifive.com> <1599734644-4791-3-git-send-email-sagar.kadam@sifive.com> <20200922203429.GA3188204@bogus> In-Reply-To: <20200922203429.GA3188204@bogus> From: Geert Uytterhoeven Date: Mon, 22 Mar 2021 16:38:04 +0100 Message-ID: Subject: Re: [PATCH v1 2/3] dt-bindings: riscv: convert plic bindings to json-schema To: Sagar Kadam , Rob Herring Cc: Linux PWM List , Linux Kernel Mailing List , linux-riscv , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-clk , Michael Turquette , Stephen Boyd , Paul Walmsley , Palmer Dabbelt , Thomas Gleixner , Jason Cooper , Marc Zyngier , Thierry Reding , =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , Lee Jones , Albert Ou , Yash Shah Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Sagar, Rob, (replying to an old email, as this one seems to be the most appropriate) On Tue, Sep 22, 2020 at 10:34 PM Rob Herring wrote: > On Thu, Sep 10, 2020 at 04:14:03PM +0530, Sagar Kadam wrote: > > Convert device tree bindings for SiFive's PLIC to YAML format > > > > Signed-off-by: Sagar Kadam > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/interrupt-controller/sifive,plic-1.0.0.yaml > > + > > + '#address-cells': > > + const: 0 > > + description: Should be <0> or more. > > Drop. 'or more' is wrong. If there's a case with more, it will need to > be documented. Why do we have the "'#address-cells': const: 0" at all... > > +required: > > + - compatible > > + - '#address-cells' ... and why is it required? > > + - '#interrupt-cells' > > + - interrupt-controller > > + - reg > > + - interrupts-extended > > + - riscv,ndev > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + plic: interrupt-controller@c000000 { > > + #address-cells = <0>; > > + #interrupt-cells = <1>; > > + compatible = "sifive,plic-1.0.0", "sifive,fu540-c000-plic"; > > + interrupt-controller; > > + interrupts-extended = < > > + &cpu0_intc 11 > > + &cpu1_intc 11 &cpu1_intc 9 > > + &cpu2_intc 11 &cpu2_intc 9 > > + &cpu3_intc 11 &cpu3_intc 9 > > + &cpu4_intc 11 &cpu4_intc 9>; > > + reg = <0xc000000 0x4000000>; > > + riscv,ndev = <10>; > > + }; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds