From: Baolin Wang <baolin.wang@linaro.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
devicetree <devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH 2/2] gpio: Add GPIO driver for Spreadtrum SC9860 platform
Date: Thu, 1 Feb 2018 11:08:46 +0800 [thread overview]
Message-ID: <CAMz4kuLO=zRqg72=7dC2fLHyVcEOcsU0PqiZM8XEYC3TGT1fYA@mail.gmail.com> (raw)
In-Reply-To: <CAHp75VcYQMYNmW9-MkOKA5TWV2JgNfqnUB22s1qB4Z0ZZbTG2g@mail.gmail.com>
On 31 January 2018 at 22:23, Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> On Wed, Jan 31, 2018 at 4:01 AM, Baolin Wang <baolin.wang@linaro.org> wrote:
>> On 31 January 2018 at 00:48, Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
>>> On Tue, Jan 30, 2018 at 2:07 PM, Baolin Wang <baolin.wang@linaro.org> wrote:
>>>> The Spreadtrum SC9860 platform GPIO controller contains 16 groups and
>>>> each group contains 16 GPIOs. Each GPIO can set input/output and has
>>>> the interrupt capability.
>>>
>>>> +config GPIO_SPRD
>>>
>>>> + bool "Spreadtrum GPIO support"
>>>
>>> Either you have to put tristate here, or remove all redundant
>>> module_*() and MODULE_*() macros.
>>
>> I will remove module_*() and MODULE_*() macros in next version. Thanks
>> for your comments.
>
> In that case you need to explain why driver can't be module. (And
> don't forget to replace module.h with init.h).
After more investigation, I found most GPIO dependencies can be
deferred to probe. So I will change the GPIO driver to module level
and change bool to tristate in next version.
--
Baolin.wang
Best Regards
next prev parent reply other threads:[~2018-02-01 3:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-30 12:07 [PATCH 1/2] dt-bindings: gpio: Add Spreadtrum GPIO controller documentation Baolin Wang
[not found] ` <2834309f69a1ec37b84a33f153a3d0b90336bcc6.1517313987.git.baolin.wang-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2018-01-30 12:07 ` [PATCH 2/2] gpio: Add GPIO driver for Spreadtrum SC9860 platform Baolin Wang
[not found] ` <cccc1addb9c0cc541b676dbad005ec341d12d165.1517313987.git.baolin.wang-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2018-01-30 16:48 ` Andy Shevchenko
2018-01-31 2:01 ` Baolin Wang
[not found] ` <CAMz4kuL9r+97_rDihgKD_TyNaDQ3aCk7go6e4mB24QOpovFYJg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-01-31 14:23 ` Andy Shevchenko
2018-02-01 3:08 ` Baolin Wang [this message]
2018-02-01 12:22 ` Marcus Folkesson
2018-02-01 12:26 ` Baolin Wang
[not found] ` <20180201122230.GC690-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-02-01 15:12 ` Andy Shevchenko
2018-02-01 12:17 ` Marcus Folkesson
2018-02-01 12:26 ` Baolin Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMz4kuLO=zRqg72=7dC2fLHyVcEOcsU0PqiZM8XEYC3TGT1fYA@mail.gmail.com' \
--to=baolin.wang@linaro.org \
--cc=andy.shevchenko@gmail.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).