From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C40EAC2D0A3 for ; Thu, 29 Oct 2020 11:22:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4D8C320706 for ; Thu, 29 Oct 2020 11:22:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ewWaIJjH" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726809AbgJ2LWb (ORCPT ); Thu, 29 Oct 2020 07:22:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36214 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725805AbgJ2LWb (ORCPT ); Thu, 29 Oct 2020 07:22:31 -0400 Received: from mail-ej1-x643.google.com (mail-ej1-x643.google.com [IPv6:2a00:1450:4864:20::643]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9BDFDC0613CF for ; Thu, 29 Oct 2020 04:22:09 -0700 (PDT) Received: by mail-ej1-x643.google.com with SMTP id o9so1217637ejg.1 for ; Thu, 29 Oct 2020 04:22:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=akJjnKgChtPHn1VCP5nrwISfhAo3fx3GZVYJ2WPzINs=; b=ewWaIJjHFKGKqvgL41q2OvIkXN5pl2CbAbCb9VHcHnDUoKfDL5DKjW7tJwd+Pzgudq JSY/5U2MG37fJJxK+Gbh1T3Ta/6M623C4OdWDYh19qJSwmLPxC9FdU6t8QV4SSRXsChi w/ws8P+EtYnRcar53HIKjW1kbaZ4uOhxvqJiX6PE1arlTdIJGaI3xZvamj5NjCyk0n+f Wf8UZsADEYi2bMqP6rlLAoBEP2+tcGK1478dED60HioNhzUK8xW/S+T8xaO/BCv6Kb09 HJplxo+o+jLyIYhpATottuzMwswu+RLfiJtKgw4K8xdlw0s7aJ98WUO+Mkr3eUh2q64Q +1cA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=akJjnKgChtPHn1VCP5nrwISfhAo3fx3GZVYJ2WPzINs=; b=AowQKNzfqN5o2ZBTI3xjgEBmbgw/wlYmx6S5n9c5owli5sQEIA24vKNSMlY7OnOqkX 6vZKZw82NVWpyb6JbGtwlu7ks8JGgvQoVZ79lV6M4yq/YwVfZ/ov381uHw8GwHN5PbEL f0607U2XEPIsOD8/ufnNxlVyujnI5tPsHaGZFrdjyTh1TrGBYoNEoLHnZEeUbu9wkZzF 5csVQITAWFyT7+ovJfArNB78Dg7v3Aso2vV8rrYwVlTRN8rWvIHmsWjTXQXnuBrkA055 Y40mwRipUcR+7ToxNV+lNV7YeVc/saDK+b5nGNprUwDZEAvmb4rvF2dCInv1kwgniAZJ K2xA== X-Gm-Message-State: AOAM530tHo0iCUEnXQDZ5qBrWm+yu66m2qeaqpiTeIKaJgTe6q/2Cxim nkn9Vlm1z6jIeAmhJiRKy5piH4dtUcC+0CRqW4d31Q== X-Google-Smtp-Source: ABdhPJxfynR3WZQ8nDRdJcpZ8gDIlyB6mDrTNbRz5lR0hK3xPzjfX0mghrYrRkIDeKgYjOEzDHclXIp+o6ifBwzYWTc= X-Received: by 2002:a17:906:4e19:: with SMTP id z25mr3727806eju.44.1603970528162; Thu, 29 Oct 2020 04:22:08 -0700 (PDT) MIME-Version: 1.0 References: <20201026203148.47416-1-cristian.marussi@arm.com> <20201026203148.47416-2-cristian.marussi@arm.com> <20201028204416.GF20482@e120937-lin> In-Reply-To: <20201028204416.GF20482@e120937-lin> From: Etienne Carriere Date: Thu, 29 Oct 2020 12:21:56 +0100 Message-ID: Subject: Re: [PATCH v3 1/4] firmware: arm_scmi: Add Voltage Domain Support To: Cristian Marussi Cc: linux-kernel@vger.kernel.org, "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , devicetree@vger.kernel.org, Sudeep Holla , lukasz.luba@arm.com, Jim Quinlan , Jonathan.Cameron@huawei.com, broonie@kernel.org, Rob Herring , satyakim@qti.qualcomm.com, f.fainelli@gmail.com, Vincent Guittot , Souvik Chakravarty Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, 28 Oct 2020 at 21:44, Cristian Marussi wrote: > > On Wed, Oct 28, 2020 at 03:29:57PM +0100, Etienne Carriere wrote: > > Hi Cristian, > > > > Some remaining minor comments see below. > > FYI I've successfully tested this series (the 4 patches). > > > > Hi > > Thanks a lot ! > > Replies inline down below. > > [snip] > > > +struct scmi_msg_cmd_config_set { > > > + __le32 domain_id; > > > + __le32 config; > > > +}; > > > + > > > +struct scmi_msg_cmd_level_set { > > > + __le32 domain_id; > > > + __le32 flags; > > > + __le32 voltage_level; > > > +}; > > > + > > > +struct voltage_info { > > > + u32 version; > > > + u16 num_domains; > > > > Could be an unsigned int. > > > > I tend to use fixed size types matching the protocols messages sizing on > the internal while exposing non-fixed size types in scmi_protocol.h like > in scmi_voltage_info, but these indeed are values exposed directly to > the user afterwards. Any other reason to prefer non-fixed size here ? I think fixed size should be used where really needed. Since in this structure you're quite abstracted from the protocol, a generic type is preferred I think. Regards, Etienne > > > > + struct scmi_voltage_info **domains; > > > +}; > > > + > > > +static int scmi_protocol_attributes_get(const struct scmi_handle *handle, > > > + struct voltage_info *vinfo) > > > +{ > > > + int ret; > > > + struct scmi_xfer *t; > > > + struct scmi_msg_resp_protocol_attributes *resp; > > > + > > > + ret = scmi_xfer_get_init(handle, PROTOCOL_ATTRIBUTES, > > > + SCMI_PROTOCOL_VOLTAGE, 0, sizeof(*resp), &t); > > > + if (ret) > > > + return ret; > > > + > > > + resp = t->rx.buf; > > > + ret = scmi_do_xfer(handle, t); > > > + if (!ret) > > > + vinfo->num_domains = > > > + NUM_VOLTAGE_DOMAINS(le32_to_cpu(resp->attr)); > > > + > > > + scmi_xfer_put(handle, t); > > > + return ret; > > > +} > > > + > > > +static inline int scmi_init_voltage_levels(struct device *dev, > > > > Should remove this inline attribute. > > > > Ah right, I removed one and left this. I'll do. > > > > + struct scmi_voltage_info *v, > > > + u32 flags, u32 num_returned, > > > + u32 num_remaining) > > [snip] > > > > +DEFINE_SCMI_PROTOCOL_REGISTER_UNREGISTER(SCMI_PROTOCOL_VOLTAGE, voltage) > > > diff --git a/include/linux/scmi_protocol.h b/include/linux/scmi_protocol.h > > > index 9cd312a1ff92..181fdebc2793 100644 > > > --- a/include/linux/scmi_protocol.h > > > +++ b/include/linux/scmi_protocol.h > > > @@ -209,6 +209,64 @@ struct scmi_reset_ops { > > > int (*deassert)(const struct scmi_handle *handle, u32 domain); > > > }; > > > > > > +/** > > > + * struct scmi_voltage_info - describe one available SCMI Voltage Domain > > > + * > > > + * @id: the domain ID as advertised by the platform > > > + * @segmented: defines the layout of the entries of array @levels_uv. > > > + * - when True the entries are to be interpreted as triplets, > > > + * each defining a segment representing a range of equally > > > + * space voltages: , , > > > + * - when False the entries simply represent a single discrete > > > + * supported voltage level > > > + * @negative_volts_allowed: True if any of the entries of @levels_uv represent > > > + * a negative voltage. > > > + * @attributes: represents Voltage Domain advertised attributes > > > + * @name: name assigned to the Voltage Domain by platform > > > + * @num_levels: number of total entries in @levels_uv. > > > + * @levels_uv: array of entries describing the available voltage levels for > > > + * this domain. > > > + */ > > > +struct scmi_voltage_info { > > > + unsigned int id; > > > + bool segmented; > > > +#define SCMI_VOLTAGE_SEGMENT_LOW 0 > > > +#define SCMI_VOLTAGE_SEGMENT_HIGH 1 > > > +#define SCMI_VOLTAGE_SEGMENT_STEP 2 > > > > Maybe move these macros before 'int *level_us;' as these are indices > > in that array. > > > > Right, I'll do. > > Thanks > > Cristian > > > > + bool negative_volts_allowed; > > > + unsigned int attributes; > > > + char name[SCMI_MAX_STR_SIZE]; > > > + unsigned int num_levels; > > > + int *levels_uv; > > > +}; > > > + > > > +/** > > > + * struct scmi_voltage_ops - represents the various operations provided > > > + * by SCMI Voltage Protocol > > > + * > > > + * @num_domains_get: get the count of voltage domains provided by SCMI > > > + * @info_get: get the information of the specified domain > > > + * @config_set: set the config for the specified domain > > > + * @config_get: get the config of the specified domain > > > + * @level_set: set the voltage level for the specified domain > > > + * @level_get: get the voltage level of the specified domain > > > + */ > > > +struct scmi_voltage_ops { > > > + int (*num_domains_get)(const struct scmi_handle *handle); > > > + const struct scmi_voltage_info __must_check *(*info_get) > > > + (const struct scmi_handle *handle, u32 domain_id); > > > + int (*config_set)(const struct scmi_handle *handle, u32 domain_id, > > > + u32 config); > > > +#define SCMI_VOLTAGE_ARCH_STATE_OFF 0x0 > > > +#define SCMI_VOLTAGE_ARCH_STATE_ON 0x7 > > > + int (*config_get)(const struct scmi_handle *handle, u32 domain_id, > > > + u32 *config); > > > + int (*level_set)(const struct scmi_handle *handle, u32 domain_id, > > > + u32 flags, s32 volt_uV); > > > + int (*level_get)(const struct scmi_handle *handle, u32 domain_id, > > > + s32 *volt_uV); > > > +}; > > > + > > > /** > > > * struct scmi_notify_ops - represents notifications' operations provided by > > > * SCMI core > > > @@ -262,6 +320,7 @@ struct scmi_notify_ops { > > > * @clk_ops: pointer to set of clock protocol operations > > > * @sensor_ops: pointer to set of sensor protocol operations > > > * @reset_ops: pointer to set of reset protocol operations > > > + * @voltage_ops: pointer to set of voltage protocol operations > > > * @notify_ops: pointer to set of notifications related operations > > > * @perf_priv: pointer to private data structure specific to performance > > > * protocol(for internal use only) > > > @@ -273,6 +332,8 @@ struct scmi_notify_ops { > > > * protocol(for internal use only) > > > * @reset_priv: pointer to private data structure specific to reset > > > * protocol(for internal use only) > > > + * @voltage_priv: pointer to private data structure specific to voltage > > > + * protocol(for internal use only) > > > * @notify_priv: pointer to private data structure specific to notifications > > > * (for internal use only) > > > */ > > > @@ -284,6 +345,7 @@ struct scmi_handle { > > > const struct scmi_power_ops *power_ops; > > > const struct scmi_sensor_ops *sensor_ops; > > > const struct scmi_reset_ops *reset_ops; > > > + const struct scmi_voltage_ops *voltage_ops; > > > const struct scmi_notify_ops *notify_ops; > > > /* for protocol internal use */ > > > void *perf_priv; > > > @@ -291,6 +353,7 @@ struct scmi_handle { > > > void *power_priv; > > > void *sensor_priv; > > > void *reset_priv; > > > + void *voltage_priv; > > > void *notify_priv; > > > void *system_priv; > > > }; > > > @@ -303,6 +366,7 @@ enum scmi_std_protocol { > > > SCMI_PROTOCOL_CLOCK = 0x14, > > > SCMI_PROTOCOL_SENSOR = 0x15, > > > SCMI_PROTOCOL_RESET = 0x16, > > > + SCMI_PROTOCOL_VOLTAGE = 0x17, > > > }; > > > > > > enum scmi_system_events { > > > -- > > > 2.17.1 > > >