From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA07EECAAD2 for ; Mon, 29 Aug 2022 07:38:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229636AbiH2Hiz (ORCPT ); Mon, 29 Aug 2022 03:38:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56454 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229449AbiH2Hiy (ORCPT ); Mon, 29 Aug 2022 03:38:54 -0400 Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [IPv6:2a00:1450:4864:20::12c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F27004E850 for ; Mon, 29 Aug 2022 00:38:52 -0700 (PDT) Received: by mail-lf1-x12c.google.com with SMTP id z29so1400640lfb.13 for ; Mon, 29 Aug 2022 00:38:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=SLnfZ0YtBrAFrby7u2BSMdjwnYBP5EXUc9M7gwySMFc=; b=WkuVDoMnPSkj0vEifVC2w2xi1AX9POY3FSxOvaHXLrMCOqmrmhY5AfP0PutPjHEiCu a3iQ1fcGwkgc8DqpmTrkUTY0uZgwrtfZwwpxMdnA/ZgDQbe87IF6qWT5tchG9pX4HL7V 0yfmupIxlEACVzNTL7TyrLR4EavjsVUkupzOcXTRTBKe1eLU9sLAxgPqLjR2OIySU68D +jySDLepM+8q4BMNwYn/iYUMKiU5UDBG3GiAPIQQJ3ZjVmxFj6L29awQOJVX3ttZjujo 9miOIrak/NXwL1uUxotOxJ2cfOZaQTaC6FMLjCrNBCBd0fBrQGqGm6pGr9B1xlRJDNyf ECEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=SLnfZ0YtBrAFrby7u2BSMdjwnYBP5EXUc9M7gwySMFc=; b=YZmnd7wNYTXl6L1rYIvP97A2qni97SLBaWf503ouz43s1KnHufls+iNKSKYUJqV/8L h0C92bVfw+nxtqZlXeVM52qwahqZITGkjBz2XExS2fj2FuUWufMbP92G/4B2RxQxfh25 QaqwOA87sLGhx/xaVlHJSnbrQL0FM4kfQ7p6AZEfPS0lsE8HKDkjb3yLxmfW01lSonXp 7RhrEg/qHDM/W/uCFIMQrBWEsjCdeLzGojcchysZFccQ6tn41Zo28bqMfMlHL3HWRe6x hdnLZ2y1rsSmVMio7KQJouUcUeilS/fhwEMbghexk1Onb+Aw3adsyEBGB6EH3m2lHbeu gf7w== X-Gm-Message-State: ACgBeo3KdMu1Hvc0oCVS1vdOsUFc7cHx1px83YCjrxHBUHhAH6axTdZN vVZOUiXCXnHrSASf77R1opjtVJvzYhRllqvAfSMNrw== X-Google-Smtp-Source: AA6agR7Z/64kezARSma8q5qNz73IG4E3JSPDN4bXIxxADcRxsY9NxznD3iA75wQjgm9ZxrfLxirk+9UL16NI7RCfhgE= X-Received: by 2002:a05:6512:3b28:b0:494:6b56:ae0a with SMTP id f40-20020a0565123b2800b004946b56ae0amr1267119lfv.498.1661758731260; Mon, 29 Aug 2022 00:38:51 -0700 (PDT) MIME-Version: 1.0 References: <20220829062202.3287-1-zong.li@sifive.com> <20220829062202.3287-2-zong.li@sifive.com> In-Reply-To: From: Zong Li Date: Mon, 29 Aug 2022 15:38:38 +0800 Message-ID: Subject: Re: [PATCH 1/3] dt-bindings: sifive-ccache: rename SiFive L2 cache to composible cache To: Conor Dooley Cc: Rob Herring , krzysztof.kozlowski+dt@linaro.org, Palmer Dabbelt , Paul Walmsley , Albert Ou , Greentime Hu , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-riscv , "linux-kernel@vger.kernel.org List" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, Aug 29, 2022 at 2:45 PM wrote: > > Hey Zong, > Couple quick comments for you: > > On 29/08/2022 07:22, Zong Li wrote: > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > > > Since composible cache may be L3 cache if private L2 cache exists, it > > s/composible/composable > > > should use its original name composible cache to prevent confusion. > > s/composible/composable > I will fix it in each patch. > > > > Signed-off-by: Greentime Hu > > Signed-off-by: Zong Li > > --- > > .../riscv/{sifive-l2-cache.yaml => sifive-ccache.yaml} | 6 ++++-- > > 1 file changed, 4 insertions(+), 2 deletions(-) > > rename Documentation/devicetree/bindings/riscv/{sifive-l2-cache.yaml => sifive-ccache.yaml} (92%) > > > > diff --git a/Documentation/devicetree/bindings/riscv/sifive-l2-cache.yaml b/Documentation/devicetree/bindings/riscv/sifive-ccache.yaml > > similarity index 92% > > rename from Documentation/devicetree/bindings/riscv/sifive-l2-cache.yaml > > rename to Documentation/devicetree/bindings/riscv/sifive-ccache.yaml > > index 69cdab18d629..1a64a5384e36 100644 > > --- a/Documentation/devicetree/bindings/riscv/sifive-l2-cache.yaml > > +++ b/Documentation/devicetree/bindings/riscv/sifive-ccache.yaml > > Binding filenames are supposed to match the first compatible. Since > it was not named that way in the first place, I suppose naming after > the generic compatible makes the most sense. The correct filename > would then be "sifive,ccache0.yaml" > Thanks for pointing this out. Let me change the filename. > > @@ -12,8 +12,8 @@ maintainers: > > - Paul Walmsley > > > > description: > > - The SiFive Level 2 Cache Controller is used to provide access to fast copies > > - of memory for masters in a Core Complex. The Level 2 Cache Controller also > > + The SiFive Composable Cache Controller is used to provide access to fast copies > > + of memory for masters in a Core Complex. The Composable Cache Controller also > > acts as directory-based coherency manager. > > All the properties in ePAPR/DeviceTree specification applies for this platform. > > > > @@ -27,6 +27,7 @@ select: > > enum: > > - sifive,fu540-c000-ccache > > - sifive,fu740-c000-ccache > > + - sifive,ccache0 > > Despite what the commit message says, this is more than a rename. > Thanks, > Conor. > > > > > required: > > - compatible > > @@ -37,6 +38,7 @@ properties: > > - enum: > > - sifive,fu540-c000-ccache > > - sifive,fu740-c000-ccache > > + - sifive,ccache0 > > - const: cache > > > > cache-block-size: > > -- > > 2.17.1 > > >