From: Philippe Ombredanne <pombredanne@nexb.com>
To: Sricharan R <sricharan@codeaurora.org>,
Stephen Boyd <sboyd@codeaurora.org>
Cc: mturquette@linaro.org,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
viresh.kumar@linaro.org,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v4 09/12] clk: qcom: Add Krait clock controller driver
Date: Fri, 8 Dec 2017 11:23:02 +0100 [thread overview]
Message-ID: <CAOFm3uHdFn_GxJuQ-HfQpGAM5rWOT7=DyKUGtDz6dadoxdkBcw@mail.gmail.com> (raw)
In-Reply-To: <1512725401-4944-10-git-send-email-sricharan@codeaurora.org>
Sricharan, Stephen,
On Fri, Dec 8, 2017 at 10:29 AM, Sricharan R <sricharan@codeaurora.org> wrote:
> From: Stephen Boyd <sboyd@codeaurora.org>
>
> The Krait CPU clocks are made up of a primary mux and secondary
> mux for each CPU and the L2, controlled via cp15 accessors. For
> Kraits within KPSSv1 each secondary mux accepts a different aux
> source, but on KPSSv2 each secondary mux accepts the same aux
> source.
>
> Cc: <devicetree@vger.kernel.org>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
[]
> --- /dev/null
> +++ b/drivers/clk/qcom/krait-cc.c
> @@ -0,0 +1,350 @@
> +/* Copyright (c) 2013-2015, The Linux Foundation. All rights reserved.
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 and
> + * only version 2 as published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + */
Have you considered using the new SPDX ids? Something like this:
// SPDX-License-Identifier: GPL-2.0
// Copyright (c) 2013-2015, The Linux Foundation. All rights reserved.
Beside being simpler and increasing the code to comment ratio by
deleting 9 lines of boilerplate, this will also save a few trees over
the long term each time that I print the source code of the kernel ;)
(do not worry, I am NOT as insane as to really print the kernel
sources, but someone more insane than me may well do it)
You may wonder about the C++ // comment style I used here... Please
see Linus posts on the topic as well as Thomas doc patches overall for
instructions on using the SPDX ids.
And if you were to do this for your past, present and future
contributions (eventually these of your group), I would be quite
grateful.
Thank you for your kind consideration
--
Cordially
Philippe Ombredanne
next prev parent reply other threads:[~2017-12-08 10:23 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-08 9:29 [PATCH v4 00/12] Krait clocks + Krait CPUfreq Sricharan R
2017-12-08 9:29 ` [PATCH v4 01/12] ARM: Add Krait L2 register accessor functions Sricharan R
[not found] ` <1512725401-4944-1-git-send-email-sricharan-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2017-12-08 9:29 ` [PATCH v4 02/12] clk: mux: Split out register accessors for reuse Sricharan R
2017-12-08 9:29 ` [PATCH v4 10/12] clk: qcom: Add safe switch hook for krait mux clocks Sricharan R
2017-12-08 9:30 ` [PATCH v4 11/12] cpufreq: Add module to register cpufreq on Krait CPUs Sricharan R
2017-12-08 9:29 ` [PATCH v4 03/12] clk: qcom: Add support for High-Frequency PLLs (HFPLLs) Sricharan R
2017-12-08 9:29 ` [PATCH v4 04/12] clk: qcom: Add HFPLL driver Sricharan R
2017-12-08 9:29 ` [PATCH v4 05/12] clk: qcom: Add MSM8960/APQ8064's HFPLLs Sricharan R
2017-12-08 9:29 ` [PATCH v4 06/12] clk: qcom: Add IPQ806X's HFPLLs Sricharan R
2017-12-08 9:29 ` [PATCH v4 07/12] clk: qcom: Add support for Krait clocks Sricharan R
2017-12-08 9:29 ` [PATCH v4 08/12] clk: qcom: Add KPSS ACC/GCC driver Sricharan R
2017-12-08 9:29 ` [PATCH v4 09/12] clk: qcom: Add Krait clock controller driver Sricharan R
2017-12-08 10:23 ` Philippe Ombredanne [this message]
[not found] ` <CAOFm3uHdFn_GxJuQ-HfQpGAM5rWOT7=DyKUGtDz6dadoxdkBcw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-12-08 11:00 ` Sricharan R
2017-12-08 13:10 ` Philippe Ombredanne
2017-12-08 9:30 ` [PATCH v4 12/12] cpufreq: dt: Reintroduce independent_clocks platform data Sricharan R
2017-12-08 9:34 ` [PATCH v4 00/12] Krait clocks + Krait CPUfreq Sricharan R
2017-12-08 9:42 [RESEND PATCH " Sricharan R
2017-12-08 9:42 ` [PATCH v4 09/12] clk: qcom: Add Krait clock controller driver Sricharan R
2017-12-12 20:51 ` Rob Herring
2017-12-13 11:11 ` Sricharan R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOFm3uHdFn_GxJuQ-HfQpGAM5rWOT7=DyKUGtDz6dadoxdkBcw@mail.gmail.com' \
--to=pombredanne@nexb.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mturquette@linaro.org \
--cc=sboyd@codeaurora.org \
--cc=sricharan@codeaurora.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).