From mboxrd@z Thu Jan 1 00:00:00 1970 From: Philippe Ombredanne Subject: Re: [patch v14 2/4] drivers: jtag: Add Aspeed SoC 24xx and 25xx families JTAG master driver Date: Thu, 14 Dec 2017 19:14:47 +0100 Message-ID: References: <1513268971-13518-1-git-send-email-oleksandrs@mellanox.com> <1513268971-13518-3-git-send-email-oleksandrs@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <1513268971-13518-3-git-send-email-oleksandrs-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Oleksandr Shamray Cc: Greg Kroah-Hartman , Arnd Bergmann , LKML , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , OpenBMC Maillist , joel-U3u1mxZcP9KHXe+LvDLADg@public.gmane.org, =?UTF-8?B?SmnFmcOtIFDDrXJrbw==?= , Tobias Klauser , linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, vadimp-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org, system-sw-low-level-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org, Rob Herring , openocd-devel-owner-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "David S. Miller" , Mauro Carvalho Chehab , Jiri Pirko List-Id: devicetree@vger.kernel.org Oleksandr, On Thu, Dec 14, 2017 at 5:29 PM, Oleksandr Shamray wrote: > Driver adds support of Aspeed 2500/2400 series SOC JTAG master controller. > > Driver implements the following jtag ops: > - freq_get; > - freq_set; > - status_get; > - idle; > - xfer; > > It has been tested on Mellanox system with BMC equipped with > Aspeed 2520 SoC for programming CPLD devices. > > Signed-off-by: Oleksandr Shamray > Signed-off-by: Jiri Pirko > Acked-by: Arnd Bergmann > --- > v13->v14 > Comments pointed by Philippe Ombredanne > - Change style of head block comment from /**/ to // > > v12->v13 > Comments pointed by Philippe Ombredanne > - Change jtag-aspeed.c licence type to > SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note > and reorder line with license in description Thanks for the SPDX tags! for this part you have my ack: Acked-by: Philippe Ombredanne