From: Fabio Estevam <festevam@gmail.com>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: Joakim Zhang <qiangqing.zhang@nxp.com>,
Rob Herring <robh+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Sascha Hauer <kernel@pengutronix.de>,
NXP Linux Team <linux-imx@nxp.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>, Dong Aisheng <aisheng.dong@nxp.com>
Subject: Re: [PATCH] arm64: dts: imx8mp: remove fallback compatible string for FlexCAN
Date: Thu, 15 Jul 2021 09:40:15 -0300 [thread overview]
Message-ID: <CAOMZO5DJgC7LTgoYKaMxvFpg8fm89iivQbFfe3VUA0T5Hhqy=A@mail.gmail.com> (raw)
In-Reply-To: <20210715121516.pjhbjhf6htds6n65@pengutronix.de>
Hi Marc,
On Thu, Jul 15, 2021 at 9:33 AM Marc Kleine-Budde <mkl@pengutronix.de> wrote:
> > Why?
>
> Don't remember exactly why It doesn't work. I think it was a missing
> quirk that the imx6 doesn't need.
>
> > "fsl,imx8mp-flexcan" is passed as the more specific compatible string
> > and it should match against it first.
>
> ACK - but why specify the imx6 in the compatible list if the flexcan IP
> core isn't compatible with the one of the imx6?
Correct. The change in this patch looks good.
The commit log needs improvement though.
next prev parent reply other threads:[~2021-07-15 12:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-15 11:49 [PATCH] arm64: dts: imx8mp: remove fallback compatible string for FlexCAN Joakim Zhang
2021-07-15 12:03 ` Fabio Estevam
2021-07-15 12:15 ` Marc Kleine-Budde
2021-07-15 12:40 ` Fabio Estevam [this message]
2021-07-16 2:05 ` Joakim Zhang
2021-07-16 2:03 ` Joakim Zhang
2021-07-16 7:03 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOMZO5DJgC7LTgoYKaMxvFpg8fm89iivQbFfe3VUA0T5Hhqy=A@mail.gmail.com' \
--to=festevam@gmail.com \
--cc=aisheng.dong@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-imx@nxp.com \
--cc=mkl@pengutronix.de \
--cc=qiangqing.zhang@nxp.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).