From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55BE3C3F2CD for ; Wed, 4 Mar 2020 13:05:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2B7BD20870 for ; Wed, 4 Mar 2020 13:05:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Kz3ZoEts" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729386AbgCDNFb (ORCPT ); Wed, 4 Mar 2020 08:05:31 -0500 Received: from mail-vs1-f68.google.com ([209.85.217.68]:45106 "EHLO mail-vs1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729175AbgCDNFb (ORCPT ); Wed, 4 Mar 2020 08:05:31 -0500 Received: by mail-vs1-f68.google.com with SMTP id m4so1046051vsa.12 for ; Wed, 04 Mar 2020 05:05:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=y6V/ThFMEUQVv4pGKZWOlNFwrQHTHd/Cjm8+feJdCcI=; b=Kz3ZoEtsx/w9PtpTfMWI8BfIvHJpdI9eqfduNdgSwzkFoNOvf5mynamxJMQ38s1scq UG5FlR10x0pBG5V1AFPAdPmP0MOEpxBmXzWx7P7RmWNYCu4XmNn6TTtWxhX7VSYioDlK wEcFWuz1KtLJRddXeMmM++EC+8fDJOiJlgk+zDB8nWuDmYPwY4OX5/qowiZ948/V+kxU 9IUoYDeOARIZkvwXc5m99BVtXs8ZzFhifpP2vb1byNKWfJ9JZBThXmMUnc6lTfQjIsKu 167dPumst3rTtZBc9uDOXmDzBFJItYEmLl1hwTjdK/BEIWqYTDx9KTbELZK9I7NV8XN+ RenA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=y6V/ThFMEUQVv4pGKZWOlNFwrQHTHd/Cjm8+feJdCcI=; b=nn8sDv+bwjB2FLnzrfAUjgAgeLYWbGGgnM4oUZ2znXpzR/kZww9kH0oYNmuiLd/m6I vyQDvv+zES5SafaCCSUz65IiTCOdHkbObgMZ8o7Fj+eXEyaPzjWD0tUdiol2UUgDWABV dn75MyU5ukc6BwJaYF7TYZTBscPdJ223PgUNCLi/qBQMx/ecLMW5cEqzP9UuW30kB9LV EMMRcWLaSICz3C7HtIZthuhBYgLbdOV3HvnzOfJW3t/EgnrR3kv4YVsFFh9rY+QUQmYV qLK9AhgdAK8xu1rzfFuLh5cAbPQpuLIXUN9Hr3DzBYQigAZYYi98vzDN/paGZvuEWRzB dUKw== X-Gm-Message-State: ANhLgQ3GjUnfWcKmj5nvRvMR4OyDEZ+bemZQj5oHn5Q3+KoeLDtttUPI f6SNxPCzmUzALBKyZC4ZCd7yTQg947TLGqFrNYhLqA== X-Google-Smtp-Source: ADFU+vutcotJyTUK5tPrXTH7n8AgfiQgisISlV0zrVV7kZWnuc9rR3DZfocZpWM1AQk8GeUV02RcRhWp4SBgvRUJOTA= X-Received: by 2002:a67:800e:: with SMTP id b14mr1606080vsd.191.1583327129997; Wed, 04 Mar 2020 05:05:29 -0800 (PST) MIME-Version: 1.0 References: <1581922564-24914-1-git-send-email-chun-hung.wu@mediatek.com> <1581922564-24914-2-git-send-email-chun-hung.wu@mediatek.com> In-Reply-To: <1581922564-24914-2-git-send-email-chun-hung.wu@mediatek.com> From: Ulf Hansson Date: Wed, 4 Mar 2020 14:04:53 +0100 Message-ID: Subject: Re: [PATCH v3 1/4] mmc: core: expose MMC_CAP2_CQE* to dt To: Chun-Hung Wu Cc: Chaotian Jing , Rob Herring , Mark Rutland , Matthias Brugger , Linus Walleij , Pavel Machek , Kate Stewart , Greg Kroah-Hartman , Martin Blumenstingl , Pan Bian , Thomas Gleixner , Allison Randal , Mathieu Malaterre , Stanley Chu , Kuohong Wang , Android Kernel Team , Linux Kernel Mailing List , "linux-mmc@vger.kernel.org" , "moderated list:ARM/Mediatek SoC support" , DTML , wsd_upstream@mediatek.com, Linux ARM Content-Type: text/plain; charset="UTF-8" Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, 17 Feb 2020 at 07:56, Chun-Hung Wu wrote: > > Expose MMC_CAP2_CQE and MMC_CAP2_CQE_DCMD > to host->caps2 if > 1. "supports-cqe" is defined in dt and > 2. "disable-cqe-dcmd" is not defined in dt. Both of these DT properties are defined as common mmc DT properties, so the above isn't really correct. Please clarify this. Moreover, I suggest to update commit message header into "mmc: core: Extend mmc_of_parse() to parse CQE bindings", as I think it better describes the change. > > Signed-off-by: Chun-Hung Wu > --- > drivers/mmc/core/host.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/mmc/core/host.c b/drivers/mmc/core/host.c > index 105b7a7..efb0dbe 100644 > --- a/drivers/mmc/core/host.c > +++ b/drivers/mmc/core/host.c > @@ -319,6 +319,14 @@ int mmc_of_parse(struct mmc_host *host) > host->caps2 |= MMC_CAP2_NO_SD; > if (device_property_read_bool(dev, "no-mmc")) > host->caps2 |= MMC_CAP2_NO_MMC; > + if (device_property_read_bool(dev, "supports-cqe")) > + host->caps2 |= MMC_CAP2_CQE; > + > + /* Must be after "supports-cqe" check */ > + if (!device_property_read_bool(dev, "disable-cqe-dcmd")) { > + if (host->caps2 & MMC_CAP2_CQE) Does it really doesn't matter if we set this cap, even if MMC_CAP2_CQE isn't set? You can probably skip the check above. > + host->caps2 |= MMC_CAP2_CQE_DCMD; > + } > > /* Must be after "non-removable" check */ > if (device_property_read_u32(dev, "fixed-emmc-driver-type", &drv_type) == 0) { > -- > 1.9.1 Kind regards Uffe