From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60689C11F69 for ; Thu, 1 Jul 2021 16:59:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4C560613FD for ; Thu, 1 Jul 2021 16:59:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233024AbhGARBc (ORCPT ); Thu, 1 Jul 2021 13:01:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38760 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229949AbhGARBc (ORCPT ); Thu, 1 Jul 2021 13:01:32 -0400 Received: from mail-vs1-xe29.google.com (mail-vs1-xe29.google.com [IPv6:2607:f8b0:4864:20::e29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 32986C061764 for ; Thu, 1 Jul 2021 09:59:01 -0700 (PDT) Received: by mail-vs1-xe29.google.com with SMTP id c26so4196763vso.8 for ; Thu, 01 Jul 2021 09:59:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Immfemhnpfwa8Nxg8YlJJPBmhUahLWtVsprTcnwHwPk=; b=fosP1pivS/V7/7q1YVbmKOVzAiaVlm7zVcVZXe75oDTpnLQk/JKjyghVLBOJVFuoV3 HE3hPij/Y20fQDt6VeHfZvDLHTpLW3jPrwm4wyS7idrW9V4tmk++PdK8IjtEnRKXzvdZ ZlagxBpjFbDf5GySfn9hAqblBML6XGQXPxbC+gb4Z8Nrj1ae4rS+814Zk81lR2ppJFSk pRVxoVpBm2X4pnBqPLo/l8fEIxVRUJCBwumltoa5T/urpYAgqTCLy6ayZxz8lNEKiKSl d9LHZd4OC61Dj9vw3HPRsXC7mlQJi7ZD5aakDa9hqqemjxNnjj3tKs7gVaMPkHOkCkax zGiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Immfemhnpfwa8Nxg8YlJJPBmhUahLWtVsprTcnwHwPk=; b=JpVzjXB7LKqq1o0ildEL1mzk7cjtjYxlPu6+uux2yA8hov7Z/rgxWpLZJbpGNmQlaV odDcdlmjR/RQ4B6xAUyXtzzrQPPlY2W3NQYsdTNeTaC968DKHFi1+jYdgtgZoeofNAG5 1IW9o+UnMr6nSaNcEPvCjLg3ZGtuNP10VOhxhYjhG9yHVJB4ERhHYs7dVBz8yKrgdeRb /ozbB8bJXaXE+jnGnxWd8x4xXK+muvJKzspatFouVgSsoTj+FRgzxIhEOkeHcnNXIYrA 3nPHC+vlMO8tvIf+sdCaMRMeE8IO/7knuD9PTvDN6cKSrkH1bhpUQ0nWJtl8AGdDoRs7 mD5w== X-Gm-Message-State: AOAM530s6DURTNp277jFFO+oygqUo2aHN8BR+ku+HwpZnhINgwPzYWSm +yKGtx1YojNzmmWM1qHTHiMpAayASrf1WWkWhAEGDw== X-Google-Smtp-Source: ABdhPJwb80n64AujBuKAB/6m8FZX3ULekcDZrX7rK4uDzligl8QBq8854MayUQyqde2ZRzptR9AszDxPsDj/QYmH4XI= X-Received: by 2002:a05:6102:502:: with SMTP id l2mr1354578vsa.19.1625158740105; Thu, 01 Jul 2021 09:59:00 -0700 (PDT) MIME-Version: 1.0 References: <20210630133149.3204290-1-dmitry.baryshkov@linaro.org> <20210630133149.3204290-2-dmitry.baryshkov@linaro.org> In-Reply-To: From: Ulf Hansson Date: Thu, 1 Jul 2021 18:58:22 +0200 Message-ID: Subject: Re: [PATCH 1/6] dt-bindings: clock: qcom,dispcc-sm8x50: add mmcx power domain To: Dmitry Baryshkov Cc: Andy Gross , Bjorn Andersson , Rob Herring , Stephen Boyd , Taniya Das , Jonathan Marek , Michael Turquette , linux-arm-msm , DTML , linux-clk , "Bryan O'Donoghue" , Mark Brown , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, 1 Jul 2021 at 18:39, Dmitry Baryshkov wrote: > > On Thu, 1 Jul 2021 at 19:17, Ulf Hansson wrote: > > > > On Wed, 30 Jun 2021 at 15:31, Dmitry Baryshkov > > wrote: > > > > > > On sm8250 dispcc requires MMCX power domain to be powered up before > > > clock controller's registers become available. For now sm8250 was using > > > external regulator driven by the power domain to describe this > > > relationship. Switch into specifying power-domain and required opp-state > > > directly. > > > > > > Signed-off-by: Dmitry Baryshkov > > > --- > > > .../bindings/clock/qcom,dispcc-sm8x50.yaml | 19 +++++++++++++++++++ > > > 1 file changed, 19 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/clock/qcom,dispcc-sm8x50.yaml b/Documentation/devicetree/bindings/clock/qcom,dispcc-sm8x50.yaml > > > index 0cdf53f41f84..48d86fb34fa7 100644 > > > --- a/Documentation/devicetree/bindings/clock/qcom,dispcc-sm8x50.yaml > > > +++ b/Documentation/devicetree/bindings/clock/qcom,dispcc-sm8x50.yaml > > > @@ -55,6 +55,16 @@ properties: > > > reg: > > > maxItems: 1 > > > > > > + power-domains: > > > + description: > > > + A phandle and PM domain specifier for the MMCX power domain. > > > + maxItems: 1 > > > + > > > > Should you perhaps state that this is a parent domain? Or it isn't? > > > > Related to this and because this is a power domain provider, you > > should probably reference the common power-domain bindings somewhere > > here. Along the lines of this: > > > > - $ref: power-domain.yaml# > > > > As an example, you could have a look at > > Documentation/devicetree/bindings/power/pd-samsung.yaml. > > I'll take a look. > > > > > > + required-opps: > > > + description: > > > + Performance state to use for MMCX to enable register access. > > > + maxItems: 1 > > > > According to the previous discussions, I was under the assumption that > > this property belongs to a consumer node rather than in the provider > > node, no? > > It is both a consumer and a provider. It consumes SM8250_MMCX from > rpmhpd and provides MMSC_GDSC. That sounds a bit weird to me. In my view and per the common power domain bindings (as pointed to above): If a power domain provider is a consumer of another power domain, that per definition means that there is a parent domain specified. [...] Kind regards Uffe