From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65B4FC33CA0 for ; Fri, 15 Nov 2019 09:30:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3665B20733 for ; Fri, 15 Nov 2019 09:30:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="dms2AT6y" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727324AbfKOJaZ (ORCPT ); Fri, 15 Nov 2019 04:30:25 -0500 Received: from mail-ua1-f68.google.com ([209.85.222.68]:39773 "EHLO mail-ua1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727323AbfKOJaY (ORCPT ); Fri, 15 Nov 2019 04:30:24 -0500 Received: by mail-ua1-f68.google.com with SMTP id r13so2809928uan.6 for ; Fri, 15 Nov 2019 01:30:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=U0K8GRiXqSgIpN48tBNHcV+jI/oiDgvDhl7ShZIVOhE=; b=dms2AT6yjYIujdBp5vLXzT3QSWBUJdp+Ja/bHoPGCKS84bKo37q9DYAWmQ+OhvnX47 wQESQqhFjyBsKxLBW14sJM6Kkxy/Yvicy1Vttr/bmnfFi1qkmbGWwvZC6/I2T2hc0dc4 E6e4jsZ8R7HPGQj7VhbAeZXMKd4W+mV9z0NBs1wYV93Cw7drye59WzshJHguKEkNXCPt fHF0ouNrAUlgmAVwGBwpW7V1N92+w5PRrvnambZTbfMnbWUBMJIPHZCBuMz5iDZ3km48 QxwxVl+99j/KVNaPgNldx2y1f+snHTdbPP0IYzr0FUgyc31xgzkXkCrLt9Puderh1g1W O9fQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=U0K8GRiXqSgIpN48tBNHcV+jI/oiDgvDhl7ShZIVOhE=; b=qtUOmuhRBFvo8t0DYBcU3R0w5PuwRZJeyVk5a1pZe324FDqYq6Eo7jc+8SzxZIfRgP 5PSDoLUNCZA1nnAc/trwGPvhfwDhrnE3oXVRbg9wcg6tO8IP0G7+MVZFYzydGoFn1LtL YpZPQ1o99nRPbS2V2W4XkIZQcbChMHF2V1jDDfJ59qicFsflGaGGHlbFj72VvhBGMhbM QBOsb3irOdu95C0q/H3U5yTMhLV119OuRN94qbtxcz+4RmKhHFQxeQxZWX/b97qV5Oou CWwLnCiwqdLo4liWvos5zofsyJ371DTXjgmTbVRKR+pDk8m0sJJ4UErZYcYptDXQt87q 69kg== X-Gm-Message-State: APjAAAX6EQ/YgVtRNbeXt5G6jqJO4nb09XBFZI77iqI5z3UlgBpMFj7E DG9Vv9nS9tdmjLJzGm1nRlJCRQHb7MJA/9vRjfipJQ== X-Google-Smtp-Source: APXvYqzU6WJnGjb2iLphku/+v8QsaQ8unugsql39hfm0KRqoySp6l08BYKltD9R0v8e99ePYA9xvGwkzshWggfN0FEM= X-Received: by 2002:ab0:74cd:: with SMTP id f13mr8348393uaq.104.1573810223324; Fri, 15 Nov 2019 01:30:23 -0800 (PST) MIME-Version: 1.0 References: <5F5A5FC0-8F91-4D5B-9EF6-AF36FE38B588@goldelico.com> In-Reply-To: <5F5A5FC0-8F91-4D5B-9EF6-AF36FE38B588@goldelico.com> From: Ulf Hansson Date: Fri, 15 Nov 2019 10:29:46 +0100 Message-ID: Subject: Re: [PATCH v3 00/12] OpenPandora: make wl1251 connected to mmc3 sdio port of OpenPandora work again To: "H. Nikolaus Schaller" Cc: Mark Rutland , Kefeng Wang , DTML , Tony Lindgren , linux-wireless , Bjorn Helgaas , Discussions about the Letux Kernel , "Rafael J. Wysocki" , Russell King , Mike Rapoport , Yangtao Li , Kalle Valo , Petr Mladek , =?UTF-8?Q?Beno=C3=AEt_Cousson?= , kernel@pyra-handheld.com, Alexios Zavras , Rob Herring , John Stultz , David Sterba , Thomas Gleixner , linux-omap , Allison Randal , Linux ARM , Greg Kroah-Hartman , "linux-mmc@vger.kernel.org" , Linux Kernel Mailing List , Sakari Ailus , netdev Content-Type: text/plain; charset="UTF-8" Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, 14 Nov 2019 at 16:16, H. Nikolaus Schaller wrote: > > Hi Ulf, > > > Am 14.11.2019 um 15:18 schrieb Ulf Hansson : > > > > On Thu, 7 Nov 2019 at 11:31, H. Nikolaus Schaller wrote: > >> > >> > >> * add a revisit note for special wl1251 handling code because it should > >> be solved more generic in mmc core - suggested by Ulf Hansson > >> * remove init_card callback from platform_data/hsmmc-omap.h - suggested by Ulf Hansson > >> * remove obstructive always-on for vwlan regulator - suggested by Ulf Hansson > >> * rename DT node - suggested by Rob Herring > >> * fix ARM: dts: subject prefix - suggested by Tony Lindgren > >> * also remove omap2_hsmmc_info and obc-y line in Makefile - suggested by Tony Lindgren > > > > No further comments from my side. Let's just agree on how to deal with > > the ti,power-gpio, then I can apply this. > > I'd say it can be a separate patch since it does not fix the Pandora > issues, but is a new and independent optimization. > > And in case someone complains and uses it for some out-of tree purpose > it can be discussed or even be reverted easier if it is a separate patch. > > I can do it in the next days. Okay, that sounds reasonable. In the meantime, I have queued up the series on my next branch (for v5.5). I fixed up a couple of complaints from checkpatch, and also added stable tags for the first two patches in the series, as that what missing. Kind regards Uffe > > > Thanks a lot for fixing all this mess! > > I hope the users also appreciate our work. > > Best regards, > Nikolaus > > > > > Kind regards > > Uffe > > > >> > >> PATCH V2 2019-10-19 20:41:47: > >> * added acked-by for wl1251 patches - Kalle Valo > >> * really removed old pdata-quirks code (not through #if 0) > >> * splited out a partial revert of > >> efdfeb079cc3b ("regulator: fixed: Convert to use GPIO descriptor only") > >> because that was introduced after v4.19 and stops the removal of > >> the pdata-quirks patch from cleanly applying to v4.9, v4.14, v4.19 > >> - reported by Sasha Levin > >> * added a new patch to remove old omap hsmmc since pdata quirks > >> were last user - suggested by Tony Lindgren > >> > >> PATCH V1 2019-10-18 22:25:39: > >> Here we have a set of scattered patches to make the OpenPandora WiFi work again. > >> > >> v4.7 did break the pdata-quirks which made the mmc3 interface > >> fail completely, because some code now assumes device tree > >> based instantiation. > >> > >> Fixes: 81eef6ca9201 ("mmc: omap_hsmmc: Use dma_request_chan() for requesting DMA channel") > >> > >> v4.11 did break the sdio qirks for wl1251 which made the driver no longer > >> load, although the device was found as an sdio client. > >> > >> Fixes: 884f38607897 ("mmc: core: move some sdio IDs out of quirks file") > >> > >> To solve these issues: > >> * we convert mmc3 and wl1251 initialization from pdata-quirks > >> to device tree > >> * we make the wl1251 driver read properties from device tree > >> * we fix the mmc core vendor ids and quirks > >> * we fix the wl1251 (and wl1271) driver to use only vendor ids > >> from header file instead of (potentially conflicting) local > >> definitions > >> > >> > >> H. Nikolaus Schaller (12): > >> Documentation: dt: wireless: update wl1251 for sdio > >> net: wireless: ti: wl1251 add device tree support > >> ARM: dts: pandora-common: define wl1251 as child node of mmc3 > >> mmc: host: omap_hsmmc: add code for special init of wl1251 to get rid > >> of pandora_wl1251_init_card > >> omap: pdata-quirks: revert pandora specific gpiod additions > >> omap: pdata-quirks: remove openpandora quirks for mmc3 and wl1251 > >> omap: remove omap2_hsmmc_info in old hsmmc.[ch] and update Makefile > >> mmc: host: omap-hsmmc: remove init_card pdata callback from pdata > >> mmc: sdio: fix wl1251 vendor id > >> mmc: core: fix wl1251 sdio quirks > >> net: wireless: ti: wl1251 use new SDIO_VENDOR_ID_TI_WL1251 definition > >> net: wireless: ti: remove local VENDOR_ID and DEVICE_ID definitions > >> > >> .../bindings/net/wireless/ti,wl1251.txt | 26 +++ > >> arch/arm/boot/dts/omap3-pandora-common.dtsi | 36 +++- > >> arch/arm/mach-omap2/Makefile | 3 - > >> arch/arm/mach-omap2/common.h | 1 - > >> arch/arm/mach-omap2/hsmmc.c | 171 ------------------ > >> arch/arm/mach-omap2/hsmmc.h | 32 ---- > >> arch/arm/mach-omap2/pdata-quirks.c | 105 ----------- > >> drivers/mmc/core/quirks.h | 7 + > >> drivers/mmc/host/omap_hsmmc.c | 30 ++- > >> drivers/net/wireless/ti/wl1251/sdio.c | 23 ++- > >> drivers/net/wireless/ti/wlcore/sdio.c | 8 - > >> include/linux/mmc/sdio_ids.h | 2 + > >> include/linux/platform_data/hsmmc-omap.h | 3 - > >> 13 files changed, 111 insertions(+), 336 deletions(-) > >> delete mode 100644 arch/arm/mach-omap2/hsmmc.c > >> delete mode 100644 arch/arm/mach-omap2/hsmmc.h > >> > >> -- > >> 2.23.0 > >> > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel