From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 999E5C4363D for ; Mon, 5 Oct 2020 12:41:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4CB3C20674 for ; Mon, 5 Oct 2020 12:41:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="w4lwZr5a" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726057AbgJEMls (ORCPT ); Mon, 5 Oct 2020 08:41:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50928 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725963AbgJEMlr (ORCPT ); Mon, 5 Oct 2020 08:41:47 -0400 Received: from mail-vs1-xe41.google.com (mail-vs1-xe41.google.com [IPv6:2607:f8b0:4864:20::e41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8C5DCC0613CE for ; Mon, 5 Oct 2020 05:41:45 -0700 (PDT) Received: by mail-vs1-xe41.google.com with SMTP id 5so4129005vsu.5 for ; Mon, 05 Oct 2020 05:41:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=QE8OHLLcshoqgjao9rxTR2B1cn1gmKyp5nFcvuAzyYM=; b=w4lwZr5ahf5vTfr/Sla6b9a6dJJrqMnNnrGCPpE0A2wgptS0+tqhygVB/9v5pdY9tq EPJSfiiRWtTDaHXg5QxfgPtgsr6eVXsd5vY8SOM3X5IOjGHhZrbuIQXyyPKjaUX8dLa6 UIoQYFdsNUiMnVM5DsdprGSSd3qR6RJ7OMFeNT+N43JBkBWzthRqYPGIRMA6MfnhUjDG 0c+wWti7GTA7T4jaI9by9FdHpfMknlUb+dG2dUAfXt7RPnbPhVm6V1vOTEwrce449Fsz 03LBUC4NbemiPguroR9bJNjOWUXBqcX7Nrb/AGC+7ptNcprwfJQqzkoBibsti/lCJmrA tZPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QE8OHLLcshoqgjao9rxTR2B1cn1gmKyp5nFcvuAzyYM=; b=notidX1KpW9XyaI91ICAYJD5IhzUUCOJsUugbHDu708Lrm4gYBl4g+3ahlZS0+BnbI UOxyeOwOhTAshot6OAi4zi2e7l2JUJmok/SYg9DDZtwvJXAGy7KpfUnVxadoZRRRwfkl VXxUcD65ZUceuWuj44IpAdxg9NOfq7Y/AZFGFkhQSpj9sbJtGYF8G+zp0l5eepgH0yp2 nNKNce6zy0c2m584LU2AspQYXa+hoWQAt2vGwshKdLsXYw9DzonH6aMEx/3p73jW3UGd oMgxqw4Q+kB+2N+JalxSfEHWMNn95Ng0LmM3TgVPIxeAi1Cv9pSS0SUKPg/R+4xWW2n6 m6kA== X-Gm-Message-State: AOAM533jYubNCjHYSDMzDLc9JRzsVPGJv1RvsfJbLyJW40qY7YPuEPFu NITlXMRZrmhcYIFbVdNfzNih4sNu4RGXfuNY+HbqLg== X-Google-Smtp-Source: ABdhPJxW3PRcgihH+QhiZOdYzkdNBQPK1MQvkyo/5kU829snF+RDUnnYIRaeoeosnQLf5x/uy3/9W6WqD+wG+F7Wjt8= X-Received: by 2002:a67:ec9a:: with SMTP id h26mr7259024vsp.34.1601901704719; Mon, 05 Oct 2020 05:41:44 -0700 (PDT) MIME-Version: 1.0 References: <20200930083120.11971-1-wenbin.mei@mediatek.com> <20200930083120.11971-2-wenbin.mei@mediatek.com> In-Reply-To: <20200930083120.11971-2-wenbin.mei@mediatek.com> From: Ulf Hansson Date: Mon, 5 Oct 2020 14:41:08 +0200 Message-ID: Subject: Re: [PATCH v3 1/4] dt-bindings: mmc: Convert mtk-sd to json-schema To: Wenbin Mei Cc: Rob Herring , Chaotian Jing , Matthias Brugger , "linux-mmc@vger.kernel.org" , DTML , Linux ARM , "moderated list:ARM/Mediatek SoC support" , Linux Kernel Mailing List , srv_heupstream Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org [...] > diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml > new file mode 100644 > index 000000000000..7f89cbdc52a5 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml > @@ -0,0 +1,168 @@ > +# SPDX-License-Identifier: GPL-2.0 > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mmc/mtk-sd.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: MTK MSDC Storage Host Controller Binding > + > +maintainers: > + - Chaotian Jing > + - Wenbin Mei > + > +allOf: > + - $ref: mmc-controller.yaml# > + > +properties: > + compatible: > + oneOf: > + - enum: > + - mediatek,mt2701-mmc > + - mediatek,mt2712-mmc > + - mediatek,mt6779-mmc > + - mediatek,mt7620-mmc > + - mediatek,mt7622-mmc > + - mediatek,mt8135-mmc > + - mediatek,mt8173-mmc > + - mediatek,mt8183-mmc > + - mediatek,mt8516-mmc > + - items: > + - const: mediatek,mt7623-mmc > + - const: mediatek,mt2701-mmc > + > + clocks: > + description: > + Should contain phandle for the clock feeding the MMC controller. > + minItems: 2 > + maxItems: 4 > + items: > + - description: source clock (required). > + - description: HCLK which used for host (required). > + - description: independent source clock gate (required for MT2712). > + - description: bus clock used for internal register access (required for MT2712 MSDC0/3). > + > + clock-names: > + minItems: 2 > + maxItems: 4 > + items: > + - const: source > + - const: hclk > + - const: source_cg > + - const: bus_clk > + > + pinctrl-names: > + items: > + - const: default > + - const: state_uhs > + > + pinctrl-0: > + description: > + should contain default/high speed pin ctrl. > + maxItems: 1 > + > + pinctrl-1: > + description: > + should contain uhs mode pin ctrl. > + maxItems: 1 > + > + vmmc-supply: > + description: > + power to the Core. > + maxItems: 1 > + > + vqmmc-supply: > + description: > + power to the IO. > + maxItems: 1 The vmmc and vqmmc are described in the mmc-controller.yaml, so shouldn't be needed here. > + > + assigned-clocks: > + description: > + PLL of the source clock. > + maxItems: 1 > + > + assigned-clock-parents: > + description: > + parent of source clock, used for HS400 mode to get 400Mhz source clock. > + maxItems: 1 > + > + hs400-ds-delay: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: > + HS400 DS delay setting. > + minimum: 0 > + maximum: 0xffffffff > + > + mediatek,hs200-cmd-int-delay: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: > + HS200 command internal delay setting. > + This field has total 32 stages. > + The value is an integer from 0 to 31. > + minimum: 0 > + maximum: 31 > + > + mediatek,hs400-cmd-int-delay: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: > + HS400 command internal delay setting. > + This field has total 32 stages. > + The value is an integer from 0 to 31. > + minimum: 0 > + maximum: 31 > + > + mediatek,hs400-cmd-resp-sel-rising: > + $ref: /schemas/types.yaml#/definitions/flag > + description: > + HS400 command response sample selection. > + If present, HS400 command responses are sampled on rising edges. > + If not present, HS400 command responses are sampled on falling edges. > + > + mediatek,latch-ck: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: > + Some SoCs do not support enhance_rx, need set correct latch-ck to avoid > + data crc error caused by stop clock(fifo full) Valid range = [0:0x7]. > + if not present, default value is 0. > + applied to compatible "mediatek,mt2701-mmc". > + minimum: 0 > + maximum: 7 > + > + resets: > + maxItems: 1 > + > + reset-names: > + const: hrst > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - clock-names According to the current bindings, the vmmc/vqmmc supplies and the pinctrls are required as well. I assume you should add them here too!? [...] Kind regards Uffe