From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDD15C3F2D7 for ; Tue, 3 Mar 2020 20:50:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AE07A20848 for ; Tue, 3 Mar 2020 20:50:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="WQs8CSKC" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731989AbgCCUuq (ORCPT ); Tue, 3 Mar 2020 15:50:46 -0500 Received: from mail-ua1-f68.google.com ([209.85.222.68]:34819 "EHLO mail-ua1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731268AbgCCUup (ORCPT ); Tue, 3 Mar 2020 15:50:45 -0500 Received: by mail-ua1-f68.google.com with SMTP id y23so1705562ual.2 for ; Tue, 03 Mar 2020 12:50:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XD3hDQ0araAq5zv8njvI5qg6v85AS493J1Kabe5n9XU=; b=WQs8CSKCVyivgzPN2r8nm7npkTrOFE4qfJa67otUlcSCrwaKSlDrF3gGH8TEf+fF84 v/9skIV1L0DMfuSSIQZjLFKzht8F/ZGa+MgsCy08Bx+vWOgIqBpxJ/PDPdFuev8VqNyA h41lMLtPkCTJOhtkGYI7uguOfjiLVSYgoZMlkhibAvlNRLKb6mtXn/YHo9rJuDgJ+Uny i00XJnN1ZkX4aEaM8574pbADLLmr065IX3iexNFRyOCjEx8Hq1B13jzs7IFm8K61v/Oj 6ZXxP3hlFdm4pJYpgHUOC5+zIERiPT/vE9AGPanw3vpwqL5GPZDR4HF/ypGuwGF88vIc R8fQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XD3hDQ0araAq5zv8njvI5qg6v85AS493J1Kabe5n9XU=; b=KZApLBtnmEExivL/SU37s/gdycX3yWqQaHFy4o/9dwuzYO9jy8gYcaU7UtXbFGZ649 yFCG7xJ935tCqRLFK7eGLxu7pvnQ42BU38TYhs3qFRwODi7Yx4kzHg3WwqpFOioZnd4L 1ouZpHPbj55MJSGNM5P+97LzHsfevRw9vtcC6SG9HLhJi3LUoUzmeMZjCpinRR3sVzu8 c7OpdpqgrVjz66fxaWPmZQoW9FCnIxt1bJXdecXz2XRnHsuZmpApMPJYndwTrSY49OWL AoVcEGt/jqwIgvtqc27RkDgowXA54mtMQNilBCRLKlUbQjV6HszttCYuupZyZJN4DQHd Rrfw== X-Gm-Message-State: ANhLgQ0mYnv3WUmuwQnsb/T2q1ftDR6bx3nuBDo4ntFqTILhmAbeOrNv owxMsNlbrx+NaFNXJsSDYf3Fmw6h7bR21/0abBDEYw== X-Google-Smtp-Source: ADFU+vuNcnNmh6x5IJ5M2yTWp4kLMylcBxLsMM68UQIba35vDPyCmNWmxoJ2HjjVcEPSIT6lr5mW0JrpuYGpEQbi/z0= X-Received: by 2002:ab0:7802:: with SMTP id x2mr3988409uaq.100.1583268644577; Tue, 03 Mar 2020 12:50:44 -0800 (PST) MIME-Version: 1.0 References: <20200303150749.30566-1-ulf.hansson@linaro.org> <20200303150749.30566-6-ulf.hansson@linaro.org> <20200303170641.GC26191@bogus> In-Reply-To: <20200303170641.GC26191@bogus> From: Ulf Hansson Date: Tue, 3 Mar 2020 21:50:08 +0100 Message-ID: Subject: Re: [PATCH 5/7] dt-bindings: arm: Fixup the DT bindings for hierarchical PSCI states To: Rob Herring Cc: Sudeep Holla , Lorenzo Pieralisi , DTML , "Rafael J . Wysocki" , Daniel Lezcano , Lina Iyer , Stephen Boyd , Bjorn Andersson , Benjamin Gaignard , Linux ARM , Linux PM Content-Type: text/plain; charset="UTF-8" Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, 3 Mar 2020 at 18:06, Rob Herring wrote: > > On Tue, Mar 03, 2020 at 04:07:47PM +0100, Ulf Hansson wrote: > > The hierarchical topology with power-domain should be described through > > child nodes, rather than as currently described in the PSCI root node. Fix > > this by adding a patternProperties with a corresponding reference to the > > power-domain DT binding. > > > > Additionally, update the example to conform to the new pattern, but also to > > the adjusted domain-idle-state DT binding. > > > > Fixes: a3f048b5424e ("dt: psci: Update DT bindings to support hierarchical PSCI states") > > Signed-off-by: Ulf Hansson > > --- > > .../devicetree/bindings/arm/psci.yaml | 33 +++++++++---------- > > 1 file changed, 15 insertions(+), 18 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/arm/psci.yaml b/Documentation/devicetree/bindings/arm/psci.yaml > > index 0bc3c43a525a..cae668b61265 100644 > > --- a/Documentation/devicetree/bindings/arm/psci.yaml > > +++ b/Documentation/devicetree/bindings/arm/psci.yaml > > @@ -102,11 +102,15 @@ properties: > > [1] Kernel documentation - ARM idle states bindings > > Documentation/devicetree/bindings/arm/idle-states.yaml > > > > - "#power-domain-cells": > > - description: > > - The number of cells in a PM domain specifier as per binding in [3]. > > - Must be 0 as to represent a single PM domain. > > +required: > > + - compatible > > + - method > > No need to move this. Okay. > > > > > +patternProperties: > > + "^(power-controller|power-domain)([@-].*)?$": > > + $ref: "../power/power-domain.yaml#" > > This has to be under an 'allOf' or the rest of the properties are > ignored. Sure, I had the feeling that something was missing. Thanks for reviewing! [...] Looks like I should a v2 of the series, or do you prefer to apply some of the patches before I resend? Kind regards Uffe