From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86532C433EF for ; Sun, 28 Nov 2021 17:06:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1358647AbhK1RJY (ORCPT ); Sun, 28 Nov 2021 12:09:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41794 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1358488AbhK1RHY (ORCPT ); Sun, 28 Nov 2021 12:07:24 -0500 Received: from mail-vk1-xa35.google.com (mail-vk1-xa35.google.com [IPv6:2607:f8b0:4864:20::a35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 15AB0C0613F8 for ; Sun, 28 Nov 2021 09:03:17 -0800 (PST) Received: by mail-vk1-xa35.google.com with SMTP id 188so9372816vku.8 for ; Sun, 28 Nov 2021 09:03:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=BY3oht+y8HrGDIiA0mto2rflEOHEoMX+CLpzHXZf2nA=; b=isEtZ0KqXs7KwQiyrUe6920AusXIYyZ3lAycqrX8wlYMxZzrktdUryhup02VI1Fc9m 6RbwZfK5VEwmxi4UjWRmZWbt303aROEHrxkJJaNuODRMse9Ohe1/XfcUA2kKvpqE/UhR RbvvxfS7z6qb3X5YjlkfRE/T60Xju+cO7p9YyQj6EXdMEqvWjpSSGjY7+8CraHpfL2aA ffanPd/1CCgvM5Qlb7yHtQ4jsRvgFbvogD1YtoQrtwx8TwfczmVqEphgtQg/Mw4op13n xhf2K4LG1zddQ8cTqaUD7GGqrYRoeY6Irx5UZc4QfFAbdWaoCrgQ8/GT2dQ3C6PBrKqL g4bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BY3oht+y8HrGDIiA0mto2rflEOHEoMX+CLpzHXZf2nA=; b=3MvevtJnbemW3RvGucKa2jtiCR9gQcIg4McivkK8GapFFkHSATsyzaePTpxTn+yucf wmOl1aH8wPSxj+bYZ3rYYOhKx4fz9c0RI4ZuVR3RDJ2XFpDZIW2o0OB5SePfSJjaaKVO ejwRnHENigSUUiHUjxlCC00HUQ6Zb5CMvspJf5lB4BRStA32w8XDiZnQ3LxfXRZ5V15+ TJZ9drB3nW6g6gvFPsE4/l5i8esU0EwgyIJpdH1vrC4vsB5mzEFx0/D+jktFMhkaizNO ovyr4NCEeH1KO99Hr80zQN4bC+QFDSOMgiAr2zl7lj5N6GPRJ/UlIsTUf7ApZK8S/i9z RWIQ== X-Gm-Message-State: AOAM5328HAHUt+j6Ew9vJBCTNfXoKswt2KyMuCBWSuyOByJXvdFStGEC A3T1Kaj7Z2MYm0eTS/0fJiLrp69vPT8pvlQH2Oav6g== X-Google-Smtp-Source: ABdhPJzWijuBwUQuP+Vndk1T+sepX2T8/WmWaWQfnWsOR0CMc9FuYs9zuujxjQxRb2Guzz9nNOvUpGArHq0GRwbXUxw= X-Received: by 2002:a1f:2849:: with SMTP id o70mr25716022vko.35.1638118996213; Sun, 28 Nov 2021 09:03:16 -0800 (PST) MIME-Version: 1.0 References: <20211127223253.19098-1-semen.protsenko@linaro.org> <20211127223253.19098-5-semen.protsenko@linaro.org> In-Reply-To: From: Sam Protsenko Date: Sun, 28 Nov 2021 19:03:05 +0200 Message-ID: Subject: Re: [PATCH 4/8] tty: serial: samsung: Remove USI initialization To: Greg Kroah-Hartman Cc: Krzysztof Kozlowski , Rob Herring , Mark Brown , Jaewon Kim , Chanho Park , David Virag , Youngmin Nam , devicetree@vger.kernel.org, linux-spi@vger.kernel.org, linux-serial@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-i2c@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Sun, 28 Nov 2021 at 18:26, Sam Protsenko wrote: > > On Sun, 28 Nov 2021 at 16:28, Greg Kroah-Hartman > wrote: > > > > On Sun, Nov 28, 2021 at 12:32:49AM +0200, Sam Protsenko wrote: > > > USI control is now extracted to dedicated USIv2 driver. Remove USI > > > related code from serial driver to avoid conflicts and code duplication. > > > > What conflicts? > > > > There might be possible conflicts when accessing the same USI register > from both serial driver and USIv2 driver. Also there will be conflicts > when trying to access the same I/O address space in those both > drivers. > > > What duplication? All you did here was delete code. > > > > It's all explained in [PATCH 0/8], but long story short, I've added > USIv2 driver (in this series) which handles the code that's removed > from serial driver in this patch. > In other words, this code is now present here: [1]. But of course USIv2 driver must be applied first, and then this patch (removing the same code from serial driver). That's why it's in the same series and it's placed after USIv2 driver ([PATCH 3/8]). [1] https://patchwork.kernel.org/project/linux-samsung-soc/patch/20211127223253.19098-4-semen.protsenko@linaro.org/ > > confused, > > > > greg k-h