From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14377C433EF for ; Tue, 4 Jan 2022 11:49:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232631AbiADLtm (ORCPT ); Tue, 4 Jan 2022 06:49:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45328 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232707AbiADLtj (ORCPT ); Tue, 4 Jan 2022 06:49:39 -0500 Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9CDFDC061761 for ; Tue, 4 Jan 2022 03:49:37 -0800 (PST) Received: by mail-wr1-x431.google.com with SMTP id q16so75653640wrg.7 for ; Tue, 04 Jan 2022 03:49:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PiTilpP3Bz7ZjAJItTFQ1+Dz34boNVjYl6oKFRhtc0Q=; b=cOMhcn1J5UlEZAXKJ/boZKiXhSdYW0iQdmir3Lf7e0SFW9q/l+RopOiaiLZ/S0Alxs gEf633aU3NlLjANWptKdh4co9gtW5bF+hEjxr7b/A9+qun1msWjq4PeGV2Wpr5Yw83mP 3dXiGu4MIgvfFTLT5oQsPtt3H1t+J6qvx07neFri5llTtxTZvWUQC7Y+nlFp1FjsOAYd STouFIXVzVy+PyihnanDhLKrpte0VGecj5I9mst+uIx7x20aGroXzQS3XAik6pZlS7jC NTrezHR88ebJQRr5Yzt2Qs1YoGPBInj/oRHX3gdepplon5JQqrjw510KCaQ+v7g99dCq Mhiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PiTilpP3Bz7ZjAJItTFQ1+Dz34boNVjYl6oKFRhtc0Q=; b=y9FC6PxDzStyYd1r153k3784Eq4TUlIoa0eQYn7LYGKsD7A5RfCnV0LlslfK/flYVm PYKAj5xM+2ImgWwXzd5J+9g7D5uymirRJB1MIHQkh7hgnyrS2dlHuubL09HrBt3tj0nG a0scED4Uh/qaIASLWkvF5QrsjG7efj1jKX6AdP1hGfsSnEWzvNReis3khBxe1IGFVKOI FpxTgLF699MzMn7oy7EPPRA1FHw8maUzlQHN9fPugbHSm36And5qxegTP1d0/7PK4h96 FQuzT3RE0SD6hfHiAS3VY9uBBIXNkP5RKEnjSZByapn9haTaoVwTfp9hjP7Krsgxftzc 1Nnw== X-Gm-Message-State: AOAM531z2Ws1FZeG+bdomrHMA27diDeDuJSYpzxG0vJTjZv3uaTUEfpP or3YBwTY0NxHWecQ2UokCFTpdlbrwweIOUfNo7OOBA== X-Google-Smtp-Source: ABdhPJyzYo76mmymNn/EFfKFV7mnbuF4LgFaafKZxybUkpDr4UVPBcKKdYvt9QGRf/C/CTigqQ5SvaZ4CjZx+Ig5Kn0= X-Received: by 2002:a5d:58f6:: with SMTP id f22mr41092618wrd.638.1641296976219; Tue, 04 Jan 2022 03:49:36 -0800 (PST) MIME-Version: 1.0 References: <20220103174106.907-1-macroalpha82@gmail.com> <20220103174106.907-6-macroalpha82@gmail.com> In-Reply-To: <20220103174106.907-6-macroalpha82@gmail.com> From: Dave Stevenson Date: Tue, 4 Jan 2022 11:49:23 +0000 Message-ID: Subject: Re: [PATCH 5/5] drm/vc4: dpi: Support DPI interface in mode3 for RGB565 To: Chris Morgan Cc: DRI Development , devicetree@vger.kernel.org, Thierry Reding , Sam Ravnborg , David Airlie , Daniel Vetter , Rob Herring , Mauro Carvalho Chehab , Eric Anholt , Maxime Ripard , Linux Media Mailing List , Chris Morgan Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Chris Thanks for the patch. On Mon, 3 Jan 2022 at 17:41, Chris Morgan wrote: > > From: Chris Morgan > > Add support for the VC4 DPI driver to utilize DPI mode 3. This is > defined here as xxxRRRRRxxGGGGGGxxxBBBBB: > > https://www.raspberrypi.com/documentation/computers/raspberry-pi.html#parallel-display-interface-dpi > > This mode is required to use the Geekworm MZP280 DPI display. > > Signed-off-by: Chris Morgan Reviewed-by: Dave Stevenson The other patches all look valid to me, but I'll leave those for the more experienced maintainers. Dave > --- > drivers/gpu/drm/vc4/vc4_dpi.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/vc4/vc4_dpi.c b/drivers/gpu/drm/vc4/vc4_dpi.c > index c180eb60bee8..3c58ade2549e 100644 > --- a/drivers/gpu/drm/vc4/vc4_dpi.c > +++ b/drivers/gpu/drm/vc4/vc4_dpi.c > @@ -173,6 +173,10 @@ static void vc4_dpi_encoder_enable(struct drm_encoder *encoder) > dpi_c |= VC4_SET_FIELD(DPI_FORMAT_16BIT_565_RGB_3, > DPI_FORMAT); > break; > + case MEDIA_BUS_FMT_RGB565_1X24_CPADHI: > + dpi_c |= VC4_SET_FIELD(DPI_FORMAT_16BIT_565_RGB_2, > + DPI_FORMAT); > + break; > default: > DRM_ERROR("Unknown media bus format %d\n", bus_format); > break; > -- > 2.25.1 >