From: Dave Stevenson <dave.stevenson@raspberrypi.com>
To: Marek Vasut <marex@denx.de>
Cc: Rob Herring <robh+dt@kernel.org>,
DRI Development <dri-devel@lists.freedesktop.org>,
devicetree@vger.kernel.org, Sam Ravnborg <sam@ravnborg.org>
Subject: Re: [PATCH V3 1/2] dt-bindings: Add DT bindings for Toshiba TC358762 DSI-to-DPI bridge
Date: Thu, 3 Dec 2020 18:01:26 +0000 [thread overview]
Message-ID: <CAPY8ntBCsDF+D8EiSrDJ8vn_S6-OGr6p4SMd7_9MHvoFj=f+Fw@mail.gmail.com> (raw)
In-Reply-To: <20200812200738.GA651402@ravnborg.org>
Hi Marek
On Wed, 12 Aug 2020 at 21:07, Sam Ravnborg <sam@ravnborg.org> wrote:
>
> Hi Marek.
>
> On Sun, Aug 09, 2020 at 12:57:04PM +0200, Marek Vasut wrote:
> > Add DT bindings for Toshiba TC358762 DSI-to-DPI bridge, this
> > one is used in the Raspberry Pi 7" touchscreen display unit.
> >
> > Signed-off-by: Marek Vasut <marex@denx.de>
> > To: dri-devel@lists.freedesktop.org
> > Cc: Eric Anholt <eric@anholt.net>
> > Cc: Rob Herring <robh+dt@kernel.org>
> > Cc: Sam Ravnborg <sam@ravnborg.org>
> > Cc: devicetree@vger.kernel.org
> > ---
> > V2: Fix dt_binding_check errors
> > V3: Add ... at the end of example
>
> With Rob's r-b it is now applied to drm-misc-next.
>
> Sam
>
> > ---
> > .../display/bridge/toshiba,tc358762.yaml | 127 ++++++++++++++++++
> > 1 file changed, 127 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/display/bridge/toshiba,tc358762.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358762.yaml b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358762.yaml
> > new file mode 100644
> > index 000000000000..195025e6803c
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358762.yaml
> > @@ -0,0 +1,127 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/display/bridge/toshiba,tc358762.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Toshiba TC358762 MIPI DSI to MIPI DPI bridge
> > +
> > +maintainers:
> > + - Marek Vasut <marex@denx.de>
> > +
> > +description: |
> > + The TC358762 is bridge device which converts MIPI DSI to MIPI DPI.
> > +
> > +properties:
> > + compatible:
> > + enum:
> > + - toshiba,tc358762
> > +
> > + reg:
> > + maxItems: 1
> > + description: virtual channel number of a DSI peripheral
> > +
> > + vddc-supply:
> > + description: Regulator for 1.2V internal core power.
> > +
> > + ports:
> > + type: object
> > +
> > + properties:
> > + "#address-cells":
> > + const: 1
> > +
> > + "#size-cells":
> > + const: 0
> > +
> > + port@0:
> > + type: object
> > + additionalProperties: false
> > +
> > + description: |
> > + Video port for MIPI DSI input
> > +
> > + properties:
> > + reg:
> > + const: 0
> > +
> > + patternProperties:
> > + endpoint:
> > + type: object
> > + additionalProperties: false
> > +
> > + properties:
> > + remote-endpoint: true
> > +
> > + required:
> > + - reg
> > +
> > + port@1:
> > + type: object
> > + additionalProperties: false
> > +
> > + description: |
> > + Video port for MIPI DPI output (panel or connector).
> > +
> > + properties:
> > + reg:
> > + const: 1
> > +
> > + patternProperties:
> > + endpoint:
> > + type: object
> > + additionalProperties: false
> > +
> > + properties:
> > + remote-endpoint: true
> > +
> > + required:
> > + - reg
> > +
> > + required:
> > + - "#address-cells"
> > + - "#size-cells"
> > + - port@0
> > + - port@1
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - vddc-supply
> > + - ports
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
> > + i2c1 {
Minor point.
I've just come to use this and noticed that this example puts the
device under i2c1. Seeing as it's a DSI driver with no I2C
interaction, shouldn't it be under a dsi node?
Thanks
Dave
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + bridge@0 {
> > + reg = <0>;
> > + compatible = "toshiba,tc358762";
> > + vddc-supply = <&vcc_1v2_reg>;
> > +
> > + ports {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + port@0 {
> > + reg = <0>;
> > + bridge_in: endpoint {
> > + remote-endpoint = <&dsi_out>;
> > + };
> > + };
> > +
> > + port@1 {
> > + reg = <1>;
> > + bridge_out: endpoint {
> > + remote-endpoint = <&panel_in>;
> > + };
> > + };
> > + };
> > + };
> > + };
> > +
> > +...
> > --
> > 2.28.0
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-12-03 18:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-09 10:57 [PATCH V3 1/2] dt-bindings: Add DT bindings for Toshiba TC358762 DSI-to-DPI bridge Marek Vasut
2020-08-09 10:57 ` [PATCH V3 2/2] drm/bridge: tc358762: Add basic driver " Marek Vasut
2020-08-12 20:08 ` Sam Ravnborg
2020-08-12 19:48 ` [PATCH V3 1/2] dt-bindings: Add DT bindings " Rob Herring
2020-08-12 20:07 ` Sam Ravnborg
2020-12-03 18:01 ` Dave Stevenson [this message]
2020-12-03 18:09 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPY8ntBCsDF+D8EiSrDJ8vn_S6-OGr6p4SMd7_9MHvoFj=f+Fw@mail.gmail.com' \
--to=dave.stevenson@raspberrypi.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=marex@denx.de \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).