From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4814C41604 for ; Tue, 6 Oct 2020 06:30:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 710C620853 for ; Tue, 6 Oct 2020 06:30:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=antmicro.com header.i=@antmicro.com header.b="Aewfvkp8" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727075AbgJFGai (ORCPT ); Tue, 6 Oct 2020 02:30:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46434 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727022AbgJFGah (ORCPT ); Tue, 6 Oct 2020 02:30:37 -0400 Received: from mail-pg1-x544.google.com (mail-pg1-x544.google.com [IPv6:2607:f8b0:4864:20::544]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B9D5C0613A7 for ; Mon, 5 Oct 2020 23:30:37 -0700 (PDT) Received: by mail-pg1-x544.google.com with SMTP id h6so6745405pgk.4 for ; Mon, 05 Oct 2020 23:30:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=antmicro.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jEZ/PphhBcpGSudk4zYqpeTRIANvOFR8+5eTx3w3Oj8=; b=Aewfvkp8uF0ztDFZgaN+wNHZ+BrMN8FsafukdvDenr6aOGB0e523o+WcBp0c95lwqP +KPJHrPDL9qUrMzBjOQKC9ReWS8jiHu/ayJ2mu2F5N6qFnnrUe9OAiReWQM9kUzbjGBe iX7nl0CIrnIwIhR8ELaSSk/Hhj2FEyP4Z2Q/g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jEZ/PphhBcpGSudk4zYqpeTRIANvOFR8+5eTx3w3Oj8=; b=Dr2T7agWgf/TDgSrWNchT9Vl/pkhvgBCNot1aR+mC1/OBJHJhGvQlcHaIQMFqffXiB IO+uXGMbYgqbIlWI/VwBVoAlZKRhVZs6hh/sk+YYB5dSSVQzOh5PTeJEbUoWcPANio0L rr2UxzG5CL9EgOqtikaEMAQKr1ZPwoIj289K60Xzzv/oxqtOjnAS1IppTRogoTM2iZh4 R751adzMC4XC8linyIuRFH/R2bbl1Kj0odrExxfI4UjluRzBgpN3MyZK7gVY6yeRpMKV 6u8CxxPuoW8FNDjLRbYrjZjqUewWdM7Bl5ZDwGBc0TrNyPmmpt9WY0ECDwhN/DQUp1DA 8E6w== X-Gm-Message-State: AOAM533BQOAuocQ1dXTHigHP6g4h0FWoxwLWLWeLU7qbjHCJrRUDfDHB 9yVrp5CKLNZtaiB78eR0L8AfxhXOFa9WUPxhwrJNAQ== X-Google-Smtp-Source: ABdhPJzyGjwFiX82SqSnhgwuVLIPB0qX8/w2uOnQTTNNakJGClvpNe5x6G6gWDIyv8uvQNMjCiPMVzXhFa0JwutgfSw= X-Received: by 2002:a63:1a21:: with SMTP id a33mr2837088pga.305.1601965836782; Mon, 05 Oct 2020 23:30:36 -0700 (PDT) MIME-Version: 1.0 References: <20200923120817.1667149-0-mholenko@antmicro.com> <20200923120817.1667149-2-mholenko@antmicro.com> In-Reply-To: From: Mateusz Holenko Date: Tue, 6 Oct 2020 08:30:24 +0200 Message-ID: Subject: Re: [PATCH v11 2/5] dt-bindings: soc: document LiteX SoC Controller bindings To: Geert Uytterhoeven Cc: Rob Herring , Mark Rutland , Greg Kroah-Hartman , Jiri Slaby , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "open list:SERIAL DRIVERS" , Stafford Horne , Karol Gugala , Mauro Carvalho Chehab , "David S. Miller" , "Paul E. McKenney" , Filip Kokosinski , Pawel Czarnecki , Joel Stanley , Jonathan Cameron , Maxime Ripard , Shawn Guo , Heiko Stuebner , Sam Ravnborg , Icenowy Zheng , Laurent Pinchart , Linux Kernel Mailing List , "Gabriel L. Somlo" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Geert, On Fri, Sep 25, 2020 at 2:48 PM Geert Uytterhoeven wrote: > > Hi Mateusz, > > On Wed, Sep 23, 2020 at 12:09 PM Mateusz Holenko wrote: > > From: Pawel Czarnecki > > > > Add documentation for LiteX SoC Controller bindings. > > > > Signed-off-by: Pawel Czarnecki > > Signed-off-by: Mateusz Holenko > > Reviewed-by: Rob Herring > > Thanks for your patch! Thanks for your comments! > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/soc/litex/litex,soc-controller.yaml > > @@ -0,0 +1,39 @@ > > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > > +# Copyright 2020 Antmicro > > +%YAML 1.2 > > +--- > > +$id: "http://devicetree.org/schemas/soc/litex/litex,soc-controller.yaml#" > > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > > + > > +title: LiteX SoC Controller driver > > + > > +description: | > > + This is the SoC Controller driver for the LiteX SoC Builder. > > + It's purpose is to verify LiteX CSR (Control&Status Register) access > > Its > > > + operations and provide function for other drivers to read/write CSRs > > functions > > > + and to check if those accessors are ready to use. > > be used I will fix the description as suggested. > > + > > +maintainers: > > + - Karol Gugala > > + - Mateusz Holenko > > + > > +properties: > > + compatible: > > + const: litex,soc-controller > > + > > + reg: > > + maxItems: 1 > > + > > +required: > > + - compatible > > + - reg > > + > > +examples: > > + - | > > + soc_ctrl0: soc-controller@f0000000 { > > + compatible = "litex,soc-controller"; > > + reg = <0xf0000000 0xC>; > > Please be consistent w.r.t. lower/upper case: "0xc". Sure, I will use lowercase everywhere. > > + status = "okay"; > > + }; > > Gr{oetje,eeting}s, > > Geert > > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds Best regards, Mateusz -- Mateusz Holenko Antmicro Ltd | www.antmicro.com Roosevelta 22, 60-829 Poznan, Poland