From: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
To: Adam Ford <aford173@gmail.com>, "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
Cc: "Rob Herring" <robh+dt@kernel.org>,
"Shawn Guo" <shawnguo@kernel.org>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Sascha Hauer" <kernel@pengutronix.de>,
"Fabio Estevam" <festevam@gmail.com>,
dl-linux-imx <linux-imx@nxp.com>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
"Lucas Stach" <l.stach@pengutronix.de>,
"Krzysztof Kozlowski" <krzk@kernel.org>,
"Guido Günther" <agx@sigxcpu.org>, "Marek Vasut" <marex@denx.de>,
"Andrey Smirnov" <andrew.smirnov@gmail.com>,
devicetree <devicetree@vger.kernel.org>,
arm-soc <linux-arm-kernel@lists.infradead.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Jacky Bai" <ping.bai@nxp.com>,
"Schrempf Frieder" <frieder.schrempf@kontron.de>,
"Abel Vesa" <abel.vesa@nxp.com>,
"Jagan Teki" <jagan@amarulasolutions.com>
Subject: RE: [PATCH V8 0/4] soc: imx: add i.MX BLK-CTL support
Date: Wed, 30 Jun 2021 09:34:19 +0000 [thread overview]
Message-ID: <DB6PR0402MB2760B05081D54D775B8949CA88019@DB6PR0402MB2760.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <CAHCN7xJgqRfg1sHNbcpdEFaLHUwhYxe7_r5SEMDqSaCPFXX7UQ@mail.gmail.com>
> Subject: Re: [PATCH V8 0/4] soc: imx: add i.MX BLK-CTL support
>
> On Tue, Jun 29, 2021 at 1:56 AM Peng Fan (OSS) <peng.fan@oss.nxp.com>
> wrote:
> >
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > V8:
> > Revert one change in v7, force goto disable_clk for handshake when
> > power on in patch 3 One minor update to use if{} else {}, not if{};
> > if{}; in patch 3 Typo Hankshake->Handshake
> >
> I am using ATF, branch lf_v2.4, from the NXP code aurora repo with U-Boot
> v2021.07-rc5
>
> I applied this patch against linux-next, I applied the pgc patches [1], and the
> suggested power-domains to the otg1 and otg2 nodes.
> I am able to boot the device and use USB, but with this applied, I cannot wake
> from sleep. If I revert this, the system wakes from sleep again.
I just tried linux-next without this patch on iMX8MM EVK, suspend/resume
not work. Per my last test, it works before. Not sure what changed in kernel.
Which kernel are you using, any commit or git repo? I could try on imx8mm
evk and debug the issue you see.
Thanks,
Peng.
>
> [1] -
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatch
> work.kernel.org%2Fproject%2Flinux-arm-kernel%2Fpatch%2F202106041110
> 05.6804-1-peng.fan%40oss.nxp.com%2F&data=04%7C01%7Cpeng.fan%
> 40nxp.com%7Caccded5458c049d67fa308d93b0182d9%7C686ea1d3bc2b4c6
> fa92cd99c5c301635%7C0%7C0%7C637605699944911752%7CUnknown%7C
> TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiL
> CJXVCI6Mn0%3D%7C1000&sdata=Kf6orRXmScWHDTgD2FOV8OBsgG0p
> GVs1byVZTHT0gVI%3D&reserved=0
>
> I have not enabled video, GPU, VPU nor CSI.
>
> Just in case there might be a power-domain dependency missing, here is my
> power-domain dump:
>
> root@beacon-imx8mm-kit:~# cat
> /sys/kernel/debug/pm_genpd/pm_genpd_summary
> domain status children
> performance
> /device runtime
> status
> ---------------------------------------------------------------------------------------------
> -
> vpu-h1 off-0
> 0
>
> VPU_BLK_CTL_H1
> /devices/genpd:3:imx-vpumix-blk-ctl.2 suspended
> 0
> vpu-g2 off-0
> 0
>
> VPU_BLK_CTL_G2
> /devices/genpd:2:imx-vpumix-blk-ctl.0 suspended
> 0
> vpu-g1 off-0
> 0
>
> VPU_BLK_CTL_G1
> /devices/genpd:1:imx-vpumix-blk-ctl.1 suspended
> 0
> mipi off-0
> 0
> MIPI_DSI,
> MIPI_CSI
> /devices/genpd:1:imx-dispmix-blk-ctl.2 suspended
> 0
> /devices/genpd:1:imx-dispmix-blk-ctl.3 suspended
> 0
> vpumix off-0
> 0
>
> VPU_BLK_CTL_BUS
> /devices/genpd:0:imx-vpumix-blk-ctl.3 suspended
> 0
> gpu off-0
> 0
> VPU_BLK_CTL_BUS off-0
> 0
>
> /devices/platform/soc@0/30000000.bus/303a0000.gpc/imx-pgc-domain.7
> suspended 0
>
> /devices/platform/soc@0/30000000.bus/303a0000.gpc/imx-pgc-domain.8
> suspended 0
>
> /devices/platform/soc@0/30000000.bus/303a0000.gpc/imx-pgc-domain.9
> suspended 0
> VPU_BLK_CTL_H1 off-0
> 0
> VPU_BLK_CTL_G1 off-0
> 0
> VPU_BLK_CTL_G2 off-0
> 0
> DISPMIX_BUS off-0
> 0
> CSI_BRIDGE,
> LCDIF
>
> /devices/platform/soc@0/30000000.bus/303a0000.gpc/imx-pgc-domain.11
> suspended 0
> MIPI_CSI off-0
> 0
> MIPI_DSI off-0
> 0
> LCDIF off-0
> 0
> CSI_BRIDGE off-0
> 0
> dispmix off-0
> 0
> DISPMIX_BUS
> /devices/genpd:0:imx-dispmix-blk-ctl.4 suspended
> 0
> gpumix off-0
> 0
>
> /devices/platform/soc@0/30000000.bus/303a0000.gpc/imx-pgc-domain.5
> suspended 0
> usb-otg2 on
> 0
> /devices/platform/soc@0/32c00000.bus/32e50000.usb active
> 0
> usb-otg1 on
> 0
> /devices/platform/soc@0/32c00000.bus/32e40000.usb active
> 0
> pcie off-0
> 0
> hsiomix on
> 0
>
> /devices/platform/soc@0/30000000.bus/303a0000.gpc/imx-pgc-domain.1
> suspended 0
>
> /devices/platform/soc@0/30000000.bus/303a0000.gpc/imx-pgc-domain.2
> active 0
>
> /devices/platform/soc@0/30000000.bus/303a0000.gpc/imx-pgc-domain.3
> active 0
>
>
>
> > V7:
> > patch 2: update patch title per Shawn Patch 3: Addressed several
> > comments from Shawn
> >
> > V6:
> > Thanks for Adam's report on V5.
> > Resolve the error message dump, it is the child device reuse the
> > parent device node and matches the parent driver.
> > Filled the remove function for child device.
> > A diff dts file for upstream:
> >
> > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgist
> > .github.com%2FMrVan%2Fd73888d8273c43ea4a3b28fa668ca1d0&dat
> a=04%7C0
> >
> 1%7Cpeng.fan%40nxp.com%7Caccded5458c049d67fa308d93b0182d9%7C68
> 6ea1d3bc
> >
> 2b4c6fa92cd99c5c301635%7C0%7C0%7C637605699944911752%7CUnknow
> n%7CTWFpbG
> >
> Zsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6
> Mn0%
> >
> 3D%7C1000&sdata=9FcnPd4nwmdjOqrQCTz0YNgUmVQ9UzTHpfh33LKI
> 7cs%3D&
> > ;reserved=0
> >
> > V5:
> > Rework the blk-ctl driver to let sub-PGC use blk-ctl as parent power
> > domain to fix the potential handshake issue.
> > I still keep R-b/A-b tag for Patch 1,2,4, since very minor changes I
> > only drop R-b tag for Patch 3, since it has big change.
> > An example, the pgc_mipi not take pgc_dispmix as parent:
> >
> > pgc_dispmix: power-domain@10 {
> > #power-domain-cells = <0>;
> > reg = <IMX8MM_POWER_DOMAIN_DISPMIX>;
> > clocks = <&clk IMX8MM_CLK_DISP_ROOT>,
> > <&clk IMX8MM_CLK_DISP_AXI_ROOT>,
> > <&clk IMX8MM_CLK_DISP_APB_ROOT>;
> > };
> >
> > pgc_mipi: power-domain@11 {
> > #power-domain-cells = <0>;
> > reg = <IMX8MM_POWER_DOMAIN_MIPI>;
> > power-domains = <&dispmix_blk_ctl
> IMX8MM_BLK_CTL_PD_DISPMIX_BUS>;
> > };
> >
> > dispmix_blk_ctl: clock-controller@32e28000 {
> > compatible = "fsl,imx8mm-dispmix-blk-ctl", "syscon";
> > reg = <0x32e28000 0x100>;
> > #power-domain-cells = <1>;
> > power-domains = <&pgc_dispmix>, <&pgc_mipi>;
> > power-domain-names = "dispmix", "mipi";
> > clocks = <&clk IMX8MM_CLK_DISP_ROOT>, <&clk
> IMX8MM_CLK_DISP_AXI_ROOT>,
> > <&clk IMX8MM_CLK_DISP_APB_ROOT>;
> > };
> >
> > V4:
> > Add R-b tag
> > Typo fix
> > Update the power domain macro names Per Abel and Frieder
> >
> > V3:
> > Add explaination for not listing items in patch 2 commit log Per Rob.
> > Addressed comments from Lucas and Frieder on patch [3,4].
> > A few comments from Jacky was ignored, because following gpcv2
> > coding style.
> >
> > V2:
> > Fix yaml check failure.
> >
> > Previously there is an effort from Abel that take BLK-CTL as clock
> > provider, but it turns out that there is A/B lock issue and we are not
> > able resolve that.
> >
> > Per discuss with Lucas and Jacky, we made an agreement that take
> > BLK-CTL as a power domain provider and use GPC's domain as parent, the
> > consumer node take BLK-CTL as power domain input.
> >
> > This patchset has been tested on i.MX8MM EVK board, but one hack is
> > not included in the patchset is that the DISPMIX BLK-CTL
> > MIPI_M/S_RESET not implemented. Per Lucas, we will finally have a MIPI
> > DPHY driver, so fine to leave it.
> >
> > Thanks for Lucas's suggestion, Frieder Schrempf for collecting all the
> > patches, Abel's previous BLK-CTL work, Jacky Bai on help debug issues.
> >
> >
> > Peng Fan (4):
> > dt-bindings: power: Add defines for i.MX8MM BLK-CTL power domains
> > dt-bindings: soc: imx: Add bindings for i.MX BLK_CTL
> > soc: imx: Add generic blk-ctl driver
> > soc: imx: Add blk-ctl driver for i.MX8MM
> >
> > .../bindings/soc/imx/fsl,imx-blk-ctl.yaml | 66 ++++
> > drivers/soc/imx/Makefile | 2 +-
> > drivers/soc/imx/blk-ctl-imx8mm.c | 139 ++++++++
> > drivers/soc/imx/blk-ctl.c | 324
> ++++++++++++++++++
> > drivers/soc/imx/blk-ctl.h | 85 +++++
> > include/dt-bindings/power/imx8mm-power.h | 13 +
> > 6 files changed, 628 insertions(+), 1 deletion(-) create mode 100644
> > Documentation/devicetree/bindings/soc/imx/fsl,imx-blk-ctl.yaml
> > create mode 100644 drivers/soc/imx/blk-ctl-imx8mm.c create mode
> > 100644 drivers/soc/imx/blk-ctl.c create mode 100644
> > drivers/soc/imx/blk-ctl.h
> >
> > --
> > 2.30.0
> >
next prev parent reply other threads:[~2021-06-30 9:34 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-29 7:29 [PATCH V8 0/4] soc: imx: add i.MX BLK-CTL support Peng Fan (OSS)
2021-06-29 7:29 ` [PATCH V8 1/4] dt-bindings: power: Add defines for i.MX8MM BLK-CTL power domains Peng Fan (OSS)
2021-06-29 7:29 ` [PATCH V8 2/4] dt-bindings: soc: imx: Add bindings for i.MX BLK_CTL Peng Fan (OSS)
2021-06-29 7:29 ` [PATCH V8 3/4] soc: imx: Add generic blk-ctl driver Peng Fan (OSS)
2021-07-05 14:55 ` Lucas Stach
2021-07-07 9:56 ` Peng Fan
2021-07-09 8:51 ` Lucas Stach
2021-07-09 10:08 ` Peng Fan
2021-07-09 12:38 ` Lucas Stach
2021-06-29 7:29 ` [PATCH V8 4/4] soc: imx: Add blk-ctl driver for i.MX8MM Peng Fan (OSS)
2021-06-29 13:26 ` [PATCH V8 0/4] soc: imx: add i.MX BLK-CTL support Adam Ford
2021-06-30 9:34 ` Peng Fan (OSS) [this message]
2021-06-30 12:09 ` Adam Ford
2021-06-30 14:46 ` Frieder Schrempf
2021-06-30 16:28 ` Marek Vasut
2021-06-30 17:20 ` Frieder Schrempf
2021-07-01 7:32 ` Frieder Schrempf
2021-07-02 3:24 ` Peng Fan
2021-07-05 10:45 ` Frieder Schrempf
2021-07-07 20:11 ` Benjamin Gaignard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB6PR0402MB2760B05081D54D775B8949CA88019@DB6PR0402MB2760.eurprd04.prod.outlook.com \
--to=peng.fan@oss.nxp.com \
--cc=abel.vesa@nxp.com \
--cc=aford173@gmail.com \
--cc=agx@sigxcpu.org \
--cc=andrew.smirnov@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=frieder.schrempf@kontron.de \
--cc=jagan@amarulasolutions.com \
--cc=kernel@pengutronix.de \
--cc=krzk@kernel.org \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
--cc=p.zabel@pengutronix.de \
--cc=ping.bai@nxp.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).