From: Hadar Gat <Hadar.Gat@arm.com>
To: Rob Herring <robh@kernel.org>
Cc: Matt Mackall <mpm@selenic.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Mark Rutland <Mark.Rutland@arm.com>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Daniel Thompson <daniel.thompson@linaro.org>,
Tomer Maimon <tmaimon77@gmail.com>,
Stefan Wahren <wahrenst@gmx.net>,
Sumit Garg <sumit.garg@linaro.org>, Zaibo Xu <xuzaibo@huawei.com>,
Weili Qian <qianweili@huawei.com>,
Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Gilad Ben-Yossef <gilad@benyossef.com>,
Ofir Drang <Ofir.Drang@arm.com>, nd <nd@arm.com>
Subject: RE: [PATCH v2 1/3] dt-bindings: add device tree binding for Arm CryptoCell trng engine
Date: Thu, 13 Feb 2020 10:21:37 +0000 [thread overview]
Message-ID: <DB6PR0802MB2533EEED9A552E96AC40184CE91A0@DB6PR0802MB2533.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <CAL_Jsq+F8mW7oUBCXMgzEVb3Bz2pHxU=bFjo97QisMZN92PaQw@mail.gmail.com>
Thanks Rob for your clarifications. I surly learned more about .yaml schema.
All fixes will be applied in the next patch version (v4).
Hadar
> On Sun, Feb 9, 2020 at 3:34 AM Hadar Gat <Hadar.Gat@arm.com> wrote:
> >
> > Hi Rob,
> > Thanks for remarks.
> > Please see my answers.
> > Hadar
> >
> > > On Sun, Feb 02, 2020 at 03:26:59PM +0200, Hadar Gat wrote:
> > > > The Arm CryptoCell is a hardware security engine. This patch adds
> > > > DT bindings for its TRNG (True Random Number Generator) engine.
> > > >
> > > > Signed-off-by: Hadar Gat <hadar.gat@arm.com>
> > > > ---
> > > > .../devicetree/bindings/rng/arm-cctrng.yaml | 51
> > > ++++++++++++++++++++++
> > > > 1 file changed, 51 insertions(+)
> > > > create mode 100644
> > > > Documentation/devicetree/bindings/rng/arm-cctrng.yaml
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/rng/arm-cctrng.yaml
> > > > b/Documentation/devicetree/bindings/rng/arm-cctrng.yaml
> > > > new file mode 100644
> > > > index 0000000..fe9422e
> > > > --- /dev/null
> > > > +++ b/Documentation/devicetree/bindings/rng/arm-cctrng.yaml
> > > > @@ -0,0 +1,51 @@
> > > > +# SPDX-License-Identifier: GPL-2.0
> > >
> > > Dual license new bindings:
> > >
> > > (GPL-2.0-only OR BSD-2-Clause)
> > >
> > Okay.
> >
> > > > +%YAML 1.2
> > > > +---
> > > > +$id: http://devicetree.org/schemas/rng/arm-cctrng.yaml#
> > > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > > +
> > > > +title: Arm ZrustZone CryptoCell TRNG engine
> > > > +
> > > > +maintainers:
> > > > + - Hadar Gat <hadar.gat@arm.com>
> > > > +
> > > > +description: |+
> > > > + Arm ZrustZone CryptoCell TRNG (True Random Number Generator)
> > > engine.
> > > > +
> > > > +properties:
> > > > + compatible:
> > > > + description: Should be "arm,cryptocell-7x3-trng"
> > >
> > > Drop. That's what the schema says.
> > >
> > Okay.
> >
> > > > + const: arm,cryptocell-7x3-trng
> > >
> > > Is 'x' a wildcard? We don't do wildcards unless you have other ways
> > > to get the specific version.
> > >
> > Kind of a wildcard. It stands for either 703 or 713.
> > Should I fix this to the specific versions?
> > OR,
> > Since the specific version doesn't matter to the driver, should it changed?
>
> Maybe not now, but both will always have the same errata and features?
> 2 is not a large number, so just do 2.
>
> Of course, errata can vary by revision. Most Arm IP has version registers, so I
> assume that's true here. If not, we'd need per SoC implementation
> compatible strings here.
>
> > (checking out other rng drivers, I see this example in
> Samsung,exynos4.yaml:
> > - samsung,exynos4-rng # for Exynos4210 and Exynos4412 )
>
> Well, there's lots of bad examples, and also, some Samsung bindings are
> declared to not be stable.
>
> >
> > > > +
> > > > + interrupts:
> > > > + description: Interrupt number for the device.
> > >
> > > Drop. That's all 'interrupts'.
> > >
> > Okay.
> >
> > > > + maxItems: 1
> > > > +
> > > > + reg:
> > > > + description: Base physical address of the engine and length of
> memory
> > > > + mapped region.
> > >
> > > Drop.
> > >
> > Okay.
> >
> > > > + maxItems: 1
> > > > +
> > > > + rosc-ratio:
> > > > + description: Sampling ratio values from calibration for 4 ring
> oscillators.
> > > > + maxItems: 1
> > >
> > > Is this an array?
> > >
> > Yes, array of 4. (I'll mention in the description)
>
> Don't need a description as that's constraints the schema should express.
>
> > > Needs a vendor prefix, a type ref and any constraints you can come up
> with.
> > >
> > Do you mean in the name? instead of "rosc-ratio"?
>
> arm,rosc-ratio:
> allOf:
> - $ref: /schemas/types.yaml#/definitions/uint32-array
> maxItems: 4
>
> > I didn't find anything about it in the documentation or examples in other
> rng drivers..
> >
> > > > +
> > > > + clocks:
> > > > + description: Reference to the crypto engine clock.
> > >
> > > How many clocks?
> > >
> > One clock. (I will change clocks --> clock)
>
> No, the property name is always 'clocks'. You need just 'maxItems: 1'
> if there's a single clock.
>
> Rob
next prev parent reply other threads:[~2020-02-13 10:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-02 13:26 [PATCH v2 0/3] hw_random: introduce Arm CryptoCell TRNG driver Hadar Gat
2020-02-02 13:26 ` [PATCH v2 1/3] dt-bindings: add device tree binding for Arm CryptoCell trng engine Hadar Gat
2020-02-06 18:56 ` Rob Herring
2020-02-09 9:33 ` Hadar Gat
2020-02-11 18:39 ` Rob Herring
2020-02-13 10:21 ` Hadar Gat [this message]
2020-02-02 13:27 ` [PATCH v2 2/3] hw_random: cctrng: introduce Arm CryptoCell driver Hadar Gat
2020-02-02 13:27 ` [PATCH v2 3/3] MAINTAINERS: add HG as cctrng maintainer Hadar Gat
2020-02-03 10:11 ` Andy Shevchenko
2020-02-05 9:22 ` Hadar Gat
2020-02-05 13:40 ` Andy Shevchenko
2020-02-03 9:54 ` [PATCH v2 0/3] hw_random: introduce Arm CryptoCell TRNG driver Arnd Bergmann
2020-02-05 8:56 ` Hadar Gat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB6PR0802MB2533EEED9A552E96AC40184CE91A0@DB6PR0802MB2533.eurprd08.prod.outlook.com \
--to=hadar.gat@arm.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=Mark.Rutland@arm.com \
--cc=Ofir.Drang@arm.com \
--cc=arnd@arndb.de \
--cc=daniel.thompson@linaro.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=gilad@benyossef.com \
--cc=gregkh@linuxfoundation.org \
--cc=herbert@gondor.apana.org.au \
--cc=krzk@kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab+samsung@kernel.org \
--cc=mpm@selenic.com \
--cc=nd@arm.com \
--cc=qianweili@huawei.com \
--cc=robh@kernel.org \
--cc=sumit.garg@linaro.org \
--cc=tmaimon77@gmail.com \
--cc=wahrenst@gmx.net \
--cc=xuzaibo@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).