devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: imx7d-pinfunc: add input mux for UART2 RX DTE mode
@ 2016-05-05 20:12 Stefan Agner
  2016-05-05 20:29 ` Frank Li
  0 siblings, 1 reply; 2+ messages in thread
From: Stefan Agner @ 2016-05-05 20:12 UTC (permalink / raw)
  To: shawnguo
  Cc: kernel, Frank.Li, aalonso, devicetree, linux-arm-kernel,
	linux-kernel, Stefan Agner

Add input mux for UART2 RX in DTE mode. This allows to use the pad
UART2_TX_DATA_ALT0 as UART2 RX. This particular input select seems
to be missing in current reference manuals (Rev. B), but when looking
at the tables and other UART input select registers (e.g. UART3) it
seems naturally that this input mux register also has a fourth pad
option for UART2_TX_DATA_ALT0. It has also been proven to be required
to use UART2 in DTE mode and the particular pads on the Colibri iMX7
platform.

Signed-off-by: Stefan Agner <stefan@agner.ch>
---
 arch/arm/boot/dts/imx7d-pinfunc.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/imx7d-pinfunc.h b/arch/arm/boot/dts/imx7d-pinfunc.h
index eeda783..3f9f0d9 100644
--- a/arch/arm/boot/dts/imx7d-pinfunc.h
+++ b/arch/arm/boot/dts/imx7d-pinfunc.h
@@ -594,7 +594,7 @@
 #define MX7D_PAD_UART2_RX_DATA__GPIO4_IO2                         0x0130 0x03A0 0x0000 0x5 0x0
 #define MX7D_PAD_UART2_RX_DATA__ENET2_MDIO                        0x0130 0x03A0 0x0000 0x6 0x0
 #define MX7D_PAD_UART2_TX_DATA__UART2_DCE_TX                      0x0134 0x03A4 0x0000 0x0 0x0
-#define MX7D_PAD_UART2_TX_DATA__UART2_DTE_RX                      0x0134 0x03A4 0x0000 0x0 0x0
+#define MX7D_PAD_UART2_TX_DATA__UART2_DTE_RX                      0x0134 0x03A4 0x06FC 0x0 0x3
 #define MX7D_PAD_UART2_TX_DATA__I2C2_SDA                          0x0134 0x03A4 0x05E0 0x1 0x0
 #define MX7D_PAD_UART2_TX_DATA__SAI3_RX_DATA0                     0x0134 0x03A4 0x06C8 0x2 0x0
 #define MX7D_PAD_UART2_TX_DATA__ECSPI1_RDY                        0x0134 0x03A4 0x0000 0x3 0x0
-- 
2.8.2

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* RE: [PATCH] ARM: dts: imx7d-pinfunc: add input mux for UART2 RX DTE mode
  2016-05-05 20:12 [PATCH] ARM: dts: imx7d-pinfunc: add input mux for UART2 RX DTE mode Stefan Agner
@ 2016-05-05 20:29 ` Frank Li
  0 siblings, 0 replies; 2+ messages in thread
From: Frank Li @ 2016-05-05 20:29 UTC (permalink / raw)
  To: Stefan Agner, shawnguo, Fugang Duan
  Cc: devicetree, aalonso, Frank.Li, linux-kernel, kernel, linux-arm-kernel



> -----Original Message-----
> From: Stefan Agner [mailto:stefan@agner.ch]
> Sent: Thursday, May 05, 2016 3:12 PM
> To: shawnguo@kernel.org
> Cc: kernel@pengutronix.de; Frank.Li@freescale.com;
> aalonso@freescale.com; devicetree@vger.kernel.org; linux-arm-
> kernel@lists.infradead.org; linux-kernel@vger.kernel.org; Stefan Agner
> <stefan@agner.ch>
> Subject: [PATCH] ARM: dts: imx7d-pinfunc: add input mux for UART2 RX DTE
> mode
> 
> Add input mux for UART2 RX in DTE mode. This allows to use the pad
> UART2_TX_DATA_ALT0 as UART2 RX. This particular input select seems to be
> missing in current reference manuals (Rev. B), but when looking at the tables
> and other UART input select registers (e.g. UART3) it seems naturally that this
> input mux register also has a fourth pad option for UART2_TX_DATA_ALT0. It
> has also been proven to be required to use UART2 in DTE mode and the
> particular pads on the Colibri iMX7 platform.
> 
> Signed-off-by: Stefan Agner <stefan@agner.ch>

Acked-by: Frank Li  <Frank.Li@nxp.com>

> ---
>  arch/arm/boot/dts/imx7d-pinfunc.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/imx7d-pinfunc.h b/arch/arm/boot/dts/imx7d-
> pinfunc.h
> index eeda783..3f9f0d9 100644
> --- a/arch/arm/boot/dts/imx7d-pinfunc.h
> +++ b/arch/arm/boot/dts/imx7d-pinfunc.h
> @@ -594,7 +594,7 @@
>  #define MX7D_PAD_UART2_RX_DATA__GPIO4_IO2                         0x0130
> 0x03A0 0x0000 0x5 0x0
>  #define MX7D_PAD_UART2_RX_DATA__ENET2_MDIO                        0x0130
> 0x03A0 0x0000 0x6 0x0
>  #define MX7D_PAD_UART2_TX_DATA__UART2_DCE_TX                      0x0134
> 0x03A4 0x0000 0x0 0x0
> -#define MX7D_PAD_UART2_TX_DATA__UART2_DTE_RX                      0x0134
> 0x03A4 0x0000 0x0 0x0
> +#define MX7D_PAD_UART2_TX_DATA__UART2_DTE_RX                      0x0134
> 0x03A4 0x06FC 0x0 0x3
>  #define MX7D_PAD_UART2_TX_DATA__I2C2_SDA                          0x0134
> 0x03A4 0x05E0 0x1 0x0
>  #define MX7D_PAD_UART2_TX_DATA__SAI3_RX_DATA0                     0x0134
> 0x03A4 0x06C8 0x2 0x0
>  #define MX7D_PAD_UART2_TX_DATA__ECSPI1_RDY                        0x0134
> 0x03A4 0x0000 0x3 0x0
> --
> 2.8.2

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-05-05 20:29 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-05-05 20:12 [PATCH] ARM: dts: imx7d-pinfunc: add input mux for UART2 RX DTE mode Stefan Agner
2016-05-05 20:29 ` Frank Li

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).