From: Jolly Shah <JOLLYS@xilinx.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: "ard.biesheuvel@linaro.org" <ard.biesheuvel@linaro.org>,
"mingo@kernel.org" <mingo@kernel.org>,
"matt@codeblueprint.co.uk" <matt@codeblueprint.co.uk>,
"sudeep.holla@arm.com" <sudeep.holla@arm.com>,
"hkallweit1@gmail.com" <hkallweit1@gmail.com>,
"keescook@chromium.org" <keescook@chromium.org>,
"dmitry.torokhov@gmail.com" <dmitry.torokhov@gmail.com>,
"michal.simek@xilinx.com" <michal.simek@xilinx.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Rajan Vaja <RAJANV@xilinx.com>
Subject: RE: [PATCH v2 3/4] drivers: firmware: xilinx: Add sysfs interface
Date: Wed, 24 Jan 2018 23:30:43 +0000 [thread overview]
Message-ID: <DM2PR0201MB076735ACCF46914F426ACA2AB8E20@DM2PR0201MB0767.namprd02.prod.outlook.com> (raw)
In-Reply-To: <20180123083732.GA21463@kroah.com>
Thanks for review Greg,
> -----Original Message-----
> From: Greg KH [mailto:gregkh@linuxfoundation.org]
> Sent: Tuesday, January 23, 2018 12:38 AM
> To: Jolly Shah <JOLLYS@xilinx.com>
> Cc: ard.biesheuvel@linaro.org; mingo@kernel.org; matt@codeblueprint.co.uk;
> sudeep.holla@arm.com; hkallweit1@gmail.com; keescook@chromium.org;
> dmitry.torokhov@gmail.com; michal.simek@xilinx.com; robh+dt@kernel.org;
> mark.rutland@arm.com; linux-arm-kernel@lists.infradead.org; linux-
> kernel@vger.kernel.org; devicetree@vger.kernel.org; Rajan Vaja
> <RAJANV@xilinx.com>; Jolly Shah <JOLLYS@xilinx.com>
> Subject: Re: [PATCH v2 3/4] drivers: firmware: xilinx: Add sysfs interface
>
> On Wed, Jan 17, 2018 at 12:20:33PM -0800, Jolly Shah wrote:
> > Add Firmware-ggs sysfs interface which provides read/write interface
> > to global storage registers.
> >
> > Signed-off-by: Jolly Shah <jollys@xilinx.com>
> > Signed-off-by: Rajan Vaja <rajanv@xilinx.com>
> > ---
> > .../ABI/stable/sysfs-driver-zynqmp-firmware | 33 +++
> > drivers/firmware/xilinx/zynqmp/Makefile | 2 +-
> > drivers/firmware/xilinx/zynqmp/firmware-ggs.c | 298
> +++++++++++++++++++++
> > drivers/firmware/xilinx/zynqmp/firmware.c | 26 ++
> > include/linux/firmware/xilinx/zynqmp/firmware.h | 2 +
> > 5 files changed, 360 insertions(+), 1 deletion(-) create mode 100644
> > Documentation/ABI/stable/sysfs-driver-zynqmp-firmware
> > create mode 100644 drivers/firmware/xilinx/zynqmp/firmware-ggs.c
> >
> > +
> > +#include <linux/firmware/xilinx/zynqmp/firmware.h>
>
> That's crazy deep nesting, why?
It needs to be in include/linux to be used by other drivers and as it is Xilinx specific, we have it in subdirectory.
>
> > +
> > +static ssize_t read_register(char *buf, u32 ioctl_id, u32 reg) {
> > + int ret;
> > + u32 ret_payload[PAYLOAD_ARG_CNT];
> > + const struct zynqmp_eemi_ops *eemi_ops = get_eemi_ops();
> > +
> > + if (!eemi_ops || !eemi_ops->ioctl)
> > + return 0;
>
> Not an error?
Fixed in v3 patch series.
>
> > +
> > + ret = eemi_ops->ioctl(0, ioctl_id, reg, 0, ret_payload);
> > + if (ret)
> > + return ret;
> > +
> > + return snprintf(buf, PAGE_SIZE, "0x%x\n", ret_payload[1]);
>
> Minor nit, you never need to use snprintf() for a sysfs file, as you "know" the size
> and you can't overflow it with just a single value.
>
> Yeah, some tool-checkers hate to see a "raw" sprintf() call, but really, ignore
> them here :)
Changed to sprint in v3 patch series.
> > +
> > + /* Read the write value */
> > + tok = strsep(&inbuf, " ");
> > + if (!tok) {
> > + ret = -EFAULT;
> > + goto err;
> > + }
> > +
> > + ret = kstrtol(tok, 16, &value);
> > + if (ret) {
> > + ret = -EFAULT;
> > + goto err;
> > + }
>
> What exactly is the format for the data to be written here? You do not
> document it in the ABI/ file above, and it looks to be non-trivial to understand
> from the code :(
>
Updated documentation in v3 patch series.
> > +
> > +#define CREATE_PGGS_DEVICE(dev, N) \
> > +do { \
> > + if (device_create_file(dev, &dev_attr_pggs##N)) \
> > + dev_err(dev, "unable to create pggs%d attribute\n",
> > +N); \
>
> Ick, no, just use an attribute group please. Handles all of this mess for you
> automatically, and will unwind properly if you have an error (which this macro
> does not do.)
>
> thanks,
>
> greg k-h
Fixed in v3 patch series.
Thanks,
Jolly Shah
prev parent reply other threads:[~2018-01-24 23:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-17 20:20 [PATCH v2 0/4] drivers: firmware: xilinx: Add firmware driver support Jolly Shah
[not found] ` <1516220434-22204-1-git-send-email-jollys-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>
2018-01-17 20:20 ` [PATCH v2 1/4] dt-bindings: firmware: Add bindings for ZynqMP firmware Jolly Shah
2018-01-17 20:20 ` [PATCH v2 4/4] drivers: firmware: xilinx: Add debugfs interface Jolly Shah
[not found] ` <1516220434-22204-5-git-send-email-jollys-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>
2018-01-23 8:41 ` Greg KH
2018-01-24 23:33 ` Jolly Shah
2018-01-17 20:20 ` [PATCH v2 2/4] drivers: firmware: xilinx: Add ZynqMP firmware driver Jolly Shah
2018-01-23 8:38 ` Greg KH
[not found] ` <20180123083823.GB21463-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2018-01-24 23:28 ` Jolly Shah
2018-01-17 20:20 ` [PATCH v2 3/4] drivers: firmware: xilinx: Add sysfs interface Jolly Shah
2018-01-23 8:37 ` Greg KH
2018-01-24 23:30 ` Jolly Shah [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM2PR0201MB076735ACCF46914F426ACA2AB8E20@DM2PR0201MB0767.namprd02.prod.outlook.com \
--to=jollys@xilinx.com \
--cc=RAJANV@xilinx.com \
--cc=ard.biesheuvel@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hkallweit1@gmail.com \
--cc=keescook@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=matt@codeblueprint.co.uk \
--cc=michal.simek@xilinx.com \
--cc=mingo@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).