From: "Togorean, Bogdan" <Bogdan.Togorean@analog.com> To: Sam Ravnborg <firstname.lastname@example.org> Cc: "email@example.com" <firstname.lastname@example.org>, "email@example.com" <firstname.lastname@example.org>, Thomas Zimmermann <email@example.com>, Mike Looijmans <firstname.lastname@example.org>, "email@example.com" <firstname.lastname@example.org>, David Airlie <email@example.com>, Rob Herring <firstname.lastname@example.org>, "Ardelean, Alexandru" <alexandru.Ardelean@analog.com> Subject: RE: [PATCH 1/2] drm/adi: axi-hdmi-tx: Add support for AXI HDMI TX IP core Date: Fri, 23 Oct 2020 08:51:48 +0000 [thread overview] Message-ID: <DM6PR03MB52748E16A02E8AE049379D569B1A0@DM6PR03MB5274.namprd03.prod.outlook.com> (raw) In-Reply-To: <20201016145500.GA1325536@ravnborg.org> Thank you Sam for your review, I'll send now V2 implementing all your remarks. Best regards, Bogdan > > Hi Bogdan > > On Mon, Oct 05, 2020 at 05:12:08PM +0300, Bogdan Togorean wrote: > > From: Lars-Peter Clausen <email@example.com> > > > > The AXI HDMI HDL driver is the driver for the HDL graphics core which is > > used on various FPGA designs. It's mostly used to interface with the > > ADV7511 driver on some Zynq boards (e.g. ZC702 & ZedBoard). > > > > Link: https://wiki.analog.com/resources/tools-software/linux-drivers/drm/hdl- > axi-hdmi > > Link: https://wiki.analog.com/resources/fpga/docs/axi_hdmi_tx > > Thanks for submitting the driver - a few high level comments after > browsing the driver: > > - Use drmm_mode_config_init() to utilize new cleanup > - Look at other uses of drm_driver - there is macros that makes this > much simpler / smaller > - Use devm_drm_dev_alloc() to allocate axi_hdmi_tx_private > To do so embed drm_device in axi_hdmi_tx_private - which is the way to > do it today > - Do not use ddev->dev_private, it is deprecated > - Use dev_err_probe() when you risk to see a PROBE_DEFER > - In all include blocks sort the include alphabetically > - Use the new interface to drm_bridge_attach() - where display driver > creates the connector > - See if the Kconfig selects can be trimmed - the framebuffer releated > selects looks wrong (others get it wrong too) > - Check if you can use the simple encoder - see > drm_simple_encoder_init() > > If this is a simple one plane, one crtc display driver then it should > use the drm_simple_* support. Or the changelog should explain why not. > > We want the drivers as simple as we can - and they shall use as much of > the helper infrastructure as they can. > > We continue to develop the helper infrastructure so it is expected that > there is some lacking behind as is the case here. > > Sam >
prev parent reply other threads:[~2020-10-23 8:52 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-10-05 14:12 Bogdan Togorean 2020-10-05 14:12 ` [PATCH 2/2] drm: dt-bindings: adi: axi-hdmi-tx: Add DT bindings for axi-hdmi-tx Bogdan Togorean 2020-10-06 22:00 ` Rob Herring 2020-10-16 14:55 ` [PATCH 1/2] drm/adi: axi-hdmi-tx: Add support for AXI HDMI TX IP core Sam Ravnborg 2020-10-23 8:51 ` Togorean, Bogdan [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=DM6PR03MB52748E16A02E8AE049379D569B1A0@DM6PR03MB5274.namprd03.prod.outlook.com \ --firstname.lastname@example.org \ --email@example.com \ --cc=alexandru.Ardelean@analog.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='RE: [PATCH 1/2] drm/adi: axi-hdmi-tx: Add support for AXI HDMI TX IP core' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).