From mboxrd@z Thu Jan 1 00:00:00 1970 From: Icenowy Zheng Subject: Re: [linux-sunxi] Re: [PATCH v2 14/16] arm: dts: sun8i: h3: enable H3 sid controller Date: Thu, 19 Apr 2018 23:13:09 +0800 Message-ID: References: <20180128232919.12639-1-embed3d@gmail.com> <20180128232919.12639-15-embed3d@gmail.com> <20180129095200.attg7cgvpifpchtn@flea.lan> <470ec61e-8b08-5193-ede1-01d02b2c865e@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Kyle Evans , embed3d@gmail.com Cc: Maxime Ripard , lee.jones@linaro.org, Rob Herring , Mark Rutland , Chen-Yu Tsai , Russell King , jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, davem@davemloft.net, hans.verkuil@cisco.com, mchehab@kernel.org, rask@formelder.dk, clabbe.montjoie@gmail.com, sean@mess.org, krzk@kernel.org, quentin.schulz@free-electrons.com, edu.molinas@gmail.com, singhalsimran0@gmail.com, linux-iio@vger.kernel.org, devicetree , linux-arm-kernel , linux-kernel , linux-sunxi List-Id: devicetree@vger.kernel.org 于 2018年4月19日 GMT+08:00 下午11:11:22, Kyle Evans 写到: >On Mon, Jan 29, 2018 at 6:03 AM, Philipp Rossak >wrote: >> >> >> On 29.01.2018 10:52, Maxime Ripard wrote: >>> >>> On Mon, Jan 29, 2018 at 12:29:17AM +0100, Philipp Rossak wrote: >>>> >>>> This patch enables the the sid controller in the H3. It can be used >>>> for thermal calibration data. >>>> >>>> Signed-off-by: Philipp Rossak >>>> --- >>>> arch/arm/boot/dts/sun8i-h3.dtsi | 7 +++++++ >>>> 1 file changed, 7 insertions(+) >>>> >>>> diff --git a/arch/arm/boot/dts/sun8i-h3.dtsi >>>> b/arch/arm/boot/dts/sun8i-h3.dtsi >>>> index 3f83f6a27c74..9bb5cc29fec5 100644 >>>> --- a/arch/arm/boot/dts/sun8i-h3.dtsi >>>> +++ b/arch/arm/boot/dts/sun8i-h3.dtsi >>>> @@ -72,6 +72,13 @@ >>>> }; >>>> }; >>>> + soc { >>>> + sid: eeprom@1c14000 { >>>> + compatible = "allwinner,sun8i-h3-sid"; >>>> + reg = <0x01c14000 0x400>; >>>> + }; >>>> + }; >>>> + >>> >>> >>> Shouldn't you also use a nvmem-cells property to the THS node? >>> >>> Maxime >>> >> >> Oh seems like I forgot that. >> As related to the wiki [1] this should be 64 bit wide at the address >0x34. I >> will add that in the next version. >> >> >> [1]: http://linux-sunxi.org/SID_Register_Guide#eFUSE >> >> Thanks, >> Philipp >> > >Hi, > >Any chance this will see a v3 soon? I'm kind of interested in sid node >for h3. =) This patch is independent and can be easily sent out by its own. > >Thanks, > >Kyle Evans