From: Paul Cercueil <paul@crapouillou.net>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Thierry Reding <thierry.reding@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, list@opendingux.net,
Christophe Branchereau <cbranchereau@gmail.com>
Subject: Re: [PATCH 1/2] dt-bindings: display/panel: Add Innolux EJ030NA
Date: Sat, 10 Jul 2021 10:42:53 +0100 [thread overview]
Message-ID: <HBW0WQ.NHPOJDIT9XWR1@crapouillou.net> (raw)
In-Reply-To: <YOk60yTP9L1gT3+W@ravnborg.org>
Hi Sam, thanks for the review.
Le sam., juil. 10 2021 at 08:14:43 +0200, Sam Ravnborg
<sam@ravnborg.org> a écrit :
> Hi Paul,
>
> On Fri, Jun 25, 2021 at 01:10:44PM +0100, Paul Cercueil wrote:
>> Add binding for the Innolux EJ030NA panel, which is a 320x480 3.0"
>> 4:3
>> 24-bit TFT LCD panel with non-square pixels and a delta-RGB 8-bit
>> interface.
>>
>> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
>> ---
>> .../display/panel/innolux,ej030na.yaml | 62
>> +++++++++++++++++++
>> 1 file changed, 62 insertions(+)
>> create mode 100644
>> Documentation/devicetree/bindings/display/panel/innolux,ej030na.yaml
>>
>> diff --git
>> a/Documentation/devicetree/bindings/display/panel/innolux,ej030na.yaml
>> b/Documentation/devicetree/bindings/display/panel/innolux,ej030na.yaml
>> new file mode 100644
>> index 000000000000..cda36c04e85c
>> --- /dev/null
>> +++
>> b/Documentation/devicetree/bindings/display/panel/innolux,ej030na.yaml
>> @@ -0,0 +1,62 @@
>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id:
>> http://devicetree.org/schemas/display/panel/innolux,ej030na.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Innolux EJ030NA 3.0" (320x480 pixels) 24-bit TFT LCD panel
>> +
>> +description: |
>> + The panel must obey the rules for a SPI slave device as
>> specified in
>> + spi/spi-controller.yaml
>> +
>> +maintainers:
>> + - Paul Cercueil <paul@crapouillou.net>
>> +
>> +allOf:
>> + - $ref: panel-common.yaml#
>> +
>> +properties:
>> + compatible:
>> + const: innolux,ej030na
>> +
>> + backlight: true
>> + port: true
>> + power-supply: true
>> + reg: true
>> + reset-gpios: true
>> +
>> +required:
>> + - compatible
>> + - reg
>> + - power-supply
>> + - reset-gpios
>> +
>> +unevaluatedProperties: false
> I had expected:
> additionalProperties: false
>
> With this fixed:
> Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
I am not sure; the doc states that this (additionalProperties: false)
"can't be used in case where another schema is referenced", which is
the case here, as we include "panel-common.yaml".
Cheers,
-Paul
>> +
>> +examples:
>> + - |
>> + #include <dt-bindings/gpio/gpio.h>
>> +
>> + spi {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + panel@0 {
>> + compatible = "innolux,ej030na";
>> + reg = <0>;
>> +
>> + spi-max-frequency = <10000000>;
>> +
>> + reset-gpios = <&gpe 4 GPIO_ACTIVE_LOW>;
>> + power-supply = <&lcd_power>;
>> +
>> + backlight = <&backlight>;
>> +
>> + port {
>> + panel_input: endpoint {
>> + remote-endpoint = <&panel_output>;
>> + };
>> + };
>> + };
>> + };
>> --
>> 2.30.2
next prev parent reply other threads:[~2021-07-10 9:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-25 12:10 [PATCH 1/2] dt-bindings: display/panel: Add Innolux EJ030NA Paul Cercueil
2021-06-25 12:10 ` [PATCH 2/2] drm/panel: Add Innolux EJ030NA 3.0" 320x480 panel Paul Cercueil
[not found] ` <YOk7xCNes0VTCG21@ravnborg.org>
2021-07-14 20:51 ` Paul Cercueil
[not found] ` <YOk60yTP9L1gT3+W@ravnborg.org>
2021-07-10 9:42 ` Paul Cercueil [this message]
[not found] ` <YOlvev0nvXVYU01y@ravnborg.org>
2021-07-10 10:21 ` [PATCH 1/2] dt-bindings: display/panel: Add Innolux EJ030NA Paul Cercueil
2021-07-14 20:30 ` Rob Herring
2021-07-14 20:40 ` Paul Cercueil
2021-07-14 20:30 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=HBW0WQ.NHPOJDIT9XWR1@crapouillou.net \
--to=paul@crapouillou.net \
--cc=cbranchereau@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=list@opendingux.net \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).