From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F02FBC07E9C for ; Sat, 10 Jul 2021 10:22:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D6A91613D2 for ; Sat, 10 Jul 2021 10:22:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232135AbhGJKYv (ORCPT ); Sat, 10 Jul 2021 06:24:51 -0400 Received: from aposti.net ([89.234.176.197]:57962 "EHLO aposti.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230443AbhGJKYv (ORCPT ); Sat, 10 Jul 2021 06:24:51 -0400 Date: Sat, 10 Jul 2021 11:21:56 +0100 From: Paul Cercueil Subject: Re: [PATCH 1/2] dt-bindings: display/panel: Add Innolux EJ030NA To: Sam Ravnborg Cc: Thierry Reding , Rob Herring , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, list@opendingux.net, Christophe Branchereau Message-Id: In-Reply-To: References: <20210625121045.81711-1-paul@crapouillou.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org [...] >> I am not sure; the doc states that this (additionalProperties: >> false) "can't >> be used in case where another schema is referenced", which is the >> case here, >> as we include "panel-common.yaml". > > This DT schema already list all relevant properties like: > > backlight: true > > So "additionalProperties: false" tells that no other properties are > allowed other than the listed properties. > > To my best understanding unevaluatedProperties: false is less strict > and > should be used if one does not list all possilbe properties. > This could be the case for a panel haging below a SPI controller as in > this case. So in other words giving this some extra thought I think > unevaluatedProperties: false is OK here. A panel below a SPI controller would have all its SPI-specific properties covered by spi-controller.yaml, I believe? So maybe "additionalProperties: false" would work? In any case, if I use "additionalProperties: false", "make dt_binding_check" complains that my example's "spi-max-frequency" property is not covered. So maybe you are right. > So my r-b is ok if you keep it as it. > > PS. Where do you guys hang out with the downfall of freenode - > somewhere > on oftc? We moved to #opendingux on Libera. Cheers, -Paul